Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F765C77B76 for ; Mon, 17 Apr 2023 10:42:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E62785EC9; Mon, 17 Apr 2023 12:42:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cocFQJof"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E83D885EE0; Mon, 17 Apr 2023 12:42:17 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 187A485DA2 for ; Mon, 17 Apr 2023 12:42:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 749E461B20; Mon, 17 Apr 2023 10:42:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83CC9C433D2; Mon, 17 Apr 2023 10:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681728131; bh=WzynOV8v9eSyCul0kXP+Vi0xFtActgRkBEggsRhGAaM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cocFQJofJWzAXkOWOb+F6NsMp1oPEWoKrlpgo3C0EHJ6QO54oGo6NokbdbvTdUAYt 2VAVdsxRPd35lD3uqAxeY284jcga5UFwPIEPTygicxDZEFirt5LAj34kJX0KOyjy0/ 4uucqNFXKYQqjwiJk6hwuK7jo81xByrdYmiH3U/xE4MaJZ9OdroiosP1m2dAqGwTIP ZjWFXaLI/sP7NrU9vEFz1Gkqz7LexEJ6qKSctvVeQj5X7NYFc2NPh2uqKN2dNc9tmW grKegSJ6C0firM+l7s99S7IZaqF1WfdoUSxEXHvVkjSpkiTwaGnNecHmNJWWMsNJ9s PXyZTnkkSoRKQ== Message-ID: <3bdf9e7a-85d3-9fab-c9a5-b6730f076285@kernel.org> Date: Mon, 17 Apr 2023 13:42:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 04/23] arm: dts: k3-am642-sk: Fix mmc1 pinmux pull polarity Content-Language: en-US To: Nishanth Menon , Simon Glass , Vignesh Raghavendra , Tom Rini Cc: Neil Armstrong , Anand Gadiyar , Georgi Vlaev , u-boot@lists.denx.de, Neha Malcom Francis , Nikhil M Jain References: <20230414075726.387461-1-nm@ti.com> <20230414075726.387461-5-nm@ti.com> From: Roger Quadros In-Reply-To: <20230414075726.387461-5-nm@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 14/04/2023 10:57, Nishanth Menon wrote: > Fix the pinmux pull polarity. > > This is a pending upstream kernel updates as of v6.3-rc6. > > Signed-off-by: Nishanth Menon > --- > Sent to kernel.org https://lore.kernel.org/linux-devicetree/20230414073328.381336-1-nm@ti.com/ Link to actual patch is https://lore.kernel.org/linux-devicetree/20230414073328.381336-3-nm@ti.com/ > > arch/arm/dts/k3-am642-sk.dts | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/dts/k3-am642-sk.dts b/arch/arm/dts/k3-am642-sk.dts > index 4fb279489cfc..cc2027417e86 100644 > --- a/arch/arm/dts/k3-am642-sk.dts > +++ b/arch/arm/dts/k3-am642-sk.dts > @@ -223,15 +223,17 @@ > > &main_pmx0 { > main_mmc1_pins_default: main-mmc1-pins-default { > + /* XXX: Kernel-Upstream: TODO: Upstream (pull changes) */ Do we really want to sprinkle these comments in u-boot upstream? If we are quite sure this makes to upstream kernel we might as well pull them into u-boot as is. > pinctrl-single,pins = < > - AM64X_IOPAD(0x0294, PIN_INPUT, 0) /* (J19) MMC1_CMD */ > + AM64X_IOPAD(0x029c, PIN_INPUT_PULLUP, 0) /* (C20) MMC1_SDWP */ > + AM64X_IOPAD(0x0298, PIN_INPUT_PULLUP, 0) /* (D19) MMC1_SDCD */ > + AM64X_IOPAD(0x0294, PIN_INPUT_PULLUP, 0) /* (J19) MMC1_CMD */ > AM64X_IOPAD(0x0290, PIN_INPUT, 0) /* (#N/A) MMC1_CLKLB */ > - AM64X_IOPAD(0x028c, PIN_INPUT, 0) /* (L20) MMC1_CLK */ > - AM64X_IOPAD(0x0288, PIN_INPUT, 0) /* (K21) MMC1_DAT0 */ > - AM64X_IOPAD(0x0284, PIN_INPUT, 0) /* (L21) MMC1_DAT1 */ > - AM64X_IOPAD(0x0280, PIN_INPUT, 0) /* (K19) MMC1_DAT2 */ > - AM64X_IOPAD(0x027c, PIN_INPUT, 0) /* (K18) MMC1_DAT3 */ > - AM64X_IOPAD(0x0298, PIN_INPUT, 0) /* (D19) MMC1_SDCD */ > + AM64X_IOPAD(0x028c, PIN_INPUT_PULLDOWN, 0) /* (L20) MMC1_CLK */ > + AM64X_IOPAD(0x0288, PIN_INPUT_PULLUP, 0) /* (K21) MMC1_DAT0 */ > + AM64X_IOPAD(0x0284, PIN_INPUT_PULLUP, 0) /* (L21) MMC1_DAT1 */ > + AM64X_IOPAD(0x0280, PIN_INPUT_PULLUP, 0) /* (K19) MMC1_DAT2 */ > + AM64X_IOPAD(0x027c, PIN_INPUT_PULLUP, 0) /* (K18) MMC1_DAT3 */ > >; > }; > cheers, -roger