From: "MaxF (Code Review)"
Date: Wed, 15 Apr 2026 20:31:46 +0000
In-Reply-To:
References:
Reply-To: max@...2606..., arne-openvpn@...1227..., davidben@...410...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <3be1071bf9597faa47fa910010850f46013a4f0a-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="6WnapVS02JM="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Fix
some CRL mixups
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: flichtenheld , davidben
Cc: plaisthos , openvpn-devel
--6WnapVS02JM=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: davidben, flichtenheld.
MaxF has posted comments on this change by davidben. ( http://gerrit.openvp=
n.net/c/openvpn/+/1289?usp=3Demail )
Change subject: ssl_openssl: Fix some CRL mixups
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1289/comment/25db34bc_0e2d0916?usp=3D=
email :
PS12, Line 321: X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->cr=
ls);
> set0/get0 in OpenSSL terms mean no copy being made. We are really passing=
the pointer. [=E2=80=A6]
Thanks for the explanations, I'll add my approval to this commit!
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe
Gerrit-Change-Number: 1289
Gerrit-PatchSet: 12
Gerrit-Owner: davidben
Gerrit-Reviewer: MaxF
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Attention: davidben
Gerrit-Comment-Date: Wed, 15 Apr 2026 20:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: MaxF
--6WnapVS02JM=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: davidben, flichtenheld.
Patch set 12:Code-Review +2
=
View Change
1 comment:
Thanks for the =
explanations, I'll add my approval to this commit!
=
ul>To view, visit change 1289. To unsubscribe, or for help writing mail filt=
ers, visit setti=
ngs.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31ac2a763209114267c35c4a918=
2a12d8d82f6fe
Gerrit-Change-Number: 1289
Gerrit-PatchSet: 12
Gerrit-Owner: davidben <davidben@...410...&=
gt;
Gerrit-Reviewer: MaxF <max@...2606...> <=
/div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: davidben <davidben@...2975...=
...>
Gerrit-Comment-Date: Wed, 15 Apr 2026 20:31:46=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: MaxF <max@...2606...&g=
t;
=
--6WnapVS02JM=--