From: "ordex (Code Review)" Date: Tue, 15 Jul 2025 14:23:00 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, ralf@...2726..., frank@...2641..., lstipakov@...277... Message-ID: <3bf17465e3e4c86e2a1c3f53daa01492fab7097a-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="XVdjD98zzA8="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: dco: Add support for float notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ralf_lici Cc: stipa , plaisthos , flichtenheld , openvpn-devel --XVdjD98zzA8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, ralf_lici, s= tipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1084?usp=3Demail ) Change subject: dco: Add support for float notifications ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: looks good to me File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1084/comment/febbeba3_6cfc1fdf : PS1, Line 3390: if (extract_dco_float_peer_addr(peer_id, &m->to= p.c2.from.dest, > Do we really need this "if"? Could we trust the kernel and just assert in= side `extract_dco_float_pee [=E2=80=A6] no, we can't trust the kernel. when talking to an external component we can= 't just assume it will always do the right thing. A bug in the kernel code = should not crash userspace. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1084?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I33e9272b4196c7634db2fb33a75ae4261660867f Gerrit-Change-Number: 1084 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ralf_lici Gerrit-Attention: stipa Gerrit-Comment-Date: Tue, 15 Jul 2025 14:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: stipa Gerrit-MessageType: comment --XVdjD98zzA8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, ralf_lic= i, stipa.

Patch set 1:Code-Review +2=

V= iew Change

2 comments:

  • Patchset:

  • File src/openvpn/multi.c:

    • Patch Set #1, Line 3390: if (extract_dco_float= _peer_addr(peer_id, &m->top.c2.from.dest,

      Do w= e really need this "if"? Could we trust the kernel and just asser= t inside `extract_dco_float_pee [=E2=80=A6]

      no, we can't trust the kern= el. when talking to an external component we can't just assume it will = always do the right thing. A bug in the kernel code should not crash usersp= ace.

To view, visit change 1084. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I33e9272b4196c7634db2fb33a75= ae4261660867f
Gerrit-Change-Number: 1084
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <ralf@...2726...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ralf_lici <ralf@...2804...= .>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Tue, 15 Jul 2025 14:23:00= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
Gerrit-MessageType: comment
--XVdjD98zzA8=--