Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BB90C433EF for ; Sun, 3 Apr 2022 23:57:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B8BC81B5C; Mon, 4 Apr 2022 01:57:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OEwt0sPl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DAA788002B; Mon, 4 Apr 2022 01:57:22 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 319888002B for ; Mon, 4 Apr 2022 01:57:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x832.google.com with SMTP id bp39so6498836qtb.6 for ; Sun, 03 Apr 2022 16:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=506tYPV1udeNI6JM8mvvVJtS3sXq+ipfr1lLN/WUhGQ=; b=OEwt0sPlB1GjLDuUSGNb8WFB3y+yKDABuB9f9Nh7h9d17NCQOCbHOYo/gGXYzfD8eO hGcEfknujc7MiX1Tt8JGsqZF7ZQr1v701syXcDCdedQNL/5hUie/1Y6NLwuCwdqOWumU cOHvntjg+meH0+SabqoZY6SZT12Uq562IUD45CtyF4Pr/Fm91sxiKm/0koZXpca9MEy5 W3t/htjohoLmmDHFxBWrc7KczIMt+3YO4DidbchfCDwyAcgl2NmDO5OLVqBrYgZgVKBC bf6LaY5OKbVPMGg25ZUjJruWkSggaPpio8FA24Tnt/Zpccvph5EUq0MVW0DQu40KW44u Kjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=506tYPV1udeNI6JM8mvvVJtS3sXq+ipfr1lLN/WUhGQ=; b=6Qj+1eqqd0mkVRo3in6YPeuhwAp4jkDbhmgfLThnvD2N3OVY0X+ZaQpD9KRjSzWlFw 2QMNpCqQAyDuPoVjT5nc6IlzQugQFbhTieJWowZ7V8jxAxN/5iXYn3BZQ3f1vsGmQfeX +q11zxooafHO+F0bTCYBBwttYxwzL/EtjJ8Z/NbeRw5BGhGHjJ8wjpj/nK+zUGQ5m5jW Jad+SuEbjHL9wtptjvYSswBeHFK7wLYls/0rjXzti2nh9pH1s0LzQXtPEQ0V76e9Sasv fNR5Pm1epNDHeCTUWYsfEC0j/Tp/2L7hB1fNSh0FwBlPHi9wDIWwyGtiB4JNMrv6xaUC eXEw== X-Gm-Message-State: AOAM5321eZwPXStkhvvqSacrM/qVw9TfFmkfP7FKeLW4EaFrGC3RwKzV PnezWYteB/Jl3DC67IlCVsc= X-Google-Smtp-Source: ABdhPJx9rbHQLlGjv3O98Y6N4Vw91ChRd5Fe4sJqHbpTKeF5Wo9YJN3+SK/0198q3s0tVfUezru8NQ== X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr15490270qtk.238.1649030231765; Sun, 03 Apr 2022 16:57:11 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id p6-20020a05622a00c600b002e1cb5b9b82sm7351307qtw.43.2022.04.03.16.57.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 16:57:11 -0700 (PDT) Subject: Re: [PATCH] env: Fix avoid using a leftover text-environment file To: Marek Vasut , u-boot@lists.denx.de Cc: Simon Glass , Tom Rini References: <20220403231712.693390-1-marex@denx.de> From: Sean Anderson Message-ID: <3c0d3429-42c8-3c2c-78ea-1e1d1006432e@gmail.com> Date: Sun, 3 Apr 2022 19:57:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220403231712.693390-1-marex@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/3/22 7:17 PM, Marek Vasut wrote: > Clean build ends up generating the following error, add -f switch to rm > to mitigate it: > " > rm: cannot remove 'include/generated/env.in': No such file or directory > " > > Fixes: f432eb6d8a9 ("env: Avoid using a leftover text-environment file") > Cc: Sean Anderson > Cc: Simon Glass > Cc: Tom Rini > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 4672147318e..868445bf33c 100644 > --- a/Makefile > +++ b/Makefile > @@ -1846,7 +1846,7 @@ quiet_cmd_gen_envp = ENVP $@ > -I$(srctree)/arch/$(ARCH)/include \ > $< -o $@; \ > else \ > - rm $@; \ > + rm -f $@; \ > touch $@ ; \ > fi > include/generated/env.in: include/generated/env.txt FORCE > Duplicate of https://patchwork.ozlabs.org/project/uboot/patch/20220403140603.26029-1-andrey.zhizhikin@leica-geosystems.com/ Either one LGTM Reviewed-by: Sean Anderson Tom, this should probably go in the release. --Sean