Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A71D3C4345F for ; Thu, 11 Apr 2024 20:15:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.704207.1100449 (Exim 4.92) (envelope-from ) id 1rv0ou-0005IX-Ay; Thu, 11 Apr 2024 20:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 704207.1100449; Thu, 11 Apr 2024 20:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rv0ou-0005IQ-7s; Thu, 11 Apr 2024 20:14:52 +0000 Received: by outflank-mailman (input) for mailman id 704207; Thu, 11 Apr 2024 20:14:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rv0os-0005IK-Sk for xen-devel@lists.xenproject.org; Thu, 11 Apr 2024 20:14:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 247910b7-f840-11ee-94a3-07e782e9044d; Thu, 11 Apr 2024 22:14:47 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 882754EE0739; Thu, 11 Apr 2024 22:14:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 247910b7-f840-11ee-94a3-07e782e9044d MIME-Version: 1.0 Date: Thu, 11 Apr 2024 22:14:46 +0200 From: Nicola Vetrini To: Andrew Cooper Cc: Jan Beulich , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation In-Reply-To: References: <81ecc35d04456771b1e48cb25155b0151e2225b8.1712305581.git.nicola.vetrini@bugseng.com> <36e84201-b31f-4204-8cff-ed50a01a47ed@suse.com> Message-ID: <3c216cddfe9151ab27aadc3ece6b12dc@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024-04-11 14:03, Andrew Cooper wrote: > On 09/04/2024 8:45 pm, Nicola Vetrini wrote: >> On 2024-04-08 09:32, Jan Beulich wrote: >>> On 05.04.2024 11:14, Nicola Vetrini wrote: >>>> Remove unneded blank lines between switch clauses. >>> >>> "Unneeded" based on what? We're carefully trying to improve >>> readability of >>> large switch() statements by adding such blank lines (at least) >>> between non- >>> fall-through case blocks, and you go and remove them? >>> >>> Jan >> >> I wrote that based on this earlier suggestion [1]. If I misunderstood >> the suggestion, then I apologize and feel free to strip them if you >> want. >> >> [1] >> https://lore.kernel.org/xen-devel/e40579ba-acae-4c11-bea1-a5b83208db10@suse.com/ > > I'm afraid I also can't figure out what that suggestion was supposed to > be, but we definitely do want to keep blank lines.  They're > specifically > for improved legibility. > I interpreted that message as being a suggestion to eliminate blank lines, which was obviously incorrect. Anyways, thanks for the effort on adjusting and committing the earlier patches. > But fighting over spacing like this is a waste of everyone's time.  > I've > taken patches 1 thru 7, accounting for the suggestions made so far, and > adjusted to retain the blank lines. > > Please double check carefully. > > Patch 8 didn't apply because SAF-4-safe has been used for something > else > now.  You'll need to rebase and resubmit patches 8 and 9. > I'll certainly do so when I'm fully back to work next week. > ~Andrew -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)