Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76BBBC7619A for ; Wed, 12 Apr 2023 09:48:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 22C7985F93; Wed, 12 Apr 2023 11:48:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5E6BB85F7F; Wed, 12 Apr 2023 11:48:13 +0200 (CEST) Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by phobos.denx.de (Postfix) with ESMTP id 17E7E85F7F for ; Wed, 12 Apr 2023 11:48:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=minda.chen@starfivetech.com Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id DB62924E287; Wed, 12 Apr 2023 17:48:04 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 17:48:04 +0800 Received: from [192.168.125.108] (113.72.145.176) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 12 Apr 2023 17:48:03 +0800 Message-ID: <3c2723f1-b346-e437-0edc-140523d2c2bf@starfivetech.com> Date: Wed, 12 Apr 2023 17:48:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver Content-Language: en-US To: Bin Meng CC: Simon Glass , Stefan Roese , Andrew Scull , =?UTF-8?Q?Pali_Roh=c3=a1r?= , "Mark Kettenis" , , Rick Chen , Leo , Mason Huo , Yanhong Wang , Leyfoon Tan , Kevin Xie References: <20230411010209.76561-1-minda.chen@starfivetech.com> <20230411010209.76561-2-minda.chen@starfivetech.com> <6c72d7b7-df64-740d-6463-546670df5ae4@starfivetech.com> From: Minda Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [113.72.145.176] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/4/11 13:20, Bin Meng wrote: > On Tue, Apr 11, 2023 at 11:53=E2=80=AFAM Minda Chen wrote: >> >> >> >> On 2023/4/11 10:55, Bin Meng wrote: >> > On Tue, Apr 11, 2023 at 9:03=E2=80=AFAM Minda Chen wrote: >> >> >> >> From: Mason Huo >> >> >> >> Add pcie driver for StarFive JH7110, the driver depends on >> >> starfive gpio, pinctrl, clk and reset driver to do init. >> >> >> >> Several devices are tested: >> >> a) M.2 NVMe SSD >> >> b) Realtek 8169 Ethernet adapter. >> >> >> >> Signed-off-by: Mason Huo >> >> Signed-off-by: Minda Chen >> >> --- >> >> drivers/pci/Kconfig | 9 + >> >> drivers/pci/Makefile | 1 + >> >> drivers/pci/pcie_starfive_jh7110.c | 465 +++++++++++++++++++++++++= ++++ >> >> 3 files changed, 475 insertions(+) >> >> create mode 100644 drivers/pci/pcie_starfive_jh7110.c >> >> >> >> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig >> >> index ef328d2652..f37b6baa25 100644 >> >> --- a/drivers/pci/Kconfig >> >> +++ b/drivers/pci/Kconfig >> >> @@ -374,4 +374,13 @@ config PCIE_UNIPHIER >> >> Say Y here if you want to enable PCIe controller support = on >> >> UniPhier SoCs. >> >> >> >> +config PCIE_STARFIVE_JH7110 >> >> + bool "Enable Starfive JH7110 PCIe driver" >> >> + imply STARFIVE_JH7110 >> >> + imply CLK_JH7110 >> >> + imply RESET_JH7110 >> >> + help >> >> + Say Y here if you want to enable PCIe controller support = on >> >> + StarFive JH7110 SoC. >> >> + >> >> endif >> >> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile >> >> index 49506e7ba5..bbe3323bb5 100644 >> >> --- a/drivers/pci/Makefile >> >> +++ b/drivers/pci/Makefile >> >> @@ -49,3 +49,4 @@ obj-$(CONFIG_PCI_OCTEONTX) +=3D pci_octeontx.o >> >> obj-$(CONFIG_PCIE_OCTEON) +=3D pcie_octeon.o >> >> obj-$(CONFIG_PCIE_DW_SIFIVE) +=3D pcie_dw_sifive.o >> >> obj-$(CONFIG_PCIE_UNIPHIER) +=3D pcie_uniphier.o >> >> +obj-$(CONFIG_PCIE_STARFIVE_JH7110) +=3D pcie_starfive_jh7110.o >> >> diff --git a/drivers/pci/pcie_starfive_jh7110.c b/drivers/pci/pcie_= starfive_jh7110.c >> >> new file mode 100644 >> >> index 0000000000..130181013e >> >> --- /dev/null >> >> +++ b/drivers/pci/pcie_starfive_jh7110.c >> >> @@ -0,0 +1,465 @@ >> >> +// SPDX-License-Identifier: GPL-2.0+ >> >> +/* >> >> + * StarFive PLDA PCIe host controller driver >> >> + * >> >> + * Copyright (c) 2023 Starfive, Inc. >> >> + * Author: Mason Huo >> >> + * >> >> + */ >> >> + >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> + >> >> +DECLARE_GLOBAL_DATA_PTR; >> >> + >> >> +#define GEN_SETTINGS 0x80 >> >> +#define PCIE_PCI_IDS 0x9C >> >> +#define PCIE_WINROM 0xFC >> >> +#define PMSG_SUPPORT_RX 0x3F0 >> >> +#define PCI_MISC 0xB4 >> >> + >> >> +#define PLDA_EP_ENABLE 0 >> >> +#define PLDA_RP_ENABLE 1 >> >> + >> >> +#define IDS_CLASS_CODE_SHIFT 8 >> >> + >> >> +#define PREF_MEM_WIN_64_SUPPORT BIT(3) >> >> +#define PMSG_LTR_SUPPORT BIT(2) >> >> +#define PLDA_FUNCTION_DIS BIT(15) >> >> +#define PLDA_FUNC_NUM 4 >> >> +#define PLDA_PHY_FUNC_SHIFT 9 >> >> + >> >> +#define XR3PCI_ATR_AXI4_SLV0 0x800 >> >> +#define XR3PCI_ATR_SRC_ADDR_LOW 0x0 >> >> +#define XR3PCI_ATR_SRC_ADDR_HIGH 0x4 >> >> +#define XR3PCI_ATR_TRSL_ADDR_LOW 0x8 >> >> +#define XR3PCI_ATR_TRSL_ADDR_HIGH 0xc >> >> +#define XR3PCI_ATR_TRSL_PARAM 0x10 >> >> +#define XR3PCI_ATR_TABLE_OFFSET 0x20 >> >> +#define XR3PCI_ATR_MAX_TABLE_NUM 8 >> >> + >> >> +#define XR3PCI_ATR_SRC_WIN_SIZE_SHIFT 1 >> >> +#define XR3PCI_ATR_SRC_ADDR_MASK GENMASK(31, 12) >> >> +#define XR3PCI_ATR_TRSL_ADDR_MASK GENMASK(31, 12) >> >> +#define XR3_PCI_ECAM_SIZE 28 >> >> +#define XR3PCI_ATR_TRSL_DIR BIT(22) >> >> +/* IDs used in the XR3PCI_ATR_TRSL_PARAM */ >> >> +#define XR3PCI_ATR_TRSLID_PCIE_MEMORY 0x0 >> >> +#define XR3PCI_ATR_TRSLID_PCIE_CONFIG 0x1 >> >> + >> >> +/* system control */ >> >> +#define STG_SYSCON_K_RP_NEP_MASK BIT(8) >> >> +#define STG_SYSCON_AXI4_SLVL_ARFUNC_MASK GENMASK(22, 8) >> >> +#define STG_SYSCON_AXI4_SLVL_ARFUNC_SHIFT 8 >> >> +#define STG_SYSCON_AXI4_SLVL_AWFUNC_MASK GENMASK(14, 0) >> >> +#define STG_SYSCON_CLKREQ_MASK BIT(22) >> >> +#define STG_SYSCON_CKREF_SRC_SHIFT 18 >> >> +#define STG_SYSCON_CKREF_SRC_MASK GENMASK(19, 18) >> >> + >> >> +struct starfive_pcie { >> >> + struct udevice *dev; >> >> + >> >> + void __iomem *reg_base; >> >> + void __iomem *cfg_base; >> >> + >> >> + struct regmap *regmap; >> >> + u32 stg_arfun; >> >> + u32 stg_awfun; >> >> + u32 stg_rp_nep; >> >> + >> >> + struct clk_bulk clks; >> >> + struct reset_ctl_bulk rsts; >> >> + struct gpio_desc reset_gpio; >> >> + >> >> + int atr_table_num; >> >> + int sec_busno; >> >> +}; >> >> + >> >> +static bool starfive_pcie_addr_valid(pci_dev_t bdf, struct starfiv= e_pcie *priv) >> >> +{ >> >> + /* >> >> + * Single device limitation. >> >> + * For JH7110 SoC limitation, one bus can only connnect one= device. >> >> + * And PCIe controller contain HW issue that secondary bus = of >> >> + * host bridge emumerate duplicate devices. >> >> + * Only can access device 0 in secondary bus. >> >> + */ >> >> + if (PCI_BUS(bdf) =3D=3D priv->sec_busno && PCI_DEV(bdf) > 0= ) >> >> + return false; >> >> + >> >> + return true; >> >> +} >> >> + >> >> +static int starfive_pcie_conf_address(const struct udevice *udev, = pci_dev_t bdf, >> >> + uint offset, void **paddr) >> >> +{ >> >> + struct starfive_pcie *priv =3D dev_get_priv(udev); >> >> + int where =3D PCIE_ECAM_OFFSET(PCI_BUS(bdf), PCI_DEV(bdf), >> >> + PCI_FUNC(bdf), offset); >> >> + >> >> + if (!starfive_pcie_addr_valid(bdf, priv)) >> >> + return -ENODEV; >> >> + >> >> + *paddr =3D (void *)(priv->cfg_base + where); >> >> + return 0; >> >> +} >> >> + >> >> +static int starfive_pcie_config_read(const struct udevice *udev, p= ci_dev_t bdf, >> >> + uint offset, ulong *valuep, >> >> + enum pci_size_t size) >> >> +{ >> >> + return pci_generic_mmap_read_config(udev, starfive_pcie_con= f_address, >> >> + bdf, offset, valuep, si= ze); >> >> +} >> >> + >> >> +int starfive_pcie_config_write(struct udevice *udev, pci_dev_t bdf= , >> >> + uint offset, ulong value, >> >> + enum pci_size_t size) >> >> +{ >> >> + struct starfive_pcie *priv =3D dev_get_priv(udev); >> >> + int ret; >> >> + >> >> + ret =3D pci_generic_mmap_write_config(udev, starfive_pcie_c= onf_address, >> >> + bdf, offset, value, siz= e); >> >> + >> >> + if (!ret && offset =3D=3D PCI_SECONDARY_BUS) { >> >> + priv->sec_busno =3D value & 0xff; >> >> + debug("Secondary bus number was changed to %d\n", >> >> + priv->sec_busno); >> >> + } >> >> + return ret; >> >> +} >> >> + >> >> +static int starfive_pcie_set_atr_entry(struct starfive_pcie *priv,= phys_addr_t src_addr, >> >> + phys_addr_t trsl_addr, size_= t window_size, >> >> + int trsl_param) >> >> +{ >> >> + void __iomem *base =3D >> >> + priv->reg_base + XR3PCI_ATR_AXI4_SLV0; >> >> + >> >> + /* Support AXI4 Slave 0 Address Translation Tables 0-7. */ >> >> + if (priv->atr_table_num >=3D XR3PCI_ATR_MAX_TABLE_NUM) { >> >> + dev_err(priv->dev, "ATR table number %d exceeds max= num\n", >> >> + priv->atr_table_num); >> >> + return -EINVAL; >> >> + } >> >> + base +=3D XR3PCI_ATR_TABLE_OFFSET * priv->atr_table_num; >> >> + priv->atr_table_num++; >> >> + >> >> + /* >> >> + * X3PCI_ATR_SRC_ADDR_LOW: >> >> + * - bit 0: enable entry, >> >> + * - bits 1-6: ATR window size: total size in bytes: 2^(A= TR_WSIZE + 1) >> >> + * - bits 7-11: reserved >> >> + * - bits 12-31: start of source address >> >> + */ >> >> + writel((lower_32_bits(src_addr) & XR3PCI_ATR_SRC_ADDR_MASK)= | >> >> + (fls(window_size) - 1) << XR3PCI_ATR_SRC_WI= N_SIZE_SHIFT | 1, >> >> + base + XR3PCI_ATR_SRC_ADDR_LOW); >> >> + writel(upper_32_bits(src_addr), base + XR3PCI_ATR_SRC_ADDR_= HIGH); >> >> + writel((lower_32_bits(trsl_addr) & XR3PCI_ATR_TRSL_ADDR_MAS= K), >> >> + base + XR3PCI_ATR_TRSL_ADDR_LOW); >> >> + writel(upper_32_bits(trsl_addr), base + XR3PCI_ATR_TRSL_ADD= R_HIGH); >> >> + writel(trsl_param, base + XR3PCI_ATR_TRSL_PARAM); >> >> + >> >> + dev_dbg(priv->dev, "ATR entry: 0x%010llx %s 0x%010llx [0x%0= 10llx] (param: 0x%06x)\n", >> >> + src_addr, (trsl_param & XR3PCI_ATR_TRSL_DIR) ? "<-"= : "->", >> >> + trsl_addr, (u64)window_size, trsl_param); >> >> + return 0; >> >> +} >> >> + >> >> +static int starfive_pcie_atr_init(struct starfive_pcie *priv) >> >> +{ >> >> + struct udevice *ctlr =3D pci_get_controller(priv->dev); >> >> + struct pci_controller *hose =3D dev_get_uclass_priv(ctlr); >> >> + int i, ret; >> >> + >> >> + /* >> >> + * As the two host bridges in JH7110 soc have the same defa= ult >> >> + * address translation table, this cause the second root po= rt can't >> >> + * access it's host bridge config space correctly. >> >> + * To workaround, config the ATR of host bridge config spac= e by SW. >> >> + */ >> >> + >> >> + ret =3D starfive_pcie_set_atr_entry(priv, >> >> + (phys_addr_t)priv->cfg_ba= se, >> >> + 0, >> >> + 1 << XR3_PCI_ECAM_SIZE, >> >> + XR3PCI_ATR_TRSLID_PCIE_CO= NFIG); >> >> + if (ret) >> >> + return ret; >> >> + >> >> + for (i =3D 0; i < hose->region_count; i++) { >> >> + if (hose->regions[i].flags =3D=3D PCI_REGION_SYS_ME= MORY) >> >> + continue; >> >> + >> >> + /* Only support identity mappings. */ >> >> + if (hose->regions[i].bus_start !=3D >> >> + hose->regions[i].phys_start) >> >> + return -EINVAL; >> >> + >> >> + ret =3D starfive_pcie_set_atr_entry(priv, >> >> + hose->regions[i].= phys_start, >> >> + hose->regions[i].= bus_start, >> >> + hose->regions[i].= size, >> >> + XR3PCI_ATR_TRSLID= _PCIE_MEMORY); >> >> + if (ret) >> >> + return ret; >> >> + } >> >> + >> >> + return 0; >> >> +} >> >> + >> >> +static int starfive_pcie_get_syscon(struct udevice *dev) >> >> +{ >> >> + struct starfive_pcie *priv =3D dev_get_priv(dev); >> >> + struct udevice *syscon; >> >> + struct ofnode_phandle_args syscfg_phandle; >> >> + u32 cells[4]; >> >> + int ret; >> >> + >> >> + /* get corresponding syscon phandle */ >> >> + ret =3D dev_read_phandle_with_args(dev, "starfive,stg-sysco= n", NULL, 0, 0, >> >> + &syscfg_phandle); >> >> + >> >> + if (ret < 0) { >> >> + dev_err(dev, "Can't get syscfg phandle: %d\n", ret)= ; >> >> + return ret; >> >> + } >> >> + >> >> + ret =3D uclass_get_device_by_ofnode(UCLASS_SYSCON, syscfg_p= handle.node, >> >> + &syscon); >> >> + if (ret) { >> >> + dev_err(dev, "Unable to find syscon device (%d)\n",= ret); >> >> + return ret; >> >> + } >> >> + >> >> + priv->regmap =3D syscon_get_regmap(syscon); >> >> + if (!priv->regmap) { >> >> + dev_err(dev, "Unable to find regmap\n"); >> >> + return -ENODEV; >> >> + } >> >> + >> >> + /* get syscon register offset */ >> >> + ret =3D dev_read_u32_array(dev, "starfive,stg-syscon", >> >> + cells, ARRAY_SIZE(cells)); >> >> + if (ret) { >> >> + dev_err(dev, "Get syscon register err %d\n", ret); >> >> + return -EINVAL; >> >> + } >> >> + >> >> + dev_dbg(dev, "Get syscon values: %x, %x, %x\n", >> >> + cells[1], cells[2], cells[3]); >> >> + priv->stg_arfun =3D cells[1]; >> >> + priv->stg_awfun =3D cells[2]; >> >> + priv->stg_rp_nep =3D cells[3]; >> >> + >> >> + return 0; >> >> +} >> >> + >> >> +static int starfive_pcie_parse_dt(struct udevice *dev) >> >> +{ >> >> + struct starfive_pcie *priv =3D dev_get_priv(dev); >> >> + int ret; >> >> + >> >> + priv->reg_base =3D (void *)dev_read_addr_name(dev, "reg"); >> >> + if (priv->reg_base =3D=3D (void __iomem *)FDT_ADDR_T_NONE) = { >> >> + dev_err(dev, "Missing required reg address range\n"= ); >> >> + return -EINVAL; >> >> + } >> >> + >> >> + priv->cfg_base =3D (void *)dev_read_addr_name(dev, "config"= ); >> >> + if (priv->cfg_base =3D=3D (void __iomem *)FDT_ADDR_T_NONE) = { >> >> + dev_err(dev, "Missing required config address range= "); >> >> + return -EINVAL; >> >> + } >> >> + >> >> + ret =3D starfive_pcie_get_syscon(dev); >> >> + if (ret) { >> >> + dev_err(dev, "Can't get syscon: %d\n", ret); >> >> + return ret; >> >> + } >> >> + >> >> + ret =3D reset_get_bulk(dev, &priv->rsts); >> >> + if (ret) { >> >> + dev_err(dev, "Can't get reset: %d\n", ret); >> >> + return ret; >> >> + } >> >> + >> >> + ret =3D clk_get_bulk(dev, &priv->clks); >> >> + if (ret) { >> >> + dev_err(dev, "Can't get clock: %d\n", ret); >> >> + return ret; >> >> + } >> >> + >> >> + ret =3D gpio_request_by_name(dev, "reset-gpios", 0, &priv->= reset_gpio, >> >> + GPIOD_IS_OUT); >> >> + if (ret) { >> >> + dev_err(dev, "Can't get reset-gpio: %d\n", ret); >> >> + return ret; >> >> + } >> >> + >> >> + if (!dm_gpio_is_valid(&priv->reset_gpio)) { >> >> + dev_err(dev, "reset-gpio is not valid\n"); >> >> + return -EINVAL; >> >> + } >> >> + return 0; >> >> +} >> >> + >> >> +static int starfive_pcie_init_port(struct udevice *dev) >> >> +{ >> >> + int ret, i; >> >> + unsigned int value; >> >> + struct starfive_pcie *priv =3D dev_get_priv(dev); >> >> + >> >> + ret =3D clk_enable_bulk(&priv->clks); >> >> + if (ret) { >> >> + dev_err(dev, "Failed to enable clks (ret=3D%d)\n", = ret); >> >> + return ret; >> >> + } >> >> + >> >> + ret =3D reset_deassert_bulk(&priv->rsts); >> >> + if (ret) { >> >> + dev_err(dev, "Failed to deassert resets (ret=3D%d)\= n", ret); >> >> + goto err_deassert_clk; >> >> + } >> >> + >> >> + dm_gpio_set_value(&priv->reset_gpio, 1); >> >> + /* Disable physical functions except #0 */ >> >> + for (i =3D 1; i < PLDA_FUNC_NUM; i++) { >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_arfun, >> >> + STG_SYSCON_AXI4_SLVL_ARFUNC_MASK= , >> >> + (i << PLDA_PHY_FUNC_SHIFT) << >> >> + STG_SYSCON_AXI4_SLVL_ARFUNC_SHIF= T); >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_awfun, >> >> + STG_SYSCON_AXI4_SLVL_AWFUNC_MASK= , >> >> + i << PLDA_PHY_FUNC_SHIFT); >> >> + >> >> + value =3D readl(priv->reg_base + PCI_MISC); >> >> + value |=3D PLDA_FUNCTION_DIS; >> >> + writel(value, priv->reg_base + PCI_MISC); >> >> + } >> >> + >> >> + /* Disable physical functions */ >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_arfun, >> >> + STG_SYSCON_AXI4_SLVL_ARFUNC_MASK, >> >> + 0); >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_awfun, >> >> + STG_SYSCON_AXI4_SLVL_AWFUNC_MASK, >> >> + 0); >> >> + >> >> + /* Enable root port */ >> >> + value =3D readl(priv->reg_base + GEN_SETTINGS); >> >> + value |=3D PLDA_RP_ENABLE; >> >> + writel(value, priv->reg_base + GEN_SETTINGS); >> >> + >> >> + /* PCIe PCI Standard Configuration Identification Settings.= */ >> >> + value =3D readl(priv->reg_base + PCIE_PCI_IDS); >> >> + value &=3D 0xff; >> >> + value |=3D (PCI_CLASS_BRIDGE_PCI_NORMAL << IDS_CLASS_CODE_S= HIFT); >> >> + writel(value, priv->reg_base + PCIE_PCI_IDS); >> >> + >> >> + /* >> >> + * The LTR message forwarding of PCIe Message Reception was= set by core >> >> + * as default, but the forward id & addr are also need to b= e reset. >> >> + * If we do not disable LTR message forwarding here, or set= a legal >> >> + * forwarding address, the kernel will get stuck after this= driver probe. >> >> + * To workaround, disable the LTR message forwarding suppor= t on >> >> + * PCIe Message Reception. >> >> + */ >> >> + value =3D readl(priv->reg_base + PMSG_SUPPORT_RX); >> >> + value &=3D ~PMSG_LTR_SUPPORT; >> >> + writel(value, priv->reg_base + PMSG_SUPPORT_RX); >> >> + >> >> + /* Prefetchable memory window 64-bit addressing support */ >> >> + value =3D readl(priv->reg_base + PCIE_WINROM); >> >> + value |=3D PREF_MEM_WIN_64_SUPPORT; >> >> + writel(value, priv->reg_base + PCIE_WINROM); >> >> + >> >> + starfive_pcie_atr_init(priv); >> >> + >> >> + dm_gpio_set_value(&priv->reset_gpio, 0); >> >> + /* Ensure that PERST in default at least 300 ms */ >> >> + mdelay(300); >> >> + >> >> + return 0; >> >> + >> >> +err_deassert_clk: >> >> + clk_disable_bulk(&priv->clks); >> >> + return ret; >> >> +} >> >> + >> >> +static int starfive_pcie_probe(struct udevice *dev) >> >> +{ >> >> + struct starfive_pcie *priv =3D dev_get_priv(dev); >> >> + int ret; >> >> + >> >> + priv->atr_table_num =3D 0; >> >> + priv->dev =3D dev; >> >> + >> >> + ret =3D starfive_pcie_parse_dt(dev); >> >> + if (ret) >> >> + return ret; >> >> + >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_rp_nep, >> >> + STG_SYSCON_K_RP_NEP_MASK, >> >> + STG_SYSCON_K_RP_NEP_MASK); >> >> + >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_awfun, >> >> + STG_SYSCON_CKREF_SRC_MASK, >> >> + 2 << STG_SYSCON_CKREF_SRC_SHIFT); >> >> + >> >> + regmap_update_bits(priv->regmap, >> >> + priv->stg_awfun, >> >> + STG_SYSCON_CLKREQ_MASK, >> >> + STG_SYSCON_CLKREQ_MASK); >> >> + >> >> + ret =3D starfive_pcie_init_port(dev); >> >> + if (ret) >> >> + return ret; >> >> + >> >> + dev_err(dev, "Starfive PCIe bus probed.\n"); >> >> + >> >> + return 0; >> >> +} >> >> + >> >> +static const struct dm_pci_ops starfive_pcie_ops =3D { >> >> + .read_config =3D starfive_pcie_config_read, >> >> + .write_config =3D starfive_pcie_config_write, >> >> +}; >> >> + >> >> +static const struct udevice_id starfive_pcie_ids[] =3D { >> >> + { .compatible =3D "starfive,jh7110-pcie" }, >> > >> > My previous comments were not addressed. >> > >> I am sorry. I overlooked your previous comments. >> > Is this PCIe controller a StarFive IP? Or some 3rd party licensed IP= ? >> > Is this compatible string approved by the DT community? >> > The PCIe controller is 3rd party (PLDA) licensed IP. >> Both kernel and u-boot can not find PLDA IP compatible string. >> So this compatible string is not approved. >> I can split PCIe controller ops code to new pcie-plda-common.c like de= signeware codes. >=20 > Yes, please do. This will allow future SoCs that use the same PLDA > PCIe IP to reuse most of the codes. >=20 > In the meantime, I suggest you send patch to the Linux kernel for > adding the compatible string of the PLDA PCIe controller. >=20 I am preparing JH7110 PCIe Linux kernel driver upstream.=20 At the same time, both PLDA PCIe controller compatible string and "starfive,jh7110-pcie" will be added to Linux dt-binding documents. > Is the datasheet public avaiable? >=20 I am sorry. the datasheet is not public available. > Regards, > Bin