From: Sagar Arun Kamble Subject: Re: [PATCH v3 07/14] drm/i915/guc: Move firmware size check out of generic code Date: Fri, 13 Oct 2017 12:19:22 +0530 Message-ID: <3c66fa7f-9308-7672-df3c-ba263a5c1507@intel.com> References: <20171012225447.256-1-michal.wajdeczko@intel.com> <20171012225447.256-8-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A51A6EA24 for ; Fri, 13 Oct 2017 06:49:28 +0000 (UTC) In-Reply-To: <20171012225447.256-8-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMC8xMy8yMDE3IDQ6MjQgQU0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gQ2hlY2tp bmcgR3VDIGZpcm13YXJlIHNpemUgY2FuIGJlIGRvbmUgaW4gR3VDIHNwZWNpZmljIGNvZGUKPiBy aWdodCBiZWZvcmUgRE1BIGNvcHkgYXMgaXQgaXMgdW5saWtlbHkgdG8gZmFpbCBhbnl3YXkuCj4K PiB2MjogcmViYXNlZAo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGFsIFdhamRlY3prbyA8bWljaGFs LndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmth bWJsZUBpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxp bnV4LmludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEu a2FtYmxlQGludGVsLmNvbT4gIzEKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Y19mdy5jIHwgNyArKysrKystCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19m dy5jICB8IDggLS0tLS0tLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Y19mdy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2Z3LmMKPiBpbmRleCA3 MWRhY2MzLi4wMjBjZTI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2d1Y19mdy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2Z3LmMKPiBA QCAtMTMzLDYgKzEzMyw3IEBAIHN0YXRpYyBpbnQgZ3VjX3Vjb2RlX3hmZXJfZG1hKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAl1bnNpZ25lZCBsb25nIG9mZnNldDsKPiAg IAlzdHJ1Y3Qgc2dfdGFibGUgKnNnID0gdm1hLT5wYWdlczsKPiAgIAl1MzIgc3RhdHVzLCByc2Fb VU9TX1JTQV9TQ1JBVENIX01BWF9DT1VOVF07Cj4gKwl1MzIgc2l6ZSA9IGd1Y19mdy0+aGVhZGVy X3NpemUgKyBndWNfZnctPnVjb2RlX3NpemU7Cj4gICAJaW50IGksIHJldCA9IDA7Cj4gICAKPiAg IAkvKiB3aGVyZSBSU0Egc2lnbmF0dXJlIHN0YXJ0cyAqLwo+IEBAIC0xNDUsNyArMTQ2LDExIEBA IHN0YXRpYyBpbnQgZ3VjX3Vjb2RlX3hmZXJfZG1hKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPiAgIAo+ICAgCS8qIFRoZSBoZWFkZXIgcGx1cyB1Q29kZSB3aWxsIGJlIGNvcGll ZCB0byBXT1BDTSB2aWEgRE1BLCBleGNsdWRpbmcgYW55Cj4gICAJICogb3RoZXIgY29tcG9uZW50 cyAqLwo+IC0JSTkxNV9XUklURShETUFfQ09QWV9TSVpFLCBndWNfZnctPmhlYWRlcl9zaXplICsg Z3VjX2Z3LT51Y29kZV9zaXplKTsKPiArCWlmIChzaXplID4gaW50ZWxfZ3VjX3dvcGNtX3NpemUo ZGV2X3ByaXYpKSB7ClRoaXMgc2l6ZSBjaGVjayBiZXR0ZXIgYmUgZG9uZSBiZWZvcmUgUlNBIGNv cHkuIFdpdGggdGhhdDoKUmV2aWV3ZWQtYnk6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmth bWJsZUBpbnRlbC5jb20+Cj4gKwkJRFJNX0VSUk9SKCJGaXJtd2FyZSBpcyB0b28gbGFyZ2UgdG8g Zml0IGluIFdPUENNXG4iKTsKPiArCQlyZXR1cm4gLUVGQklHOwo+ICsJfQo+ICsJSTkxNV9XUklU RShETUFfQ09QWV9TSVpFLCBzaXplKTsKPiAgIAo+ICAgCS8qIFNldCB0aGUgc291cmNlIGFkZHJl c3MgZm9yIHRoZSBuZXcgYmxvYiAqLwo+ICAgCW9mZnNldCA9IGd1Y19nZ3R0X29mZnNldCh2bWEp ICsgZ3VjX2Z3LT5oZWFkZXJfb2Zmc2V0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91Y19mdy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYwo+ IGluZGV4IDc2NmIxY2IuLjQ4MjExNWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdWNfZncuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3 LmMKPiBAQCAtMTA4LDE0ICsxMDgsNiBAQCB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkgKi8KPiAgIAlzd2l0Y2ggKHVjX2Z3LT50 eXBlKSB7Cj4gICAJY2FzZSBJTlRFTF9VQ19GV19UWVBFX0dVQzoKPiAtCQkvKiBIZWFkZXIgYW5k IHVDb2RlIHdpbGwgYmUgbG9hZGVkIHRvIFdPUENNLiBTaXplIG9mIHRoZSB0d28uICovCj4gLQkJ c2l6ZSA9IHVjX2Z3LT5oZWFkZXJfc2l6ZSArIHVjX2Z3LT51Y29kZV9zaXplOwo+IC0KPiAtCQkv KiBUb3AgMzJrIG9mIFdPUENNIGlzIHJlc2VydmVkICg4SyBzdGFjayArIDI0ayBSQzYgY29udGV4 dCkuICovCj4gLQkJaWYgKHNpemUgPiBpbnRlbF9ndWNfd29wY21fc2l6ZShkZXZfcHJpdikpIHsK PiAtCQkJRFJNX0VSUk9SKCJGaXJtd2FyZSBpcyB0b28gbGFyZ2UgdG8gZml0IGluIFdPUENNXG4i KTsKPiAtCQkJZ290byBmYWlsOwo+IC0JCX0KPiAgIAkJdWNfZnctPm1ham9yX3Zlcl9mb3VuZCA9 IGNzcy0+Z3VjLnN3X3ZlcnNpb24gPj4gMTY7Cj4gICAJCXVjX2Z3LT5taW5vcl92ZXJfZm91bmQg PSBjc3MtPmd1Yy5zd192ZXJzaW9uICYgMHhGRkZGOwo+ICAgCQlicmVhazsKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=