From: "flichtenheld (Code Review)" Date: Fri, 27 Jun 2025 09:39:25 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <3c737b4e5c87902e6f824861e958eefab562ec79-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="3Pwfx4YbtZ8="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Remove uncrustify config and reformat-all.sh, switch GHA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --3Pwfx4YbtZ8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/830?usp=3Demail to look at the new patch set (#11). Change subject: Remove uncrustify config and reformat-all.sh, switch GHA ...................................................................... Remove uncrustify config and reformat-all.sh, switch GHA Replaced with clang-format and pre-commit. Add a README file that explains how to use pre-commit and how to combine this with the old hook. Old hook does not get removed and will be updated to be compatible with manually installed clang-format in a separate commit. Change-Id: I15d4946800cbfaead67a73450ff3b12193814e54 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml D dev-tools/reformat-all.sh D dev-tools/special-files.lst D dev-tools/uncrustify.conf 4 files changed, 12 insertions(+), 241 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/830/11 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index d4fdc9d..37c09fe 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -5,35 +5,26 @@ pull_request: jobs: - checkuncrustify: - name: "Check code style with Uncrustify" - # Ubuntu 22.04 has uncrustify 0.72_f - runs-on: ubuntu-22.04 + clang-format: + name: Check code style with clang-format + runs-on: ubuntu-24.04 steps: - name: Install dependencies - run: sudo apt update && sudo apt install -y uncrustify + run: | + sudo apt update && sudo apt install -y python3-pip + pip3 install pre-commit - name: Checkout OpenVPN uses: actions/checkout@...2844... # v4.2.2 - with: - path: openvpn - - name: Show uncrustify version - run: uncrustify --version - - name: Run uncrustify - run: ./dev-tools/reformat-all.sh - working-directory: openvpn + - name: Run clang-format + run: pre-commit run -a --show-diff-on-failure || true - name: Check for changes - run: git diff --output=3Duncrustify-changes.patch - working-directory: openvpn - - name: Show changes on standard output - run: git diff - working-directory: openvpn + run: git diff --output=3Dformat-changes.patch - uses: actions/upload-artifact@...2868... # v4.6.2 with: - name: uncrustify-changes.patch - path: 'openvpn/uncrustify-changes.patch' + name: format-changes.patch + path: format-changes.patch - name: Set job status - run: test ! -s uncrustify-changes.patch - working-directory: openvpn + run: test ! -s format-changes.patch android: strategy: diff --git a/dev-tools/reformat-all.sh b/dev-tools/reformat-all.sh deleted file mode 100755 index 02421c1..0000000 --- a/dev-tools/reformat-all.sh +++ /dev/null @@ -1,136 +0,0 @@ -#!/bin/sh -# reformat-all.sh - Reformat all git files in the checked out -# git branch using uncrustify. -# -# Copyright (C) 2016-2025 - David Sommerseth -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-130= 1, USA. -# - -tstamp=3D"$(date +%Y%m%d-%H%M%S)" -files=3D"$(pwd)/reformat-all_files-$tstamp.lst" -log=3D"$(pwd)/reformat-all_log-$tstamp.txt" - -srcroot=3D"$(git rev-parse --show-toplevel)" -cfg=3D"$srcroot/dev-tools/uncrustify.conf" -specialfiles=3D"$srcroot/dev-tools/special-files.lst" - -export gitfiles=3D0 -export procfiles=3D0 - -# Go to the root of the source tree -cd "$srcroot" - -{ - echo -n "** Starting $0: " - date - - # Find all C source/header files - git ls-files | grep -E ".*\.[ch](\.in$|$)" > "${files}.git" - - # Manage files which needs special treatment - awk -F\# '{gsub("\n| ", "", $1); print $1}' "$specialfiles" > "${files= }.sp" - while read srcfile - do - res=3D$(grep "$srcfile" "${files}.sp" 2>/dev/null) - if [ $? -ne 0 ]; then - # If grep didn't find the file among special files, - # process it normally - echo "$srcfile" >> "$files" - else - mode=3D$(echo "$res" | cut -d: -f1) - case "$mode" in - E) - echo "** INFO ** Excluding '$srcfile'" - ;; - P) - echo "** INFO ** Pre-patching '$srcfile'" - patchfile=3D"${srcroot}"/dev-tools/reformat-patches/be= fore_$(echo "$srcfile" | tr "/" "_").patch - if [ -r "$patchfile" ]; then - git apply "$patchfile" - if [ $? -ne 0 ]; then - echo "** ERROR ** Failed to apply pre-patch f= ile: $patchfile" - exit 2 - fi - else - echo "** WARN ** Pre-patch file for $srcfile is mi= ssing: $patchfile" - fi - echo "$srcfile" >> "${files}.postpatch" - echo "$srcfile" >> "$files" - ;; - *) - echo "** WARN ** Unknown mode '$mode' for file '$srcfi= le'" - ;; - esac - fi - done < "${files}.git" - rm -f "${files}.git" "${files}.sp" - - # Kick off uncrustify - echo - echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -F $file= s" - uncrustify -c "$cfg" --no-backup -l C -F "$files" 2>&1 - res=3D$? - echo "** INFO ** Uncrustify completed (exit code $res)" -} | tee "${log}-1" # Log needs to be closed here, to be processed in next= block - -{ - # Check the results - gitfiles=3D$(wc -l "$files" | cut -d\ -f1) - procfiles=3D$(grep "Parsing: " "${log}-1" | wc -l) - echo - echo "C source/header files checked into git: $gitfiles" - echo "Files processed by uncrustify: $procfiles" - echo - - # Post-Patch files modified after we uncrustify have adjusted them - if [ -r "${files}.postpatch" ]; then - while read srcfile; - do - patchfile=3D"${srcroot}"/dev-tools/reformat-patches/after_$(ec= ho "$srcfile" | tr "/" "_").patch - if [ -r "$patchfile" ]; then - echo "** INFO ** Post-patching '$srcfile'" - git apply "$patchfile" - if [ $? -ne 0 ]; then - echo "** WARN ** Failed to apply $patchfile" - fi - else - echo "** WARN ** Post-patch file for $srcfile is missing: = $patchfile" - fi - done < "${files}.postpatch" - rm -f "${files}.postpatch" - fi -} | tee "${log}-2" # Log needs to be closed here, to be processed in next = block - -cat "${log}-1" "${log}-2" > "$log" - -{ - ec=3D1 - echo - if [ "$gitfiles" -eq "$procfiles" ]; then - echo "Reformatting completed successfully" - ec=3D0 - else - last=3D$(tail -n1 "${log}-1") - echo "** ERROR ** Reformating failed to process all files." - echo " uncrustify exit code: $res" - echo " Last log line: $last" - echo - fi - rm -f "${log}-1" "${log}-2" -} | tee -a "$log" -rm -f "${files}" - -exit $ec diff --git a/dev-tools/special-files.lst b/dev-tools/special-files.lst deleted file mode 100644 index e5f2fc2..0000000 --- a/dev-tools/special-files.lst +++ /dev/null @@ -1,5 +0,0 @@ -E:doc/doxygen/doc_key_generation.h # @verbatim section gets mistreated= , exclude it -E:src/compat/compat-lz4.c # Preserve LZ4 upstream formatting -E:src/compat/compat-lz4.h # Preserve LZ4 upstream formatting -E:src/openvpn/ovpn_dco_linux.h # Preserve ovpn-dco upstream format= ting -E:src/openvpn/ovpn_dco_win.h # Preserve ovpn-dco-win upstream fo= rmatting diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf deleted file mode 100644 index 325f310..0000000 --- a/dev-tools/uncrustify.conf +++ /dev/null @@ -1,79 +0,0 @@ -# Use Allman-style -indent_columns=3D4 -indent_braces=3Dfalse -indent_else_if=3Dfalse -indent_switch_case=3D4 -indent_label=3D1 -nl_if_brace=3Dadd -nl_brace_else=3Dadd -nl_elseif_brace=3Dadd -nl_else_brace=3Dadd -nl_else_if=3Dremove -nl_for_brace=3Dadd -nl_while_brace=3Dadd -nl_switch_brace=3Dadd -nl_fdef_brace=3Dadd -nl_do_brace=3Dadd -sp_func_proto_paren=3DRemove -sp_func_def_paren=3DRemove -sp_func_call_paren=3DRemove -sp_sizeof_paren=3DRemove - -# No tabs, spaces only -indent_with_tabs=3D0 -align_with_tabs=3Dfalse -cmt_convert_tab_to_spaces=3Dtrue - -# Do not put spaces between the # and preprocessor statements -pp_space=3Dremove - -# Various whitespace fiddling -sp_assign=3Dadd -sp_before_sparen=3Dadd -sp_inside_sparen=3Dremove -sp_cond_colon=3Dadd -sp_cond_question=3Dadd -sp_bool=3Dadd -sp_else_brace=3Dadd -sp_brace_else=3Dadd -sp_after_comma=3Dadd -pos_arith=3DLead -pos_bool=3DLead -nl_func_type_name=3Dadd -nl_before_case=3Dtrue -nl_assign_leave_one_liners=3Dtrue -nl_enum_leave_one_liners=3Dtrue -nl_brace_fparen=3Dadd -nl_max=3D4 -nl_after_func_proto=3D2 -nl_end_of_file_min=3D1 -nl_end_of_file=3Dforce - -# Always use scoping braces for conditionals -mod_full_brace_if=3Dadd -mod_full_brace_if_chain=3Dfalse -mod_full_brace_while=3Dadd -mod_full_brace_for=3Dadd -mod_full_brace_do=3Dadd - -# Annotate #else and #endif statements -mod_add_long_ifdef_endif_comment=3D20 -mod_add_long_ifdef_else_comment=3D5 - -# Misc cleanup -mod_remove_extra_semicolon=3Dtrue - -# leave blank at end of empty for() statements -sp_after_semi_for_empty=3DAdd - -# Use C-style comments (/* .. */) -cmt_c_nl_end=3Dtrue -cmt_star_cont=3Dtrue -cmt_cpp_to_c=3Dtrue - -# Use "char **a"-style pointer stars/dereferences -sp_before_ptr_star=3DAdd -sp_between_ptr_star=3DRemove -sp_after_ptr_star=3DRemove -sp_before_byref=3DAdd -sp_after_byref=3DRemove -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/830?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I15d4946800cbfaead67a73450ff3b12193814e54 Gerrit-Change-Number: 830 Gerrit-PatchSet: 11 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset --3Pwfx4YbtZ8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

flichtenheld uploaded patch set #11 to this change.

=

View C= hange

Remove uncrustify config and reformat-all.sh, switch GHA

R= eplaced with clang-format and pre-commit.

Add a README file that exp= lains how to use pre-commit
and how to combine this with the old hook.
Old hook does not get removed and will be updated
to be compatible= with manually installed clang-format
in a separate commit.

Chang= e-Id: I15d4946800cbfaead67a73450ff3b12193814e54
Signed-off-by: Frank Lic= htenheld <frank@...2641...>
---
M .github/workflows/build.yaml<= br>D dev-tools/reformat-all.sh
D dev-tools/special-files.lst
D dev-to= ols/uncrustify.conf
4 files changed, 12 insertions(+), 241 deletions(-)<= br>
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/8=
30/11
diff --git a/.github/workflows/build.yaml b/.github/workflows=
/build.yaml
index d4fdc9d..37c09fe 100644
-= -- a/.github/workflows/build.yaml
+++ b/.github/workflows/b= uild.yaml
@@ -5,35 +5,26 @@
pull_request= :

jobs:
- checkuncrustify:
- name: "Check code style with Uncrustify"
- # Ubuntu 22.04 has u= ncrustify 0.72_f
- r= uns-on: ubuntu-22.04
= + clang-format:
+ = name: Check code style with clang-format
+ runs-on: ubuntu-24.04
steps:=
- name: Install dependencies
- run: sudo apt update && sud= o apt install -y uncrustify
+ run: |
+ pip3 install = pre-commit
- name: Checkout OpenVPN
= uses: actions/checkout@...2844... # v4.2.2
- with:
- path: openvpn
- - name: Show uncrustify version
<= span style=3D"color: hsl(0, 100%, 40%);">- run: uncrustify --version=

- - name: Run unc= rustify
- run: .= /dev-tools/reformat-all.sh
- working-directory: openvpn
+ - name: Run clang-format
+ run: pre-commit run -a --show-diff-o= n-failure || true
- name: Check for changes- run: git diff --output= =3Duncrustify-changes.patch
- working-directory: openvpn
- - name: Show changes on standard output
= - run: git diff
= - working-directory: openv= pn
+ run: git = diff --output=3Dformat-changes.patch
- uses: actions= /upload-artifact@...2868... # v4.6.2
with:<= br>- name: uncrustify-ch= anges.patch
- = path: 'openvpn/uncrustify-changes.patch'
+ name: format-changes.patch+ path: format-change= s.patch
- name: Set job status
- run: test ! -s uncrustify-changes.p= atch
- working-d= irectory: openvpn
+ = run: test ! -s format-changes.patch

android:
strategy:
diff --git a/de= v-tools/reformat-all.sh b/dev-tools/reformat-all.sh
deleted= file mode 100755
index 02421c1..0000000
--= - a/dev-tools/reformat-all.sh
+++ /dev/null
@@ -1,136 +0,0 @@
-#!/= bin/sh
-# reformat-all.= sh - Reformat all git files in the checked out
-# git branch using uncrustify.
-#
-# Copyright (C) 2016-2025 - David Sommerset= h <davids@...515...>
-#
-# This program = is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General P= ublic License
-# as pub= lished by the Free Software Foundation; either version 2
-# of the License.
-#
-# This program is distributed in the hope that it will be usefu= l,
-# but WITHOUT ANY W= ARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPO= SE. See the
-# GNU Gen= eral Public License for more details.
-#
-# Yo= u should have received a copy of the GNU General Public License
<= span style=3D"color: hsl(0, 100%, 40%);">-# along with this program; if not= , write to the Free Software

-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 021= 10-1301, USA.
-#=
-
-tstamp=3D"$(date +%Y%m%d-%H%M%S)"

-files=3D"$(pwd)/reform= at-all_files-$tstamp.lst"
-log=3D"$(pwd)/reformat-all_log-$tstamp.txt"
-
-srcroot=3D"$(git rev-parse --show-toplevel)"<= /span>
-cfg=3D"$srcroot/d= ev-tools/uncrustify.conf"
-specialfiles=3D"$srcroot/dev-tools/special-files.lst"

-
-export gitfiles=3D0
-export procfiles=3D0
-
-# Go to the root of the source tree
-cd "$srcroot"
-
-{
- echo -n &q= uot;** Starting $0: "
- date
-<= br>- # Find all C source/heade= r files
- git ls-fil= es | grep -E ".*\.[ch](\.in$|$)" > "${files}.git"
-
- # Manage files which needs special trea= tment
- awk -F\# = 9;{gsub("\n| ", "", $1); print $1}' "$specialf= iles" > "${files}.sp"
- while read srcfile
- do
- res=3D$(grep "$srcfile" "${files}.sp" 2>= /dev/null)
- if = [ $? -ne 0 ]; then
- = # If grep didn't find the file among special files,
= - # process it normall= y
- echo &qu= ot;$srcfile" >> "$files"
- else
- mode=3D$(echo "$res" | cut -d: -f1)
- case "= $mode" in
- = E)
- = echo "** INFO ** Excluding '$srcfile'"<= br>- ;;=
- P)- echo "= ** INFO ** Pre-patching '$srcfile'"
- patchfile=3D"${srcroot= }"/dev-tools/reformat-patches/before_$(echo "$srcfile" | tr = "/" "_").patch
- if [ -r "$patchfile" ]; then
- g= it apply "$patchfile"
- if [ $? -ne 0 ]; then
- echo "**= ERROR ** Failed to apply pre-patch file: $patchfile"
- exit 2
- = fi
- = else
- = echo "** WARN ** Pre-patch file for $srcfile is missing: $patc= hfile"
- = fi
- = echo "$srcfile" >> "${files}.postpatch"= ;
- = echo "$srcfile" >> "$files"
- ;;
- *)
- echo "** WARN ** U= nknown mode '$mode' for file '$srcfile'"
- ;;

- esac

- fi
- done < "${files}.git"
<= span style=3D"color: hsl(0, 100%, 40%);">- rm -f "${files}.git"= ; "${files}.sp"

-
- # Kick off un= crustify
- echo
- echo "** INFO ** = Running: uncrustify -c $cfg --no-backup -l C -F $files"
- uncrustify -c "$cfg" -= -no-backup -l C -F "$files" 2>&1

- res=3D$?
- echo "** INFO ** Uncrustify completed (exit cod= e $res)"
-} | tee = "${log}-1" # Log needs to be closed here, to be processed in nex= t block
-
-{
- # Check the results
- gitfiles=3D$(wc -l "$files" | cut -d\ = -f1)
- procfiles=3D$= (grep "Parsing: " "${log}-1" | wc -l)
- echo
- echo "C source/header files checked into gi= t: $gitfiles"
- = echo "Files processed by uncrustify: $procfiles"=
- echo
-
- # Post-Patch files modified after we uncrustify have adjus= ted them
- if [ -r &= quot;${files}.postpatch" ]; then
- while read srcfile;
- do
- patchfile=3D"${srcroot}"/dev-tools/reforma= t-patches/after_$(echo "$srcfile" | tr "/" "_"= ;).patch
- i= f [ -r "$patchfile" ]; then
- echo "** INFO ** Post-patching '$= srcfile'"
- = git apply "$patchfile"
- if [ $? -ne 0 ]; then
- echo "** W= ARN ** Failed to apply $patchfile"
- fi
- else
- echo "** WARN ** Post-patch file for $srcfil= e is missing: $patchfile"
- fi
- done < "${files}.postpatch"
- rm -f "${files}.postpatch"
- fi
-} | tee "${log}-2" # Log nee= ds to be closed here, to be processed in next block
-
-cat "${log}-1" "${log}-2" > "$log&qu= ot;
-
-{
- ec=3D1
- echo
- if [= "$gitfiles" -eq "$procfiles" ]; then
- echo "Reformatting complet= ed successfully"
-= ec=3D0
- els= e
- last=3D$(tai= l -n1 "${log}-1")
- echo "** ERROR ** Reformating failed to process all file= s."
- echo = " uncrustify exit code: $res"
- echo " Last log line: = $last"
- ec= ho
- fi
- rm -f "${log}-1" &qu= ot;${log}-2"

-} | = tee -a "$log"
-rm -f "${files}"
-
-exit $ec

diff --git a/dev-tools/special-files.lst b/dev-tools/special-fil= es.lst
deleted file mode 100644
index e5f2f= c2..0000000
--- a/dev-tools/special-files.lst
+++ /dev/null
@@ -1,5 +0,0 @@
-E:doc/doxygen/doc_key_generation.h # @verbat= im section gets mistreated, exclude it
-E:src/compat/compat-lz4.c # Preserve LZ4 upst= ream formatting
-E:src/= compat/compat-lz4.h # Preserve LZ4 upstream formatting<= br>-E:src/openvpn/ovpn_dco_linux.= h # Preserve ovpn-dco upstream formatting
-E:src/openvpn/ovpn_dco_win.h # Preser= ve ovpn-dco-win upstream formatting
diff --git a/dev-tools/= uncrustify.conf b/dev-tools/uncrustify.conf
deleted file mo= de 100644
index 325f310..0000000
--- a/dev-= tools/uncrustify.conf
+++ /dev/null
@@ -1,7= 9 +0,0 @@
-# Use Allman= -style
-indent_columns= =3D4
-indent_braces=3Df= alse
-indent_else_if=3D= false
-indent_switch_ca= se=3D4
-indent_label=3D= 1
-nl_if_brace=3Dadd
-nl_brace_else=3Dadd
-nl_elseif_brace=3Dadd
-nl_else_brace=3Dadd=
-nl_else_if=3Dremove-nl_for_brace=3Dadd
<= span style=3D"color: hsl(0, 100%, 40%);">-nl_while_brace=3Dadd

-nl_switch_brace=3Dadd

-nl_fdef_brace=3Dadd

-nl_do_brace=3Dadd
-sp_func_proto_paren=3DRemove
<= span style=3D"color: hsl(0, 100%, 40%);">-sp_func_def_paren=3DRemove=
-sp_func_call_paren=3DRemove<= /span>
-sp_sizeof_paren=3DRemo= ve
-
-# No tabs, spaces only
-indent_with_tabs=3D0
-align_with_tabs=3Dfalse
-cmt_convert_tab_to_spaces=3Dtrue
-
-# Do not put spaces between the # and preprocess= or statements
-pp_space= =3Dremove
-
<= span style=3D"color: hsl(0, 100%, 40%);">-# Various whitespace fiddling

-sp_assign=3Dadd-sp_before_sparen=3Dadd-sp_inside_sparen=3Dremove
-sp_cond_colon=3Dadd=
-sp_cond_question=3Dadd
-sp_bool=3Dadd
-sp_else_brace=3Dadd

-sp_brace_else=3Dadd

-sp_after_comma=3Dadd
-pos_arith=3DLead
-pos_bool=3DLead
-nl_func_type_name=3Dadd
-nl_before_case=3Dtrue
-nl_assign_leave_one_liners=3Dtrue
-nl_enum_leave_one_liners=3Dtrue
-nl_brace_fparen=3Dadd
-nl_max=3D4
-nl_after_func_proto=3D2

-nl_end_of_file_min=3D1
<= span style=3D"color: hsl(0, 100%, 40%);">-nl_end_of_file=3Dforce
= -
-# Always use scoping braces for conditionals-mod_full_brace_if=3Dadd=
-mod_full_brace_if_chain=3Dfa= lse
-mod_full_brace_whi= le=3Dadd
-mod_full_brac= e_for=3Dadd
-mod_full_b= race_do=3Dadd
-<= br>-# Annotate #else and #endif s= tatements
-mod_add_long= _ifdef_endif_comment=3D20
-mod_add_long_ifdef_else_comment=3D5
-
-# M= isc cleanup
-mod_remove= _extra_semicolon=3Dtrue
-
-# leave blank at en= d of empty for() statements
-sp_after_semi_for_empty=3DAdd
-
-# Use C= -style comments (/* .. */)
-cmt_c_nl_end=3Dtrue
-cmt_cpp_to_c=3Dtrue
-=
-# Use "char **a&= quot;-style pointer stars/dereferences
-sp_before_ptr_star=3DAdd
-sp_between_ptr_star=3DRemove
-sp_after_ptr_star=3DRemove
-sp_before_byref=3DAdd
-sp_after_byref=3DRemove

To view, visit change 830. To unsubscribe, or for help writing = mail filters, visit settings= .

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I15d4946800cbfaead67a73450ff= 3b12193814e54
Gerrit-Change-Number: 830
Gerrit-PatchSet: 11
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newpatchset
--3Pwfx4YbtZ8=--