From: "stipa (Code Review)" Date: Wed, 17 Jan 2024 08:56:03 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <3ca22bbd0ddcc7ce19937b3775d0223f4efd363d-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="4BvPvX4MB4c="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: flichtenheld , cron2 , plaisthos , openvpn-devel --4BvPvX4MB4c= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 5: Code-Review+2 (2 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/d1fb891c_bb0bba56 : PS4, Line 27: #include > They define some types used in the header. [=E2=80=A6] Acknowledged File src/openvpn/win32.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/e3203291_cfd5bef9 : PS4, Line 28: #include > They define some types used in the header. [=E2=80=A6] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: d12fk Gerrit-Comment-Date: Wed, 17 Jan 2024 08:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: d12fk Comment-In-Reply-To: stipa Gerrit-MessageType: comment --4BvPvX4MB4c= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, d12fk, plaisthos.

Patch set 5:Code-Review +2=

Vi= ew Change

2 comments:

  • File include/openvpn-msg.h:

    =
  • File src/openvpn/win32.h:

      Patch Set #4, Line 28: #include <iphlpapi.h>

      They define so= me types used in the header. [=E2=80=A6]

      Acknowledged

  • To view, visit change 489. To unsubscribe, or for help writing mail filters= , visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f= 071db3e4832ba
    Gerrit-Change-Number: 489
    Gerrit-PatchSet: 5
    Gerrit-Owner: d12fk <heiko@...515...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: stipa <lstipakov@...277...= >
    Gerrit-CC: cron2 <gert@...1296...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: cron2 <gert@...1296...>= ;
    Gerrit-Attention: d12fk <heiko@...515...>= ;
    Gerrit-Comment-Date: Wed, 17 Jan 2024 08:56:03= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: d12fk <heiko@...515...= >
    Comment-In-Reply-To: stipa <lstipakov@...1664...= 7...>
    Gerrit-MessageType: comment
    --4BvPvX4MB4c=--