From: "its_Giaan (Code Review)" Date: Tue, 20 Feb 2024 13:33:18 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3ccd3f792f884ce2372ca4f83e0dd899757ef314-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="UmSB+uHsrKI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --UmSB+uHsrKI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: What about "Table_id is supported only on Linux when SITNL is built-in" so = we know that in case we're on Linux but there's not SITNL -> "SITNL is requ= ired", on the other hand if we're not on Linux -> "this is Linux only" File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/524/comment/d372a561_90367367 : PS1, Line 6992: msg(M_WARN, "NOTE: --route-table specified, but not= supported on this platform"); > This warning would be confusing with a Linux build with --enable-iproute2= . [=E2=80=A6] What about "Table_id is supported only on Linux when SITNL is built-in" so = we know that in case we're on Linux but there's not SITNL -> "SITNL is requ= ired", on the other hand if we're not on Linux -> "this is Linux only" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 20 Feb 2024 13:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --UmSB+uHsrKI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

2 comments:

    =
  • Patchset:

    • Patch Set #1:

      What about "Table_id is supported only on Li= nux when SITNL is built-in" so we know that in case we're on Linux= but there's not SITNL -> "SITNL is required", on the othe= r hand if we're not on Linux -> "this is Linux only"

  • File src/openvpn/optio= ns.c:

    • Patch Set #1,= Line 6992: msg= (M_WARN, "NOTE: --route-table specified, but not supported on this pla= tform");

      This warning would be confusing with a = Linux build with --enable-iproute2. [=E2=80=A6]

      What about "Table_id i= s supported only on Linux when SITNL is built-in" so we know that in c= ase we're on Linux but there's not SITNL -> "SITNL is requi= red", on the other hand if we're not on Linux -> "this is = Linux only"

To view, visit change 524. To unsubsc= ribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:33:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--UmSB+uHsrKI=--