From: Heiner Kallweit Subject: [PATCH net-next] net: phy: remove preliminary workaround for not loading PHY driver Date: Tue, 15 Jan 2019 21:11:14 +0100 Message-ID: <3cd71ea6-7bb1-97b8-d239-3e322533c472@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Andrew Lunn , Florian Fainelli , David Miller Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:33511 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729326AbfAOULY (ORCPT ); Tue, 15 Jan 2019 15:11:24 -0500 Received: by mail-wm1-f66.google.com with SMTP id r24so1877202wmh.0 for ; Tue, 15 Jan 2019 12:11:23 -0800 (PST) Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: This workaround attempt helped for some but not all affected users. With commit 11287b693d03 ("r8169: load Realtek PHY driver module before r8169") we have a better workaround now, so we an remove the first attempt. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 51990002d..a2423cbb2 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2250,14 +2250,6 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner) new_driver->mdiodrv.driver.remove = phy_remove; new_driver->mdiodrv.driver.owner = owner; - /* The following works around an issue where the PHY driver doesn't bind - * to the device, resulting in the genphy driver being used instead of - * the dedicated driver. The root cause of the issue isn't known yet - * and seems to be in the base driver core. Once this is fixed we may - * remove this workaround. - */ - new_driver->mdiodrv.driver.probe_type = PROBE_FORCE_SYNCHRONOUS; - retval = driver_register(&new_driver->mdiodrv.driver); if (retval) { pr_err("%s: Error %d in registering driver\n", -- 2.20.1