From: Maarten Lankhorst Subject: Re: [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2. Date: Wed, 3 May 2017 17:53:34 +0200 Message-ID: <3ceb1e81-539d-3290-6089-237403918b26@linux.intel.com> References: <20170501133434.5683-1-maarten.lankhorst@linux.intel.com> <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> <20170503134533.GH12629@intel.com> <587a919a-52a9-ed40-9e18-e6da724be1b0@linux.intel.com> <20170503141159.GM12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id D669E892FA for ; Wed, 3 May 2017 15:53:38 +0000 (UTC) In-Reply-To: <20170503141159.GM12629@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDMtMDUtMTcgb20gMTY6MTEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBN YXkgMDMsIDIwMTcgYXQgMDQ6MDY6MzdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDAzLTA1LTE3IG9tIDE1OjQ1IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g TW9uLCBNYXkgMDEsIDIwMTcgYXQgMDM6MzQ6MzRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gVGhlIHdhdGVybWFya3MgaXQgc2hvdWxkIGNhbGN1bGF0ZSBhZ2FpbnN0IGFy ZSB0aGUgb2xkIG9wdGltYWwgd2F0ZXJtYXJrcy4KPj4+PiBUaGUgY3VycmVudGx5IGFjdGl2ZSBj cnRjIHdhdGVybWFya3MgYXJlIHB1cmUgZmljdGlvbiwgYW5kIGFyZSBpbnZhbGlkIGluCj4+Pj4g Y2FzZSBvZiBhIG5vbmJsb2NraW5nIG1vZGVzZXQsIHBhZ2UgZmxpcCBlbmFibGluZy9kaXNhYmxp bmcgcGxhbmVzIG9yIGFueQo+Pj4+IG90aGVyIHJlYXNvbi4KPj4+Pgo+Pj4+IFdoZW4gdGhlIGNy dGMgaXMgZGlzYWJsZWQgb3IgZHVyaW5nIGEgbW9kZXNldCB0aGUgaW50ZXJtZWRpYXRlIHdhdGVy bWFya3MKPj4+PiBkb24ndCBuZWVkIHRvIGJlIHByb2dyYW1tZWQgc2VwYXJhdGVseSwgYW5kIGNv dWxkIGJlIGRpcmVjdGx5IGFzc2lnbmVkCj4+Pj4gdG8gdGhlIG9wdGltYWwgd2F0ZXJtYXJrcy4K Pj4+Pgo+Pj4+IEFsc28gcmVuYW1lIGNydGNfc3RhdGUgdG8gbmV3X2NydGNfc3RhdGUsIHRvIGRp c3Rpbmd1aXNoIGl0IGZyb20gdGhlIG9sZCBzdGF0ZS4KPj4+Pgo+Pj4+IENoYW5nZXMgc2luY2Ug djE6Cj4+Pj4gLSBVc2UgaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZS4gKHZpbGxlKQo+ Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPj4+PiAtLS0KPj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcG0uYyB8IDIwICsrKysrKysrKysrKysrLS0tLS0tCj4+Pj4gIDEgZmlsZSBjaGFuZ2Vk LCAxNCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wbS5jCj4+Pj4gaW5kZXggMGYzNDRiMWZmZjQ1Li5hMDkzOTZlZTFmM2QgMTAwNjQ0Cj4+ Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+Pj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4+PiBAQCAtMTQ1OCwxNiArMTQ1OCwyNCBAQCBz dGF0aWMgdm9pZCB2bHZfYXRvbWljX3VwZGF0ZV9maWZvKHN0cnVjdCBpbnRlbF9hdG9taWNfc3Rh dGUgKnN0YXRlLAo+Pj4+ICAKPj4+PiAgc3RhdGljIGludCB2bHZfY29tcHV0ZV9pbnRlcm1lZGlh dGVfd20oc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4+PiAgCQkJCSAgICAgICBzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YywKPj4+PiAtCQkJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZSkKPj4+PiArCQkJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3 X2NydGNfc3RhdGUpCj4+Pj4gIHsKPj4+PiAtCXN0cnVjdCB2bHZfd21fc3RhdGUgKmludGVybWVk aWF0ZSA9ICZjcnRjX3N0YXRlLT53bS52bHYuaW50ZXJtZWRpYXRlOwo+Pj4+IC0JY29uc3Qgc3Ry dWN0IHZsdl93bV9zdGF0ZSAqb3B0aW1hbCA9ICZjcnRjX3N0YXRlLT53bS52bHYub3B0aW1hbDsK Pj4+PiAtCWNvbnN0IHN0cnVjdCB2bHZfd21fc3RhdGUgKmFjdGl2ZSA9ICZjcnRjLT53bS5hY3Rp dmUudmx2Owo+Pj4+ICsJc3RydWN0IHZsdl93bV9zdGF0ZSAqaW50ZXJtZWRpYXRlID0gJm5ld19j cnRjX3N0YXRlLT53bS52bHYuaW50ZXJtZWRpYXRlOwo+Pj4+ICsJY29uc3Qgc3RydWN0IHZsdl93 bV9zdGF0ZSAqb3B0aW1hbCA9ICZuZXdfY3J0Y19zdGF0ZS0+d20udmx2Lm9wdGltYWw7Cj4+Pj4g Kwljb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUgPQo+Pj4+ICsJ CWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUobmV3X2NydGNfc3RhdGUtPmJhc2Uuc3Rh dGUsIGNydGMpOwo+Pj4+ICsJY29uc3Qgc3RydWN0IHZsdl93bV9zdGF0ZSAqYWN0aXZlID0gJm9s ZF9jcnRjX3N0YXRlLT53bS52bHYub3B0aW1hbDsKPj4+PiAgCWludCBsZXZlbDsKPj4+PiAgCj4+ Pj4gKwlpZiAoIW5ld19jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSB8fCBkcm1fYXRvbWljX2NydGNf bmVlZHNfbW9kZXNldCgmbmV3X2NydGNfc3RhdGUtPmJhc2UpKSB7Cj4+Pj4gKwkJKmludGVybWVk aWF0ZSA9ICpvcHRpbWFsOwo+Pj4+ICsKPj4+PiArCQlyZXR1cm4gMDsKPj4+PiArCX0KPj4+PiAr Cj4+Pj4gIAlpbnRlcm1lZGlhdGUtPm51bV9sZXZlbHMgPSBtaW4ob3B0aW1hbC0+bnVtX2xldmVs cywgYWN0aXZlLT5udW1fbGV2ZWxzKTsKPj4+PiAgCWludGVybWVkaWF0ZS0+Y3hzciA9IG9wdGlt YWwtPmN4c3IgJiYgYWN0aXZlLT5jeHNyICYmCj4+Pj4gLQkJIWNydGNfc3RhdGUtPmRpc2FibGVf Y3hzcjsKPj4+PiArCQkhbmV3X2NydGNfc3RhdGUtPmRpc2FibGVfY3hzcjsKPj4+IFdlIG5lZWQg dG8gY29uc2lkZXIgZGlzYWJsZV9jeHNyIGV2ZW4gaW4gdGhlIG1vZGVzZXQgY2FzZS4KPj4gV2h5 IGlzIHRoaXM/IGNydGNfc3RhdGUtPmRpc2FibGVfY3hzciBpcyBzZXQgaWYgYW55IHBsYW5lIGlz IHBhcnQgb2YgdGhlIGNydGMgZHVyaW5nIG1vZGVzZXQsIHNvIGl0J3MgZGlzYWJsZWQgZHVyaW5n IG1vZGVzZXQgYWxyZWFkeS4KPiBJdCdzIHNldCBpZiBhbnkgcGxhbmUgaXMgZW5hYmxpbmcvZGlz YWJsaW5nLCB3aGljaCBzaG91bGQgYmUgcXVpdGUKPiB0eXBpY2FsIGR1cmluZyBhIG1vZGVzZXQu CgpZZWFoIGJ1dCAuaW5pdGlhbF93YXRlcm1hcmtzIGlzIGNhbGxlZCBkdXJpbmcgY3J0Y19lbmFi bGUsIHNvIGN4c3Igd2lsbCBnZXQgZW5hYmxlZCBhbnl3YXkuCgpNYXliZSBJJ20gbWlzc2luZyBz b21ldGhpbmcsIGJ1dCB3aHkgYXJlIHRoZSBpbnRlcm1lZGlhdGUgd2F0ZXJtYXJrcyBhbmQgb3B0 aW1pemVfd2F0ZXJtYXJrcyBuZWVkZWQgaGVyZT8KCn5NYWFydGVuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK