Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E85BC4338F for ; Tue, 10 Aug 2021 10:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0F4960EC0 for ; Tue, 10 Aug 2021 10:41:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239890AbhHJKlb (ORCPT ); Tue, 10 Aug 2021 06:41:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48427 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239871AbhHJKla (ORCPT ); Tue, 10 Aug 2021 06:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628592067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s9pAEsCFD860K7G3ngYhHNyW2RsGuwAWwprIRvW0J1w=; b=M7rC4LZg2G13JHjQhCnKkJYRGYdvnUikfxwWhnOTvQ12K1Sl9me0UgyJkL8+HylSY8dPtG 6zuTbOYgyUtE688pVXGk3dtr3eGWcnuz+Qnif+8Zt+DDqowcfj57rucvLChhB2lHCYNM1O ak0KOPEysegZvGkQLr3nXxkRtWG07ec= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368--kIbtyF6MKS83aJLLcAvRA-1; Tue, 10 Aug 2021 06:41:06 -0400 X-MC-Unique: -kIbtyF6MKS83aJLLcAvRA-1 Received: by mail-wr1-f72.google.com with SMTP id o4-20020a5d47c40000b0290154ad228388so6222084wrc.9 for ; Tue, 10 Aug 2021 03:41:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s9pAEsCFD860K7G3ngYhHNyW2RsGuwAWwprIRvW0J1w=; b=mm6PnA9cd/ldzLmlhrQk61w/Ci08ffz0CryvYaE+DytsAdYQnkBzJvm5jFgSrLCUEM E/u/Z6n8WkEg5UIiwDRklh2XDp2HT147y7mO57sTnPtGtca8Xh35tH7IuGtSvbzaTjs6 wqtLGm+/ZDm4XLlsEmrk2QQyVrS4HhTqVIBn1D/MWNJXZ/L2XT5L6ack7T3IfWtXNQds /kLcXAsP4/Eqzq+6Feg/2yELk2PKY7QFsSj8AhMai+D7u+uVEkjga/d3SFRvX4b9Zq1G 0bcK2Gk5ZSFpNaw/0mR8fbx03AjgxdM/NROGTeuqRRkGqXvl5vkARRxTSmmu/AYKm8Ti r7Lw== X-Gm-Message-State: AOAM5323OdU4E9wwcLiZ40MOTLOqVlTwgQ3hxTSLw25sNZuhQBqF990L u0nkPQGZOIdPQ2fhYBfsSYyvBjjQITaa1jt5p31+irhJgvarDWu8OscEcI2X0PA93eX/MfA/6m9 +XTIUN58pbBP1dFZJWGi+SF0OvUK5z/FlLj4PPG/kKwcfSn87vb2D/fOqH0+jzvDp X-Received: by 2002:a05:600c:2248:: with SMTP id a8mr17137342wmm.80.1628592065313; Tue, 10 Aug 2021 03:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxFkPOE/WqTwXfIvfEX6UsCx0IVanEKqLpjLWOY4PFuN4uVZV0K/DfrjVsqE4YOlcNDvFg0w== X-Received: by 2002:a05:600c:2248:: with SMTP id a8mr17137303wmm.80.1628592064999; Tue, 10 Aug 2021 03:41:04 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id s10sm11066606wrv.54.2021.08.10.03.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 03:41:04 -0700 (PDT) Subject: Re: [PATCH V2 3/3] KVM: X86: Reset DR6 only when KVM_DEBUGREG_WONT_EXIT To: Lai Jiangshan , Lai Jiangshan , linux-kernel@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org References: <20210809174307.145263-1-jiangshanlai@gmail.com> <20210809174307.145263-3-jiangshanlai@gmail.com> <7a1ca89f-7b4e-7df2-e47a-ac5207137a05@linux.alibaba.com> From: Paolo Bonzini Message-ID: <3cfedf5c-e901-c65c-b654-4d004e79b6b9@redhat.com> Date: Tue, 10 Aug 2021 12:41:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7a1ca89f-7b4e-7df2-e47a-ac5207137a05@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/08/21 12:34, Lai Jiangshan wrote: >> >> +     * do_debug expects dr6 to be cleared after it runs, avoid that >> it sees >> +     * a stale dr6 from the guest. >> +     */ > > > do_debug() is renamed. Maybe you can use "The host kernel #DB handler". Or exc_debug. Paolo