From: Thomas Hellstrom Subject: Re: [PATCH 3/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty() Date: Thu, 5 Apr 2018 22:15:57 +0200 Message-ID: <3d110ea7-7f1e-b9e2-28d2-88b0f7518c08@vmware.com> References: <20180405195035.24722-1-ville.syrjala@linux.intel.com> <20180405195035.24722-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180405195035.24722-3-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, VMware Graphics , Sinclair Yeh List-Id: dri-devel@lists.freedesktop.org T24gMDQvMDUvMjAxOCAwOTo1MCBQTSwgVmlsbGUgU3lyamFsYSB3cm90ZToKPiBGcm9tOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Cj4gSW5zdGVhZCBv ZiBwbGFuZS0+ZmIgKHdoaWNoIHdlJ3JlIGdvaW5nIHRvIGRlcHJlY2F0ZSBmb3IgYXRvbWljIGRy aXZlcnMpCj4gd2UgbmVlZCB0byBsb29rIGF0IHBsYW5lLT5zdGF0ZS0+ZmIuIFRoZSBtYXplIG9m IGNvZGUgbGVhZGluZyB0bwo+IHZtd19rbXNfaGVscGVyX2RpcnR5KCkgd2Fzbid0IHBhcnRpY3Vs YXJseSBjbGVhciwgYnV0IG15IGFuYWx5c2lzCj4gY29uY2x1ZGVkIHRoYXQgdGhlIGNhbGxzIG9y aWdpbmF0aW5nIGZyb20gdm13XypfcHJpbWFyeV9wbGFuZV9hdG9taWNfdXBkYXRlKCkKPiBhbGwg cGFzcyBpbiB0aGUgY3J0YyB3aGljaCBtZWFucyB3ZSdsbCBuZXZlciBlbmQgdXAgaW4gdGhpcyBi cmFuY2gKPiBvZiB0aGUgZnVuY3Rpb24uIEFsbCBvdGhlciBjYWxsZXJzIHVzZSBkcm1fbW9kZXNl dF9sb2NrX2FsbCgpIHNvbWV3aGVyZQo+IGhpZ2hlciB1cCwgd2hpY2ggbWVhbnMgYWNjZXNzaW5n IHBsYW5lLT5zdGF0ZSBpcyBzYWZlLiBXZSdsbCB0b3NzIGluCj4gYSBsb2NrZGVwIGFzc2VydCB0 byBjYXRjaCB3cm9uZ2RvZXJzLgo+Cj4gQ2M6IFRob21hcyBIZWxsc3Ryb20gPHRoZWxsc3Ryb21A dm13YXJlLmNvbT4KPiBDYzogU2luY2xhaXIgWWVoIDxzeWVoQHZtd2FyZS5jb20+Cj4gQ2M6IFZN d2FyZSBHcmFwaGljcyA8bGludXgtZ3JhcGhpY3MtbWFpbnRhaW5lckB2bXdhcmUuY29tPgo+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYyB8IDE1ICsrKysrKysrKysrKy0t LQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMgYi9kcml2 ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9rbXMuYwo+IGluZGV4IGEyYTc5NmI0Y2MyMy4uNWE4 MjQxMjVjMjMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2tt cy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfa21zLmMKPiBAQCAtMjMy Niw5ICsyMzI2LDE4IEBAIGludCB2bXdfa21zX2hlbHBlcl9kaXJ0eShzdHJ1Y3Qgdm13X3ByaXZh dGUgKmRldl9wcml2LAo+ICAgCX0gZWxzZSB7Cj4gICAJCWxpc3RfZm9yX2VhY2hfZW50cnkoY3J0 YywgJmRldl9wcml2LT5kZXYtPm1vZGVfY29uZmlnLmNydGNfbGlzdCwKPiAgIAkJCQkgICAgaGVh ZCkgewo+IC0JCQlpZiAoY3J0Yy0+cHJpbWFyeS0+ZmIgIT0gJmZyYW1lYnVmZmVyLT5iYXNlKQo+ IC0JCQkJY29udGludWU7Cj4gLQkJCXVuaXRzW251bV91bml0cysrXSA9IHZtd19jcnRjX3RvX2R1 KGNydGMpOwo+ICsJCQlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9IGNydGMtPnByaW1hcnk7Cj4g Kwo+ICsJCQkvKgo+ICsJCQkgKiB2bXdfKl9wcmltYXJ5X3BsYW5lX2F0b21pY191cGRhdGUoKSBw YXNzIGluIHRoZSBjcnRjLAo+ICsJCQkgKiBhbmQgc28gZG9uJ3QgZW5kIHVwIGhlcmUuIEFsbCBv dGhlciBjYWxsZXJzIHVzZQo+ICsJCQkgKiBkcm1fbW9kZXNldF9sb2NrX2FsbCgpLCBoZW5jZSB3 ZSBjYW4gYWNjZXNzIHRoZQo+ICsJCQkgKiBwbGFuZSBzdGF0ZSBzYWZlbHkuCj4gKwkJCSAqLwo+ ICsJCQlsb2NrZGVwX2Fzc2VydF9oZWxkKCZwbGFuZS0+bXV0ZXgpOwo+ICsKSSB0aGluayB3ZSBj YW4gcmVtb3ZlIHRoZSBjb21tZW50IChpdCdzIGEgaGVscGVyLCBzbyBjdXJyZW50IHVzZXJzIG1h eSAKbm90IGJlIGZ1dHVyZSB1c2VycyksCmJ1dCB0aGUgbG9ja2RlcCBhc3NlcnQgc2hvdWxkIGJl IE9LLgo+ICsJCQlpZiAocGxhbmUtPnN0YXRlLT5mYiAhPSAmZnJhbWVidWZmZXItPmJhc2UpCj4g KwkJCQl1bml0c1tudW1fdW5pdHMrK10gPSB2bXdfY3J0Y190b19kdShjcnRjKTsKClRoaXMgZG9l c24ndCBzZWVtIHRvIGRvIHdoYXQgdGhlIG9yaWdpbmFsIGNvZGUgZGlkLi4uCgo+ICAgCQl9Cj4g ICAJfQo+ICAgCgovVGhvbWFzCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==