Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A561514830A for ; Mon, 26 May 2025 17:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748281137; cv=none; b=Da5P5+G2WYaW96WKoBCedckAttZBOQ9ejVjMLPEHaxy4QGhiUkTpLJRrcbaJYtwm856PxyGvECvXLMWCaI7/ifAnF1guD8vvutdp2NWgdMAn/c2/y+LNd82DxOu2weCUOey0x1dQWlTgPjvlVCQOMZvJiLKFpX30hePc5wAtlOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748281137; c=relaxed/simple; bh=LLTLKhA5EptdSI8qM5ESx1/OIokAzJ7Z6Ewl5oCqp1o=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=j0rB8+HRUU01OIrbRS3pHZ0UZItKMyILU5Pc84N9YQ5V59G98viEvUhtikcxlZAwO4RHc2ZKoqBOpQbxwYejb2NKB7cvw9vR2/7Xw6vjAgvlrMvNqQQHJvRx1VMuBX75jM72AX+l382ysLDr34kvgs+EDuTml2CgPC2yGsPZmDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=c9mbdEs2; arc=none smtp.client-ip=209.85.166.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="c9mbdEs2" Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-86a55400875so215861739f.3 for ; Mon, 26 May 2025 10:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1748281135; x=1748885935; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=ff7nQRFxfb974x1cqZTE+6GOZ2tVuJK5IlmnvxCpS/Y=; b=c9mbdEs26IqBSK5VnN0Zi8ahZn7KuI1frTF8zrrC+cmlTAIcy3V7llbIAXsMe9LkdM 4JmkIOSpSTLeiKEw7cXFIEHteI5vOBDMrekk3ZzaxZzcAVnnaX6FHvAKbOCg27SuhmR2 L1O1JU2gO7JelSli26ziNHgNaopuOEOgtOQr0/1kCKcOEZ8ZCqU2QUJadRUZ+O37BJtb q1t7TG5wjE6Ct1k6kHzoJPwprYpSF4ZvwDUuswPuQ4Ej9VcnX+7QB9H23VXHz2D90Bvf CVmDfT6/x7WGqUqZmuV5LzZ306tosonwWOFpeyc2J33GvKYxua0HtkCWKenBmAJP4C8V 6e/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748281135; x=1748885935; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ff7nQRFxfb974x1cqZTE+6GOZ2tVuJK5IlmnvxCpS/Y=; b=f3gMaRk3/VBL0kFdL0OIfJy5K5xmxK/w6N7icuCyVg6480+vPIy6TY6jS/Qv+hWwIc h5kQn5wAeasHkvPwxRMjODJCMahLPIzzoSK+iDeVPUDz7d3Zh9jkfpJ0MLoz1uhK9vUD V6VYV8kPAoFbqLJVjl9byj6kSvF8+HKOJtyvDcjU5VkUFG7/tvh7kVr8Vn2z/z9UVs3T Y7rPtPpU3BKYsntTKzc8aqSWGJy1dzV4TRzRjHma8DPqX5HqeX+rux/3cG3OR7eGjekE uC4pMbuT3N+novkBdQROps5DS2zu6o9srzYcffpEfYFEvE4P/0CUTNnT0vHQm6sVRxJo dIxw== X-Forwarded-Encrypted: i=1; AJvYcCW/RIqQjCyN6h27xPw9zxYkQl5c8JA5GKmJ0Y1fS+zl3/dDXBYulkk2lOSDb5/ohQj68s7446Awd6PANGXp@vger.kernel.org X-Gm-Message-State: AOJu0YwyWCiw5nFIbCOx2PxVhQGXcxLYNyiJSXg5407SdipawBceUxnM snlGFTe15DNnPflfiFo9kX+h7LcjDpS+aShRcl5sX7AhLAcDErgYbpgiOEjTayhKrM8= X-Gm-Gg: ASbGncuED+4pQoaUZIITUBP3G/5GIkD9bPXq5spjX604stDBM74HyFeE8U2/wNd3kWo xq48T0Mx9zxDOeFHxJnf6fDFBXtS1ArbFvddjwkhb+HACcw2XdCvMYBHNRjgNLYGnt8fbhEqXTh P05cx8QU0tXbhkn85hYtI5vs61fBMcjmQ01oeLNd51KGxv9fHVw4Rfqqao99xI3tnrKZZOgmQsI ILquBmaCZirqoX7O1WGsFBE8NjewP/an1OGlYk/zSRidPMUk2Nxm+R935OXY6Vc5N1XAMMxRr9A f0VZFNPrmFkm9j22Uflfc2RsXVkWiRZ0ZknD1ETm/gzxdqNn X-Google-Smtp-Source: AGHT+IFmvFRmO29KPh+6/A42vWbuhUWcx0N2F5H25LY+qJByBaZaeku0EF5+B/UfZfQgLLGsqIArxA== X-Received: by 2002:a05:6602:728a:b0:85c:c7f9:9a1c with SMTP id ca18e2360f4ac-86cbb8bbdb6mr877426039f.13.1748281134626; Mon, 26 May 2025 10:38:54 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-86a235e33c3sm482139739f.13.2025.05.26.10.38.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 10:38:53 -0700 (PDT) Message-ID: <3d123216-c412-4779-8461-b6691d7cafc7@kernel.dk> Date: Mon, 26 May 2025 11:38:53 -0600 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BUG] regression from 974c5e6139db "xfs: flag as supporting FOP_DONTCACHE" (double free on page?) From: Jens Axboe To: Vlastimil Babka , Al Viro , Matthew Wilcox , Jan Kara Cc: Christoph Hellwig , "Darrick J. Wong" , Christian Brauner , linux-fsdevel@vger.kernel.org, Linus Torvalds References: <20250525083209.GS2023217@ZenIV> <20250525180632.GU2023217@ZenIV> <40eeba97-a298-4ae1-9691-b5911ad00095@suse.cz> <431cb497-b1ad-40a0-86b1-228b0b7490b9@kernel.dk> <6741c978-98b1-4d6f-af14-017b66d32574@kernel.dk> Content-Language: en-US In-Reply-To: <6741c978-98b1-4d6f-af14-017b66d32574@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/26/25 9:06 AM, Jens Axboe wrote: > On 5/26/25 7:05 AM, Jens Axboe wrote: >> On 5/25/25 1:12 PM, Vlastimil Babka wrote: >>> On 5/25/25 8:06 PM, Al Viro wrote: >>>> On Sun, May 25, 2025 at 09:32:09AM +0100, Al Viro wrote: >>>> >>>>> Breakage is still present in the current mainline ;-/ >>>> >>>> With CONFIG_DEBUG_VM on top of pagealloc debugging: >>>> >>>> [ 1434.992817] run fstests generic/127 at 2025-05-25 11:46:11g >>>> [ 1448.956242] BUG: Bad page state in process kworker/2:1 pfn:112cb0g >>>> [ 1448.956846] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x3e pfn:0x112cb0g >>>> [ 1448.957453] flags: 0x800000000000000e(referenced|uptodate|writeback|zone=2)g >>> >>> It doesn't like the writeback flag. >>> >>>> [ 1448.957863] raw: 800000000000000e dead000000000100 dead000000000122 0000000000000000g >>>> [ 1448.958303] raw: 000000000000003e 0000000000000000 00000000ffffffff 0000000000000000g >>>> [ 1448.958833] page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) setg >>>> [ 1448.959320] Modules linked in: xfs autofs4 fuse nfsd auth_rpcgss nfs_acl nfs lockd grace sunrpc loop ecryptfs 9pnet_virtio 9pnet netfs evdev pcspkr sg button ext4 jbd2 btrfs blake2b_generic xor zlib_deflate raid6_pq zstd_compress sr_mod cdrom ata_generic ata_piix psmouse serio_raw i2c_piix4 i2c_smbus libata e1000g >>>> [ 1448.960874] CPU: 2 UID: 0 PID: 2614 Comm: kworker/2:1 Not tainted 6.14.0-rc1+ #78g >>>> [ 1448.960878] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014g >>>> [ 1448.960879] Workqueue: xfs-conv/sdb1 xfs_end_io [xfs]g >>>> [ 1448.960938] Call Trace:g >>>> [ 1448.960939] g >>>> [ 1448.960940] dump_stack_lvl+0x4f/0x60g >>>> [ 1448.960953] bad_page+0x6f/0x100g >>>> [ 1448.960957] free_frozen_pages+0x471/0x640g >>>> [ 1448.960958] iomap_finish_ioend+0x196/0x3c0g >>>> [ 1448.960963] iomap_finish_ioends+0x83/0xc0g >>>> [ 1448.960964] xfs_end_ioend+0x64/0x140 [xfs]g >>>> [ 1448.961003] xfs_end_io+0x93/0xc0 [xfs]g >>>> [ 1448.961036] process_one_work+0x153/0x390g >>>> [ 1448.961044] worker_thread+0x2ab/0x3b0g >>>> [ 1448.961045] ? rescuer_thread+0x470/0x470g >>>> [ 1448.961047] kthread+0xf7/0x200g >>>> [ 1448.961048] ? kthread_use_mm+0xa0/0xa0g >>>> [ 1448.961049] ret_from_fork+0x2d/0x50g >>>> [ 1448.961053] ? kthread_use_mm+0xa0/0xa0g >>>> [ 1448.961054] ret_from_fork_asm+0x11/0x20g >>>> [ 1448.961058] g >>>> [ 1448.961155] Disabling lock debugging due to kernel taintg >>>> [ 1448.969569] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x3e pfn:0x112cb0g >>> >>> same pfn, same struct page >>> >>>> [ 1448.970023] flags: 0x800000000000000e(referenced|uptodate|writeback|zone=2)g >>>> [ 1448.970651] raw: 800000000000000e dead000000000100 dead000000000122 0000000000000000g >>>> [ 1448.971222] raw: 000000000000003e 0000000000000000 00000000ffffffff 0000000000000000g >>>> [ 1448.971812] page dumped because: VM_BUG_ON_FOLIO(((unsigned int) folio_ref_count(folio) + 127u <= 127u))g >>>> [ 1448.972490] ------------[ cut here ]------------g >>>> [ 1448.972841] kernel BUG at ./include/linux/mm.h:1455!g >>> >>> this is folio_get() noticing refcount is 0, so a use-after free, because >>> we already tried to free the page above. >>> >>> I'm not familiar with this code too much, but I suspect problem was >>> introduced by commit fb7d3bc414939 ("mm/filemap: drop streaming/uncached >>> pages when writeback completes") and only (more) exposed here. >>> >>> so in folio_end_writeback() we have >>> if (__folio_end_writeback(folio)) >>> folio_wake_bit(folio, PG_writeback); >>> >>> but calling the folio_end_dropbehind_write() doesn't depend on the >>> result of __folio_end_writeback() >>> this seems rather suspicious >>> >>> I think if __folio_end_writeback() was true then PG_writeback would be >>> cleared and thus we'd not see the PAGE_FLAGS_CHECK_AT_FREE failure. >>> Instead we do a premature folio_end_dropbehind_write() dropping a page >>> ref and then the final folio_put() in folio_end_writeback() frees the >>> page and splats on the PG_writeback. Then the folio is processed again >>> in the following iteration of iomap_finish_ioend() and splats on the >>> refcount-already-zero. >>> >>> So I think folio_end_dropbehind_write() should only be done when >>> __folio_end_writeback() was true. Most likely even the >>> folio_test_clear_dropbehind() should be tied to that, or we clear it too >>> early and then never act upon it later? >> >> Thanks for taking a look at this! I tried to reproduce this this morning >> and failed miserably. I then injected a delay for the above case, and it >> does indeed then trigger for me. So far, so good. >> >> I agree with your analysis, we should only be doing the dropbehind for a >> non-zero return from __folio_end_writeback(), and that includes the >> test_and_clear to avoid dropping the drop-behind state. But we also need >> to check/clear this state pre __folio_end_writeback(), which then puts >> us in a spot where it needs to potentially be re-set. Which fails pretty >> racy... >> >> I'll ponder this a bit. Good thing fsx got RWF_DONTCACHE support, or I >> suspect this would've taken a while to run into. > > Took a closer look... I may be smoking something good here, but I don't > see what the __folio_end_writeback()() return value has to do with this > at all. Regardless of what it returns, it should've cleared > PG_writeback, and in fact the only thing it returns is whether or not we > had anyone waiting on it. Which should have _zero_ bearing on whether or > not we can clear/invalidate the range. > > To me, this smells more like a race of some sort, between dirty and > invalidation. fsx does a lot of sub-page sized operations. > > I'll poke a bit more... I _think_ we're racing with the same folio being marked for writeback again. Al, can you try the below? diff --git a/mm/filemap.c b/mm/filemap.c index 7b90cbeb4a1a..e95b184a2459 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1604,7 +1604,7 @@ static void folio_end_dropbehind_write(struct folio *folio) * invalidation in that case. */ if (in_task() && folio_trylock(folio)) { - if (folio->mapping) + if (folio->mapping && !folio_test_writeback(folio)) folio_unmap_invalidate(folio->mapping, folio, 0); folio_unlock(folio); } -- Jens Axboe