Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9732E10F2B6 for ; Mon, 7 Feb 2022 07:52:15 +0000 (UTC) Message-ID: <3d686117da6cd248176f470db76c857d918d24b0.camel@linux.intel.com> From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= Date: Mon, 07 Feb 2022 08:52:11 +0100 In-Reply-To: <20220204200333.6383-1-arjun.melkaveri@intel.com> References: <20220204200333.6383-1-arjun.melkaveri@intel.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_engines: Added out fence for execute-one subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Arjun Melkaveri , igt-dev@lists.freedesktop.org List-ID: On Sat, 2022-02-05 at 01:33 +0530, Arjun Melkaveri wrote: > Resolved __gem_execbuf error seen, by passing spin->execbuf.rsvd2 >> > 32. > As we are creating ctx for each engine . > Error resolved:- > (gem_ctx_engines:4117) CRITICAL: Failed assertion: > __gem_execbuf(i915, &execbuf) == expected > (gem_ctx_engines:4117) CRITICAL: Failed to report the valid engine > for slot 0 (valid at 0) > > Introducing IGT_SPIN_FENCE_OUT means we can stop using the > no-preemption in spinner. Added > I915_EXEC_FENCE_IN to the execbuf.flags so that it > is executed after the spinner. > This is enhancement to the code . > > Cc: Chris Wilson > Cc: Thomas Hellström > Signed-off-by: Arjun Melkaveri Reviewed-by: Thomas Hellström