From: "plaisthos (Code Review)" Date: Tue, 15 Jul 2025 10:42:21 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <3d776f4feac0728cfe399c04a431e840686ee8fc-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fuhZftPMYVI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify mbed TLS related define from autoconf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --fuhZftPMYVI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1081?usp=3Demail ) Change subject: Cleanup/simplify mbed TLS related define from autoconf ...................................................................... Patch Set 7: (1 comment) File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/1081/comment/327557b0_9308dcaf : PS7, Line 1041: AC_CHECK_HEADER(psa/crypto.h) > Needs to be AC_CHECK_HEADERS, otherwise HAVE_MBEDTLS_PSA_CRYPTO_H is neve= r defined. [=E2=80=A6] *sigh* I hate autconf. Might be fine to remove it but I am not in the mood = today to try this in this patch and then figure out, it wasn't. Let's do th= at in some follow up patch. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd Gerrit-Change-Number: 1081 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 15 Jul 2025 10:42:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --fuhZftPMYVI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

View = Change

1 comment:

    =
  • File configure.ac:

    • Patch Set #7, Line 1041: AC_CHECK_HEADER(psa/crypto.h)

      Needs to be AC_CHECK_HEADERS, otherwise HAVE_MBEDTLS_P= SA_CRYPTO_H is never defined. [=E2=80=A6]

      *sigh* I hate autconf. Might be f= ine to remove it but I am not in the mood today to try this in this patch a= nd then figure out, it wasn't. Let's do that in some follow up patc= h.

To view, visit change 1081. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c= 5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 15 Jul 2025 10:42:21= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--fuhZftPMYVI=--