From: Daniel Schwierzeck Date: Fri, 27 Mar 2020 16:08:16 +0100 Subject: [PATCH 2/3] mips: Start using ldflags-y for 32/64bit LDFLAGS In-Reply-To: <20200327135202.16788-2-trini@konsulko.com> References: <20200327135202.16788-1-trini@konsulko.com> <20200327135202.16788-2-trini@konsulko.com> Message-ID: <3d7ad78c-068f-264a-003c-784b01571491@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, Am 27.03.20 um 14:52 schrieb Tom Rini: > To prepare to update our Kbuild logic, start switching some of our cases > of adding different bit/endian linker flags via ldflags-y > > Cc: Daniel Schwierzeck > Signed-off-by: Tom Rini > --- > arch/mips/config.mk | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/mips/config.mk b/arch/mips/config.mk > index 9d3a84539a7d..f8180dcd396c 100644 > --- a/arch/mips/config.mk > +++ b/arch/mips/config.mk > @@ -4,8 +4,8 @@ > # Wolfgang Denk, DENX Software Engineering, wd at denx.de. > > ifdef CONFIG_SYS_BIG_ENDIAN > -32bit-emul := elf32btsmip > -64bit-emul := elf64btsmip > +ldflags-$(CONFIG_32BIT) += -m elf32btsmip > +ldflags-$(CONFIG_64BIT) += -m elf64btsmip > 32bit-bfd := elf32-tradbigmips > 64bit-bfd := elf64-tradbigmips > PLATFORM_CPPFLAGS += -EB > @@ -13,8 +13,8 @@ PLATFORM_LDFLAGS += -EB > endif > > ifdef CONFIG_SYS_LITTLE_ENDIAN > -32bit-emul := elf32ltsmip > -64bit-emul := elf64ltsmip > +ldflags-$(CONFIG_32BIT) += -m elf32btsmip > +ldflags-$(CONFIG_64BIT) += -m elf64btsmip > 32bit-bfd := elf32-tradlittlemips > 64bit-bfd := elf64-tradlittlemips > PLATFORM_CPPFLAGS += -EL > @@ -23,18 +23,18 @@ endif > > ifdef CONFIG_32BIT > PLATFORM_CPPFLAGS += -mabi=32 > -PLATFORM_LDFLAGS += -m $(32bit-emul) > OBJCOPYFLAGS += -O $(32bit-bfd) > CONFIG_STANDALONE_LOAD_ADDR ?= 0x80200000 > endif > > ifdef CONFIG_64BIT > PLATFORM_CPPFLAGS += -mabi=64 > -PLATFORM_LDFLAGS += -m$(64bit-emul) > OBJCOPYFLAGS += -O $(64bit-bfd) > CONFIG_STANDALONE_LOAD_ADDR ?= 0xffffffff80200000 > endif > > +PLATFORM_LDFLAGS += $(ldflags-y) is this change really necessary? I'd like to keep that in sync with MIPS Linux. And MIPS Linux simply changed to KBUILD_LDFLAGS += -m $(ld-emul) > + > PLATFORM_CPPFLAGS += -D__MIPS__ > PLATFORM_ELFENTRY = "__start" > PLATFORM_ELFFLAGS += -B mips $(OBJCOPYFLAGS) > -- - Daniel