From: "Christian Limpach" Subject: Re: [PATCH 2/2] Virtual frame buffer: user space backend Date: Fri, 7 Jul 2006 17:57:52 +0100 Message-ID: <3d8eece20607070957p2d6bb1e5o7febaa5ca124429d@mail.gmail.com> References: <87ac80ghox.fsf@pike.pond.sub.org> <871wtcghmr.fsf@pike.pond.sub.org> Reply-To: Christian.Limpach@cl.cam.ac.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <871wtcghmr.fsf@pike.pond.sub.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Markus Armbruster Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 6/26/06, Markus Armbruster wrote: > Straightforward conversion to Xenstore. > > Applies to hg repository at http://hg.codemonkey.ws/vncfb This also looks ok, two of the frontend issues apply here as well: - handling of the ring indexes (masking of indexes and use of barriers) - xenbus transactions can fail and there's no code to retry failed transactions Additionally, it would be good to use the vnc server code which we're going to use in the updated ioemu. Sharing code for the framebuffers for pv and non-pv domains is good and we don't want the dependency on libvncserver anymore and the qemu vnc code is much compacter. You'll want to grab the vnc files which come with qemu 0.8.1 (http://xenbits.xensource.com/chris/ioemu-cvs-qemu-0.8.1.tar.bz2) and then apply the following two patches: http://xenbits.xensource.com/chris/xs-tools-ioemu.pq.hg?f=18f45f0721d8;file=vnc-cleanup;style=raw http://xenbits.xensource.com/chris/xs-tools-ioemu.pq.hg?f=bc42f3c29c74;file=vnc-fixes;style=raw Ideally, we'd move qemu's vnc support into a library to make it reusable. christian