From: "d12fk (Code Review)"
Date: Wed, 19 Mar 2025 22:45:41 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <3dcf58cc8d2674e6899cb1ca77171b96593fe9e6-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="RjUexaqktm8="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement
--dns option support with NRPT
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: stipa , flichtenheld , plaisthos , openvpn-devel
--RjUexaqktm8=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/837?usp=3Demail )
Change subject: win: implement --dns option support with NRPT
......................................................................
Patch Set 13:
(2 comments)
File src/openvpnserv/interactive.c:
http://gerrit.openvpn.net/c/openvpn/+/837/comment/b96c8df4_7beb686c :
PS13, Line 2602: free(wide_domains);
> If domains is not set, we're freeing stack-allocated wide_domains (PWSTR =
wide_domains =3D L".\0";).
Done
http://gerrit.openvpn.net/c/openvpn/+/837/comment/8eed4464_e3ea759f :
PS13, Line 2782: DWORD iid_err =3D InterfaceIdString(msg->iface.name, i=
id, sizeof(iid));
> We pass sizeof(iid) as count to wcsncpy and it should be count of wide ch=
ars, not the buffer size. [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 13
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: stipa
Gerrit-Comment-Date: Wed, 19 Mar 2025 22:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--RjUexaqktm8=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
View C=
hange
2 comments:
Done<=
/p>
Patch Set #13, Line 2782: DWORD iid_err =3D InterfaceIdString(msg->iface.n=
ame, iid, sizeof(iid));
We pass sizeof(iid) as count =
to wcsncpy and it should be count of wide chars, not the buffer size. [=E2=
=80=A6]
Done
To view, visit change 837. To unsubscribe=
, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5=
adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 13
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Wed, 19 Mar 2025 22:45:41=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...=
7...>
Gerrit-MessageType: comment
--RjUexaqktm8=--