Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E36B3FA3741 for ; Mon, 31 Oct 2022 21:48:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FF4585521; Mon, 31 Oct 2022 22:48:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667252914; bh=/vVcSutcO+I3RMQr5+A/pZxEFOtqzrs11hEIXH9KH18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ner1L7BINtK0wqkiVp0sbIc7Y49GinSCqY+IBU9k860XXckUeXpGzFPqCYMjR3RSG NZvX9Y1hf/Z2KyUmabwNbeGDMQe/9hXOQSLq0AzCS94rk5OBAlwEhrOredqLtAvf+9 K5zPdmRECy3c+U9vDd0RiS/RW3H4vm7Nlpq/BjhxnYvCEPmWhLzD78Lqgpr8sMk2OK FglP/n5BfR3/z4iRV8Oa/pRS/CLq3JvUSI7F8Xaru9Pis/EimkSSS4Q1eB96ESOQ0Y ilJ3D0mzS/90zwOqwWX629VbxOuQCO3aToJVjsDi04HcEYrUKrF5AJNFToJd+XGjx7 e1rAT/BmqI+3w== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A94FC8515C; Mon, 31 Oct 2022 22:48:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1667252913; bh=/vVcSutcO+I3RMQr5+A/pZxEFOtqzrs11hEIXH9KH18=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=zQYRPTqoKlpLo0MQzesczcjCObSXM2SnI+SHQC4Qxn40jZTXBQuw8lAmWTqqIW65q QTb9YX2WFOcyZRUDdHzrGOWV3eocD74pJqG4SSs9yUwniOkollkEgXu/KZ9xjNd+4H p07FYm71qoGgGMqIE2zvCN4IOYMhwUkEvvfqonN0hRJx8D1j2nV3FYHR9myKpxxvVz TBCjmM45AQR08mJEpfcdqwyO73YfIPSYGibrmkzDxrmJX1TV1G5xpCNJZTkaXkKOk4 bdoT76GXN2kBUinXn6ROMMyVlWH69ZajGAew4xT/apMC0P8mqHd5OxROUapgG24+Ep dckJ2MID14AXw== Message-ID: <3e17b8b3-d5ca-aa04-e8cf-c7a13724f240@denx.de> Date: Mon, 31 Oct 2022 21:57:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] usb: Add 1ms delay after first Get Descriptor request Content-Language: en-US To: Simon Glass Cc: u-boot@lists.denx.de, Janne Grunau , Mark Kettenis References: <20221030223835.422976-1-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/31/22 20:27, Simon Glass wrote: > Hi Marek, Hi, > On Sun, 30 Oct 2022 at 16:38, Marek Vasut wrote: >> >> Logitech Unifying Receiver 046d:c52b bcdDevice 12.10 seems >> sensitive about the first Get Descriptor request. If there >> are any other requests in the same microframe, the device >> reports bogus data, first of the descriptor parts is not >> sent to the host. Wait over one microframe duration before >> issuing subsequent requests to avoid probe failure with >> this device, since it can be used to connect USB keyboards. >> >> Signed-off-by: Marek Vasut >> --- >> Cc: Janne Grunau >> Cc: Mark Kettenis >> --- >> common/usb.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) > > Is this device complying with the spec or is it broken? > > In any case we need a way to enable/disable this as it will slow down > unaffected platforms. This makes little difference, since anyone can plug such device into a port and suddenly the platform is affected. We cannot really predict what users have on their desks. Specifically for this case, the logitech receiver seems to be a rather common device. > I've also been wondering if (not with this patch) USB can move to > using the cyclic stuff to do its work, so we don't have to wait. EHCI HCD already partly does, at least for storage, so yes, patches welcome.