From: "stipa (Code Review)" Date: Fri, 31 Jan 2025 13:32:13 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <3e3af5dc1df9b97bc2351a8a63fd8353eb12e933-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Nj0g0OMAsys="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: route.c: improve get_default_gateway() logic on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , plaisthos , flichtenheld , openvpn-devel --Nj0g0OMAsys= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/879?usp=3Demail ) Change subject: route.c: improve get_default_gateway() logic on Windows ...................................................................... Patch Set 3: (2 comments) File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/879/comment/a0e6aa22_44e519ff : PS2, Line 2812: DWORD a_index =3D adapter_index_of_ip(adapters, rgi->ga= teway.addr, NULL, &rgi->gateway.netmask); > This fails for `ON_LINK` targets, where `gateway.addr =3D=3D 0.0.0.0`. [= =E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/879/comment/b7f7fe7b_1e60f462 : PS2, Line 2827: > the IPv6 part sets the `RGI_ON_LINK` flag when the `BestRoute. [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/879?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c7e1cef637fe9fb3f3bc6ff4fb2c65599cd86fb Gerrit-Change-Number: 879 Gerrit-PatchSet: 3 Gerrit-Owner: stipa Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 31 Jan 2025 13:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --Nj0g0OMAsys= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

2 comments:

    =
  • File src/openvpn/route.c:

    • Patch Set #2, Line 2812:= DWORD a_index =3D adap= ter_index_of_ip(adapters, rgi->gateway.addr, NULL, &rgi->gateway.= netmask);

      This fails for `ON_LINK` targets, where `ga= teway.addr =3D=3D 0.0.0.0`. [=E2=80=A6]

      Done

    • Patch Set #2,= Line 2827:

      =

      the IPv6 part sets the `RGI_ON_LINK` flag when the `BestRoute. = [=E2=80=A6]

      Done

To view, visit change 879. To unsubsc= ribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c7e1cef637fe9fb3f3bc6ff4fb= 2c65599cd86fb
Gerrit-Change-Number: 879
Gerrit-PatchSet: 3
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 31 Jan 2025 13:32:13= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--Nj0g0OMAsys=--