Content-Type: multipart/mixed; boundary="===============8223046376005270586==" MIME-Version: 1.0 From: Liang He To: kbuild-all@lists.01.org Subject: Re: [PATCH] drivers: soc: sifive: Add missing of_node_put() in sifive_l2_cache.c Date: Thu, 16 Jun 2022 12:54:50 +0800 Message-ID: <3e6469ba.38b2.1816add33c5.Coremail.windhl@126.com> In-Reply-To: <202206160559.fVKJx0ST-lkp@intel.com> List-Id: --===============8223046376005270586== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable At 2022-06-16 05:58:05, "kernel test robot" wrote: >Hi Liang, > >Thank you for the patch! Yet something to improve: > >[auto build test ERROR on linus/master] >[also build test ERROR on v5.19-rc2 next-20220615] >[If your patch is applied to the wrong git tree, kindly drop us a note. >And when submitting patch, we suggest to use '--base' as documented in >https://git-scm.com/docs/git-format-patch] > When I use --base, there are too many prerequests-patch-id caused by my loc= al commits. = I don't know if it will cause other troubles. So I resent a new patch still= without this '--base'. Is it Ok? Sorry, I forget to say in new patch that is based on v5.19-rc2 mainline gi= t repo. >url: https://github.com/intel-lab-lkp/linux/commits/Liang-He/drivers-so= c-sifive-Add-missing-of_node_put-in-sifive_l2_cache-c/20220615-202528 >base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git= 018ab4fabddd94f1c96f3b59e180691b9e88d5d8 >config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/202206= 16/202206160559.fVKJx0ST-lkp(a)intel.com/config) >compiler: riscv64-linux-gcc (GCC) 11.3.0 >reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin= /make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/49c4086768b5aff410= a4a19ca740f8ae8e211844 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Liang-He/drivers-soc-sifive-Add-m= issing-of_node_put-in-sifive_l2_cache-c/20220615-202528 > git checkout 49c4086768b5aff410a4a19ca740f8ae8e211844 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.3.0 make.cros= s W=3D1 O=3Dbuild_dir ARCH=3Driscv SHELL=3D/bin/bash drivers/soc/ > >If you fix the issue, kindly add following tag where applicable >Reported-by: kernel test robot > Thanks for this report, now I make a new patch and add "Reported-by: kernel= test robot " >All errors (new ones prefixed by >>): > > drivers/soc/sifive/sifive_l2_cache.c: In function 'sifive_l2_init': >>> drivers/soc/sifive/sifive_l2_cache.c:224:17: error: expected ';' before= 'goto' > 224 | goto out_put; > | ^~~~ > > Thanks for all your effort to improve the patch. --===============8223046376005270586==--