From: "plaisthos (Code Review)" Date: Tue, 13 Jan 2026 11:54:16 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3e872e95fa262c4511a28f1033a238a791c1b340-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1ns57BDCGFg="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: socket: Remove old "dynamic remote" feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --1ns57BDCGFg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by flichtenheld. ( http://gerr= it.openvpn.net/c/openvpn/+/1468?usp=3Demail ) Change subject: socket: Remove old "dynamic remote" feature ...................................................................... Patch Set 1: (1 comment) File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/1468/comment/fb901cf9_6dc32792?usp=3D= email : PS1, Line 923: if (ai && !addrlist_match(&remote_verify, ai)) Doesn't this also break the part without dynamic reresolving remote? I woul= d expect also a change to options.c to disallow --remote with tcp-server. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1468?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0141945469dd11340bfb42ec37a3c5f90ed0ff52 Gerrit-Change-Number: 1468 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 13 Jan 2026 11:54:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --1ns57BDCGFg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

1 comment:

    =
  • File src/openvpn/socket.c:

    • Patch Set #1, = Line 923: i= f (ai && !addrlist_match(&remote_verify, ai))

      Doesn&= #39;t this also break the part without dynamic reresolving remote? I would = expect also a change to options.c to disallow --remote with tcp-server.

      =

To view, visit change 1468. To unsubscribe, or for help = writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0141945469dd11340bfb42ec37a= 3c5f90ed0ff52
Gerrit-Change-Number: 1468
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 13 Jan 2026 11:54:16= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --1ns57BDCGFg=--