Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68841C43381 for ; Mon, 1 Apr 2019 15:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33875208E4 for ; Mon, 1 Apr 2019 15:14:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qscu0578" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbfDAPOq (ORCPT ); Mon, 1 Apr 2019 11:14:46 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40901 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfDAPOq (ORCPT ); Mon, 1 Apr 2019 11:14:46 -0400 Received: by mail-pf1-f195.google.com with SMTP id c207so4726843pfc.7 for ; Mon, 01 Apr 2019 08:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Nyzt0MgwZfTCqy5lc2APVfmqZWZhU5xsxYywemtIFCs=; b=Qscu0578v99x48wApOlvLxXTfUwW6o6nsqwxoN34DOX2GxTVzMdH9mpqu1u2pTPHzg OiXi1KGT0RHOUUfz8qmeV+BX1m40ART2ow9R5EkbLOmuPMuDXlE3tnKEGknGc1dIvCjP OwBiwvEOhxPjz6U0XKaf26pnvLjVQJbmXZEL5Wq5/lxTsVtS7SBjjplVd2pOQvERGTOo 14mWE/JXIQlgIqC8ri0H1x0Z4Vb7xG5m6+GnTxsKgnGdOmDasaXi7Nmwep+fUnspdSlG UiHTzpeH5ggSqkHzKSwmRzf1KgcRvlf1MZSUDhG+hqCXXxFlzKwLf63GbWqB2cRqws0E jV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nyzt0MgwZfTCqy5lc2APVfmqZWZhU5xsxYywemtIFCs=; b=W+Wbx4ZGQ0MBrpKgLFpKAw0s41eRiLRc22z6lBP4o7WjWthKKrT2iy55xxFCezONVs /GMGUlm1nNBwzHc2StQn5gJoWjrc4Uxt8hPMiBrnLeOGZT+EWyWmS92avEjqxqwz1/3z L7c9Mw+SyjOv3FYZDEaBEwM1HLamRmOJvyGpq3PPQc9p49UDgAL51rv1I/a5wcvcI/DF 2Ulr5ERf0jwHlJ3wgs9PQXe96qNOSi7vZ2SWMS6PpDeO8rQ6yTVVfPyxRZ5XeOWwuh3F Ql0w7rF37D1YKxztj3fSLnUA/ac6T/GRiPQ0rmKGr6Ms75cfstl55ogS4F1y+l5qbN61 FvDg== X-Gm-Message-State: APjAAAXbOz7espe1aE8T/tYhGNH+NolLpDVCxs86vtkTUfmHeJI6hrt8 FimA8ZFG1agMcpR9ivCinTPs4EQ8 X-Google-Smtp-Source: APXvYqw7d8LkFXDuiChMgNUh3IJUUpZcOLE5we5Fg+RYb3Lp6gvVIZdVeQYqlJllx0irtwT5RGbY3A== X-Received: by 2002:a63:2c4c:: with SMTP id s73mr62367780pgs.113.1554131685323; Mon, 01 Apr 2019 08:14:45 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:e4e1:a8b:a839:26ca? ([2601:282:800:fd80:e4e1:a8b:a839:26ca]) by smtp.googlemail.com with ESMTPSA id j6sm14037392pfe.107.2019.04.01.08.14.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 08:14:43 -0700 (PDT) Subject: Re: [PATCH net,v3] vrf: check accept_source_route on the original netdevice To: Stephen Suryaputra , netdev@vger.kernel.org References: <20190401131732.22887-1-ssuryaextr@gmail.com> From: David Ahern Message-ID: <3e8c85ab-9b9f-e862-2a54-9030a8be6f31@gmail.com> Date: Mon, 1 Apr 2019 09:14:42 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190401131732.22887-1-ssuryaextr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/1/19 7:17 AM, Stephen Suryaputra wrote: > Configuration check to accept source route IP options should be made on > the incoming netdevice when the skb->dev is an l3mdev master. The route > lookup for the source route next hop also needs the incoming netdev. > > v2->v3: > - Simplify by passing the original netdevice down the stack (per David > Ahern). > > Signed-off-by: Stephen Suryaputra > --- > include/net/ip.h | 2 +- > net/ipv4/ip_input.c | 7 +++---- > net/ipv4/ip_options.c | 4 ++-- > 3 files changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: David Ahern