From: Dhinakaran Pandiyan Subject: Re: [PATCH v5 8/9] drm/i915: Force PSR exit when getting pipe CRC Date: Thu, 07 Mar 2019 14:30:36 -0800 Message-ID: <3ef74586d2c40e8972bc8d9ecac86df33df630a2.camel@intel.com> References: <20190306064728.8234-1-jose.souza@intel.com> <20190306064728.8234-8-jose.souza@intel.com> <6cd70d243fc064614da94f838e04e08d2325cf2c.camel@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4099B6E231 for ; Thu, 7 Mar 2019 22:30:42 +0000 (UTC) In-Reply-To: <6cd70d243fc064614da94f838e04e08d2325cf2c.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE5LTAzLTA3IGF0IDEzOjU3IC0wODAwLCBTb3V6YSwgSm9zZSB3cm90ZToKPiBP biBUaHUsIDIwMTktMDMtMDcgYXQgMTM6MjUgLTA4MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4gd3Jv dGU6Cj4gPiBPbiBUdWUsIDIwMTktMDMtMDUgYXQgMjI6NDcgLTA4MDAsIEpvc8OpIFJvYmVydG8g ZGUgU291emEgd3JvdGU6Cj4gPiA+IElmIFBTUiBpcyBhY3RpdmUgd2hlbiBwaXBlIENSQyBpcyBl bmFibGVkIHRoZSBDUkMgY2FsY3VsYXRpb25zCj4gPiA+IHdpbGwKPiA+ID4gYmUgaW5oaWJpdCBi eSB0aGUgdHJhbnNpdGlvbiB0byBsb3cgcG93ZXIgc3RhdGVzIHRoYXQgUFNSIGJyaW5ncy4KPiA+ IAo+ID4gVGhlIE1NSU8gd3JpdGUgdG8gZW5hYmxlIENSQ3Mgc2hvdWxkIGJyaW5nIHRoZSBoYXJk d2FyZSBvdXQgZnJvbQo+ID4gUFNSLAo+ID4gYnV0IEkgY2FuIGltYWdpbmUgc29tZSBpbml0aWFs IENSQ3MgIGFyZSBnb2luZyB0byBiZSBjb3JydXB0IG9yCj4gPiB1bmF2YWlsYWJsZS4KPiAKPiBU aGF0IGRvIG5vdCBoYXBwZW4sIGlmIFBTUiBpcyBhY3RpdmUgYW5kIENSQyBpcyBjb25maWd1cmVk IFBTUiB3aWxsCj4gcmVtYWluIGFjdGl2ZSBhbmQgbm8gQ1JDIHdpbGwgYmUgY2FsY3VsYXRlZC4K Ck9kZCwgTU1JTyB3cml0ZXMgc2hvdWxkIHRyaWdnZXIgREM2IGV4aXQsIHdoaWNoIGFsd2F5cyBy ZXN1bHRzIGluIFBTUgpleGl0LiBJZiB0aGUgaGFyZHdhcmUgaXNudCd0IGluIERDNiwgdGhlbiBJ IGNhbiBpbWFnaW5lIENSQyBlbmFibGluZwpub3QgY2F1c2luZyBhIFBTUiBleGl0LiAKPiAKPiA+ IAo+ID4gPiBTbyBsZXRzIGZvciBhIFBTUiBleGl0IGFuZCBhcyBzb29uIGFzIHBpcGUgQ1JDIGlz IGVuYWJsZWQgaXQgd2lsbAo+ID4gCj4gPiBUaGVyZSBpcyBhIG1pc3Npbmcgd29yZC4KPiAKPiBU aGFua3MKPiAKPiAiU28gbGV0cyBmb3JjZSBhIFBTUiBleGl0IGFuZCBhcyBzb29uIGFzIHBpcGUg Q1JDIGlzIGVuYWJsZWQgaXQgd2lsbAo+IGJsb2NrIFBTUiBhY3RpdmF0aW9uIGFuZCBhdm9pZCBD UkMgdGltZW91dHMgd2hlbiBydW5uaW5nIElHVCB0ZXN0cy4iCj4gCj4gCj4gPiAKPiA+ID4gYmxv Y2sgUFNSIGFjdGl2YXRpb24gYXZvaWQgQ1JDIHRpbWVvdXRzIHdoZW4gcnVubmluZyBJR1QgdGVz dHMuCj4gPiAKPiA+IFRoaXMgc3VyZWx5IGhhcyBmZG8gYnVncywgcGxlYXNlIGluY2x1ZGUgdGhl bSBpbiB0aGUgY29tbWl0Cj4gPiBtZXNzYWdlLgo+IAo+IEkgZGlkIHRoaXMgcGF0Y2ggYmVjYXVz ZSBvZiB0aGUgcmVncmVzc2lvbnMgdGhhdCBJIGdvdCBmcm9tIENJIGluIG15Cj4gdGVzdGluZ3Ms IApDYW4geW91IGluY2x1ZGUgdGhlIHRlc3QgbmFtZSBhbmQgcGxhdGZvcm0gaW4gdGhlIGNvbW1p dCBtZXNzYWdlPwoKPiB0aGUgb25seSBidWcgdGhhdCBJIGZvdW5kIHJlbGF0ZWQgaXMgCj4gaHR0 cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3ODE0IGJ1dCB3ZSBk b24ndCBoYXZlCj4gUFNSIGVuYWJsZWQgYnkgZGVmYXVsdCBvbiBIU1cuCgpKYW5pIFMgaGFkIHJl cG9ydGVkIHRoZSBpc3N1ZSwgQ2MnaW5nIGhpbS4KCj4gCj4gPiA+IENjOiBEaGluYWthcmFuIFBh bmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+ID4gQ2M6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYt Ynk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+ID4gPiAt LS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgMzYgKysrKysrKysr KysrKysrKysrKystLS0tCj4gPiA+IC0tLS0KPiA+ID4gLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5n ZWQsIDIzIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gaW5kZXggZDNlMzk5NjU1MWM2Li41ZDY2ZTcz MTNjNzUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+IEBAIC00 NTIsNiArNDUyLDcgQEAgc3RhdGljIHZvaWQgaHN3X2FjdGl2YXRlX3BzcjEoc3RydWN0IGludGVs X2RwCj4gPiA+ICppbnRlbF9kcCkKPiA+ID4gIAkgKiBmcmFtZXMsIHdlJ2xsIGdvIHdpdGggOSBm cmFtZXMgZm9yIG5vdwo+ID4gPiAgCSAqLwo+ID4gPiAgCWlkbGVfZnJhbWVzID0gbWF4KGlkbGVf ZnJhbWVzLCBkZXZfcHJpdi0+cHNyLnNpbmtfc3luY19sYXRlbmN5Cj4gPiA+ICsgMSk7Cj4gPiA+ ICsKPiA+ID4gIAl2YWwgfD0gaWRsZV9mcmFtZXMgPDwgRURQX1BTUl9JRExFX0ZSQU1FX1NISUZU Owo+ID4gPiAgCj4gPiA+ICAJdmFsIHw9IG1heF9zbGVlcF90aW1lIDw8IEVEUF9QU1JfTUFYX1NM RUVQX1RJTUVfU0hJRlQ7Cj4gPiA+IEBAIC04NTEsNiArODUyLDIwIEBAIHZvaWQgaW50ZWxfcHNy X2Rpc2FibGUoc3RydWN0IGludGVsX2RwCj4gPiA+ICppbnRlbF9kcCwKPiA+ID4gIAljYW5jZWxf d29ya19zeW5jKCZkZXZfcHJpdi0+cHNyLndvcmspOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtz dGF0aWMgdm9pZCBwc3JfZm9yY2VfaHdfdHJhY2tpbmdfZXhpdChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZQo+ID4gPiAqZGV2X3ByaXYpCj4gPiA+ICt7Cj4gPiA+ICsJLyoKPiA+ID4gKwkgKiBEaXNw bGF5IFdBICMwODg0OiBhbGwKPiA+ID4gKwkgKiBUaGlzIGRvY3VtZW50ZWQgV0EgZm9yIGJ4dCBj YW4gYmUgc2FmZWx5IGFwcGxpZWQKPiA+ID4gKwkgKiBicm9hZGx5IHNvIHdlIGNhbiBmb3JjZSBI VyB0cmFja2luZyB0byBleGl0IFBTUgo+ID4gPiArCSAqIGluc3RlYWQgb2YgZGlzYWJsaW5nIGFu ZCByZS1lbmFibGluZy4KPiA+ID4gKwkgKiBXb3JrYXJvdW5kIHRlbGxzIHVzIHRvIHdyaXRlIDAg dG8gQ1VSX1NVUkZMSVZFX0EsCj4gPiA+ICsJICogYnV0IGl0IG1ha2VzIG1vcmUgc2Vuc2Ugd3Jp dGUgdG8gdGhlIGN1cnJlbnQgYWN0aXZlCj4gPiA+ICsJICogcGlwZS4KPiA+ID4gKwkgKi8KPiA+ ID4gKwlJOTE1X1dSSVRFKENVUlNVUkZMSVZFKGRldl9wcml2LT5wc3IucGlwZSksIDApOwo+ID4g PiArfQo+ID4gPiArCj4gPiA+ICAvKioKPiA+ID4gICAqIGludGVsX3Bzcl91cGRhdGUgLSBVcGRh dGUgUFNSIHN0YXRlCj4gPiA+ICAgKiBAaW50ZWxfZHA6IEludGVsIERQCj4gPiA+IEBAIC04NzUs OCArODkwLDEzIEBAIHZvaWQgaW50ZWxfcHNyX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfZHAKPiA+ID4g KmludGVsX2RwLAo+ID4gPiAgCWVuYWJsZSA9IGNydGNfc3RhdGUtPmhhc19wc3IgJiYgcHNyX2ds b2JhbF9lbmFibGVkKHBzci0+ZGVidWcpOwo+ID4gPiAgCXBzcjJfZW5hYmxlID0gaW50ZWxfcHNy Ml9lbmFibGVkKGRldl9wcml2LCBjcnRjX3N0YXRlKTsKPiA+ID4gIAo+ID4gPiAtCWlmIChlbmFi bGUgPT0gcHNyLT5lbmFibGVkICYmIHBzcjJfZW5hYmxlID09IHBzci0+cHNyMl9lbmFibGVkKQo+ ID4gPiArCWlmIChlbmFibGUgPT0gcHNyLT5lbmFibGVkICYmIHBzcjJfZW5hYmxlID09IHBzci0K PiA+ID4gPiBwc3IyX2VuYWJsZWQpIAo+ID4gPiAKPiA+ID4gewo+ID4gCj4gPiBQU1IyIGlzIGVu YWJsZWQsIHRoZW4gdXNlciByZXF1ZXN0cyBDUkNzLCB0aGUgbW9kZV9jaGFuZ2VkIGNvbW1pdAo+ ID4gc3dpdGNoZXMgdG8gUFNSMS4gVGhlIGFib3ZlIGNvbmRpdGlvbiBpc24ndCB0cnVlIGluIHRo YXQgY2FzZS4KPiAKPiBOb3Qgc3VyZSBpZiBJIHVuZGVyc3Rvb2QgdGhlIHF1ZXN0aW9uIGJ1dCBp ZiBQU1IyIGlzIGVuYWJsZWQgYW5kIHVzZXIKPiByZXF1ZXN0IENSQyBpdCB3aWxsIHN3aXRjaCB0 byBQU1IxIGFscmVhZHkgZm9yY2luZyBhIFBTUiBleGl0IHNvIHdlCj4gZG9uJ3QgbmVlZCB0byBj YWxsIHBzcl9mb3JjZV9od190cmFja2luZ19leGl0KCkgaW4gdGhpcyBjYXNlLgpUaGUgUFNSMi0+ UFNSMSBzd2l0Y2hpbmcgZ2l2ZXMgdXMgdGhlIHNhbWUgd2luZG93IGJlZm9yZSBDUkMgZW5hYmxp bmcKYXMgZm9yY2VfaHdfdHJhY2tpbmdfZXhpdCgpLiBNeSBxdWVzdGlvbiB3YXMgYWJvdXQgaWYg dGhhdCB3aW5kb3cgaXMKc3VmZmljaWVudC4KPiAKPiA+IAo+ID4gQWxzbywgc2luY2UgdGhlIENS QyB3b3JrYXJvdW5kIGlzIGRvbmUgYmVmb3JlIGVuYWJsaW5nIHBpcGUgQ1JDLAo+ID4gaXNuJ3QK PiA+IHRoZXJlIGEgcG9zc2liaWxpdHkgdGhhdCB0aGUgaWRsZSBmcmFtZSBjb3VudGVyIHRpbWVz IG91dCBhbmQKPiA+IGFjdGl2YXRlcwo+ID4gUFNSMSBiZWZvcmUgQ1JDIGlzIGVuYWJsZWQ/Cj4g Cj4gVGhlcmUgc3RpbGwgdGhlIHBvc3NpYmlsaXR5IHNpbmNlIHN5c2NhbGxzIGNhbiBiZSBwcmVl bXB0ZWQgdG9vIGJ1dAo+IHRoaXMgaXMgYSBodWdlIGltcHJvdmVtZW50IG92ZXIgY3VycmVudCBz Y2VuYXJpbywgbm93IGl0IHdpbGwgZ2l2ZSBhdAo+IGxlYXN0IHRoZSB0aW1lIG9mIDYgaWRsZSBm cmFtZXMgYmV0d2Vlbgo+IGludGVsX2NydGNfY3JjX3NldHVwX3dvcmthcm91bmRzKCkgYW5kIHRo ZSBJOTE1X1dSSVRFKCkgdG8gdGhlIFBJUEUKPiBDUkMKPiByZWdpc3RlcnMgYW5kIGl0IGhhcHBl bnMgcmlnaHQgYWZ0ZXIKPiBpbnRlbF9jcnRjX2NyY19zZXR1cF93b3JrYXJvdW5kcygpCj4gcmV0 dXJucy4KClllYWgsIGl0IHNob3VsZCBiZSBva2F5LiBQbGVhc2UgZG9jdW1lbnQgaW4gdGhlIGNv bW1pdCBtZXNzYWdlIHRoZSBpZGVhCmlzIHRoYXQgd2UgcmVseSBvbiB0aGUgaWRsZSBmcmFtZSBj b3VudGVyIHRvIGhhdmUgbm90IGV4cGlyZWQgYmVmb3JlCkNSQyBpcyBlbmFibGVkIGFuZCB3ZSBh cmUgb25seSBraWNraW5nIHRoZSBoYXJkd2FyZSBvdXQgb2YgUFNSMS4gU2luY2UKd2hhdCB0aGlz IHBhdGNoIGRvZXMgaXMgZGlmZmVyZW50IGZyb20gd2hhdCBwc3JfZXhpdCgpIGltcGxlbWVudHMs IEkKdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8gY2xhcmlmeSB3aGF0IGV4aXQgbWVhbnMuCgpXaXRo IHRoZSBjb21taXQgbWVzc2FnZSBmaXhlZCwgdGhpcyBsb29rcyBva2F5IHRvIG1lIGJ1dCBsZXQn cyBzZWUgaWYKdGhlIHRpbWVvdXRzIGdvIGF3YXkuCgpSZXZpZXdlZC1ieTogRGhpbmFrYXJhbiBQ YW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cgo+IAo+ID4gCj4gPiA+ICsJ CS8qIEZvcmNlIGEgUFNSIGV4aXQgd2hlbiBlbmFibGluZyBDUkMgdG8gYXZvaWQgQ1JDCj4gPiA+ IHRpbWVvdXRzICovCj4gPiA+ICsJCWlmIChjcnRjX3N0YXRlLT5jcmNfZW5hYmxlZCAmJiBwc3It PmVuYWJsZWQpCj4gPiA+ICsJCQlwc3JfZm9yY2VfaHdfdHJhY2tpbmdfZXhpdChkZXZfcHJpdik7 Cj4gPiAKPiA+IFRoZSBwYXRjaCBmaXhlcyBhIFBTUjEgaXNzdWUsIHdoeSBpc24ndCB0aGVyZSBh bnkgcmVmZXJlbmNlIHRvIFBTUjEKPiA+IGFueXdoZXJlPwo+IAo+IGZhaXIsIGdvaW5nIHRvIHVw ZGF0ZSB0aGUgY29tbWl0IG1lc3NhZ2UuCj4gCj4gPiAKPiA+IAo+ID4gPiArCj4gPiA+ICAJCWdv dG8gdW5sb2NrOwo+ID4gPiArCX0KPiA+ID4gIAo+ID4gPiAgCWlmIChwc3ItPmVuYWJsZWQpCj4g PiA+ICAJCWludGVsX3Bzcl9kaXNhYmxlX2xvY2tlZChpbnRlbF9kcCk7Cj4gPiA+IEBAIC0xMTQ2 LDE4ICsxMTY2LDggQEAgdm9pZCBpbnRlbF9wc3JfZmx1c2goc3RydWN0Cj4gPiA+IGRybV9pOTE1 X3ByaXZhdGUKPiA+ID4gKmRldl9wcml2LAo+ID4gPiAgCWRldl9wcml2LT5wc3IuYnVzeV9mcm9u dGJ1ZmZlcl9iaXRzICY9IH5mcm9udGJ1ZmZlcl9iaXRzOwo+ID4gPiAgCj4gPiA+ICAJLyogQnkg ZGVmaW5pdGlvbiBmbHVzaCA9IGludmFsaWRhdGUgKyBmbHVzaCAqLwo+ID4gPiAtCWlmIChmcm9u dGJ1ZmZlcl9iaXRzKSB7Cj4gPiA+IC0JCS8qCj4gPiA+IC0JCSAqIERpc3BsYXkgV0EgIzA4ODQ6 IGFsbAo+ID4gPiAtCQkgKiBUaGlzIGRvY3VtZW50ZWQgV0EgZm9yIGJ4dCBjYW4gYmUgc2FmZWx5 IGFwcGxpZWQKPiA+ID4gLQkJICogYnJvYWRseSBzbyB3ZSBjYW4gZm9yY2UgSFcgdHJhY2tpbmcg dG8gZXhpdCBQU1IKPiA+ID4gLQkJICogaW5zdGVhZCBvZiBkaXNhYmxpbmcgYW5kIHJlLWVuYWJs aW5nLgo+ID4gPiAtCQkgKiBXb3JrYXJvdW5kIHRlbGxzIHVzIHRvIHdyaXRlIDAgdG8gQ1VSX1NV UkZMSVZFX0EsCj4gPiA+IC0JCSAqIGJ1dCBpdCBtYWtlcyBtb3JlIHNlbnNlIHdyaXRlIHRvIHRo ZSBjdXJyZW50IGFjdGl2ZQo+ID4gPiAtCQkgKiBwaXBlLgo+ID4gPiAtCQkgKi8KPiA+ID4gLQkJ STkxNV9XUklURShDVVJTVVJGTElWRShkZXZfcHJpdi0+cHNyLnBpcGUpLCAwKTsKPiA+ID4gLQl9 Cj4gPiA+ICsJaWYgKGZyb250YnVmZmVyX2JpdHMpCj4gPiA+ICsJCXBzcl9mb3JjZV9od190cmFj a2luZ19leGl0KGRldl9wcml2KTsKPiA+ID4gIAo+ID4gPiAgCWlmICghZGV2X3ByaXYtPnBzci5h Y3RpdmUgJiYgIWRldl9wcml2LQo+ID4gPiA+IHBzci5idXN5X2Zyb250YnVmZmVyX2JpdHMpCj4g PiA+IAo+ID4gPiAgCQlzY2hlZHVsZV93b3JrKCZkZXZfcHJpdi0+cHNyLndvcmspOwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4