From: "comododragon (Code Review)" Date: Wed, 25 Jun 2025 11:23:47 +0000 In-Reply-To: References: Reply-To: rein.vanbaaren@...1435..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <3efe0485c9b6b744a3673813133624c64797e4c2-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="yIYf/zn8VDo="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Added PQE to WolfSSL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --yIYf/zn8VDo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: comododragon, cron2, flichtenheld. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=3Demail to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by cron2 Change subject: Added PQE to WolfSSL ...................................................................... Added PQE to WolfSSL Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 --- M README.wolfssl M src/openvpn/ssl_openssl.c 2 files changed, 25 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1046/4 diff --git a/README.wolfssl b/README.wolfssl index a5dfe31..46b080c 100644 --- a/README.wolfssl +++ b/README.wolfssl @@ -28,3 +28,26 @@ * blowfish support (BF-CBC), you must use something like cipher AES-128-CBC to avoid trying to use BF-CBC * Windows CryptoAPI support + +************************************************************************* +To build WolfSSL with support for post-quantum KEMs, the following command= is used: + +./configure --enable-openvpn --enable-kyber=3Dall --enable-curve25519 + +WolfSSL supports the following post-quantum KEMs or post-quantum hybrid KE= Ms by specifying them using the `tls-groups` +option in an OpenVPN config. + +ML_KEM_512 +ML_KEM_768 +ML_KEM_1024 + +P256_ML_KEM_512 +X25519_ML_KEM_512 + +P384_ML_KEM_768 +P256_ML_KEM_768 +X448_ML_KEM_768 +X25519_ML_KEM_768 + +P384_ML_KEM_1024 +P521_ML_KEM_1024 diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 2fc77d8..ec5419c 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -560,7 +560,7 @@ tls_ctx_set_tls_groups(struct tls_root_ctx *ctx, const char *groups) { ASSERT(ctx); -#if OPENSSL_VERSION_NUMBER < 0x30000000L +#if OPENSSL_VERSION_NUMBER < 0x30000000L && !defined(ENABLE_CRYPTO_WOLFSSL) struct gc_arena gc =3D gc_new(); /* This method could be as easy as * SSL_CTX_set1_groups_list(ctx->ctx, groups) @@ -608,6 +608,7 @@ } gc_free(&gc); #else /* if OPENSSL_VERSION_NUMBER < 0x30000000L */ + msg(M_WARN, "Hells yeah"); if (!SSL_CTX_set1_groups_list(ctx->ctx, groups)) { crypto_msg(M_FATAL, "Failed to set allowed TLS group list: %s", -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 Gerrit-Change-Number: 1046 Gerrit-PatchSet: 4 Gerrit-Owner: comododragon Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: comododragon Gerrit-MessageType: newpatchset --yIYf/zn8VDo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: comododragon, cron2, flichtenheld= .

comododragon uploaded patch set #4 to this change.

<= p>View C= hange

The following approvals got outdated and were removed: Code-Review-1 by cron2

Added PQE to WolfSSL

Change-Id: Ie0529c207496= 4b3be034f01e0ef53090a6edbd35
---
M README.wolfssl
M src/openvpn/ss= l_openssl.c
2 files changed, 25 insertions(+), 1 deletion(-)

g=
it pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1046/4
=
diff --git a/README.wolfssl b/README.wolfssl
index a5dfe= 31..46b080c 100644
--- a/README.wolfssl
+++= b/README.wolfssl
@@ -28,3 +28,26 @@
* bl= owfish support (BF-CBC), you must use something like
ci= pher AES-128-CBC to avoid trying to use BF-CBC
* Windows = CryptoAPI support
+
+*********************= ****************************************************
+To build WolfSSL with support for post-qu= antum KEMs, the following command is used:
+
+./configure --enable-openvpn --enable-kyber=3Dall --enable-curve25519
+
+WolfSSL supports the following post-quan= tum KEMs or post-quantum hybrid KEMs by specifying them using the `tls-grou= ps`
+option in an Op= enVPN config.
+
+ML_KEM_512
+ML_KEM_768

+ML_KEM_1024
+
+P256_ML_KEM_512
= +
+P384_ML_KEM_768
+P256_ML_KEM_768=
+X448_ML_KEM_768
= +X25519_ML_KEM_768
+

+P384_ML_KEM_1024
+P521_ML_KEM_1024
diff --git a/src/open= vpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c
index 2fc77d8= ..ec5419c 100644
--- a/src/openvpn/ssl_openssl.c
= +++ b/src/openvpn/ssl_openssl.c
@@ -560,7 +560,7 @@
tls_ctx_set_tls_groups(struct tls_root_ctx *ctx, const char= *groups)
{
ASSERT(ctx);
-#if OPENSSL_VERSION_NUMBER < 0x= 30000000L

+#if OPENSS= L_VERSION_NUMBER < 0x30000000L && !defined(ENABLE_CRYPTO_WOLFSSL= )
struct gc_arena gc =3D gc_new();
= /* This method could be as easy as
* SSL_CTX_set1_= groups_list(ctx->ctx, groups)
@@ -608,6 +608,7 @@=
}
gc_free(&gc);
#e= lse /* if OPENSSL_VERSION_NUMBER < 0x30000000L */
+ msg(M_WARN, "Hells yeah");<= /span>
if (!SSL_CTX_set1_groups_list(ctx->ctx, groups))
{
crypto_msg(M_FATAL, "Fai= led to set allowed TLS group list: %s",

To view, visit change 1046. To unsubscribe, or for help writing mail filt= ers, visit settings.

=
<= meta itemprop=3D"name" content=3D"View Change"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef= 53090a6edbd35
Gerrit-Change-Number: 1046
Gerrit-PatchSet: 4
Gerrit-Owner: comododragon <rein.vanbaaren@= ...1435...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: comododragon <rein.vanbaa= ren@...1435...>
Gerrit-MessageType: newpatchset
--yIYf/zn8VDo=--