From: "flichtenheld (Code Review)"
Date: Fri, 6 Mar 2026 14:01:48 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <3f153dc654a2513ae6a7eadd689e42369bd306c0-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="HUNW5ahx9xA="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Optimise iterating
over all clients by remembering highest peer id
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--HUNW5ahx9xA=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerr=
it.openvpn.net/c/openvpn/+/1557?usp=3Demail )
Change subject: Optimise iterating over all clients by remembering highest =
peer id
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/openvpn/multi.h:
http://gerrit.openvpn.net/c/openvpn/+/1557/comment/cefa47db_0826c6d4?usp=3D=
email :
PS3, Line 166: uint32_t max_peerid; /**< currently highes=
t allocated peerid and
"highest currently"
File src/openvpn/multi.c:
http://gerrit.openvpn.net/c/openvpn/+/1557/comment/aa64aaec_78ffb9f4?usp=3D=
email :
PS1, Line 4109: if (mi->context.c2.tls_multi->peer_id > m->max_peerid)
> done
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1557?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5484bfb38f05c3
Gerrit-Change-Number: 1557
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Fri, 06 Mar 2026 14:01:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: flichtenheld
--HUNW5ahx9xA=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: plaisthos.
Patch set 3:Code-Review +2=
V=
iew Change
2 comments:
File src/openvpn/multi.h:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set =
#3, Line 166: uint3=
2_t max_peerid; /**< currently highest allocated peerid an=
d
"highest currently"
File src/openvpn/multi.c:
Done
To view, visit change 1557. To uns=
ubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If797f3fe178fba3f43fb12898e5=
484bfb38f05c3
Gerrit-Change-Number: 1557
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Fri, 06 Mar 2026 14:01:48=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
=
--HUNW5ahx9xA=--