From: "flichtenheld (Code Review)" Date: Wed, 1 Apr 2026 15:35:04 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <3fb4cf8671614f82d58ff4a23a3f5ebd3c21a646-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="HuELbuJNyNs="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: OpenSSL 4.0: Make X509 objects const List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --HuELbuJNyNs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1596?usp=3Demail ) Change subject: OpenSSL 4.0: Make X509 objects const ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1596/comment/857f427a_70a62c1a?usp=3D= email : PS4, Line 496: int i =3D X509_NAME_get_index_by_NID(x50= 9_name, xt->nid, -1); This line still fails on OpenSSL 1.1 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1596?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iea1d13c160599f134587c6f1c2f4a90e7f5e3991 Gerrit-Change-Number: 1596 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 01 Apr 2026 15:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --HuELbuJNyNs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

Patch set 4:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/ssl_verify_ope= nssl.c:

    • Patch Set #4, Line 496: int i =3D X509_NAME_get_index_by_NID(x509_name, xt-&= gt;nid, -1);

      This line still fails on OpenSSL 1.1

    <= /li>

To view, visit change 1596. To unsubscribe, or for help writing mai= l filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iea1d13c160599f134587c6f1c2f= 4a90e7f5e3991
Gerrit-Change-Number: 1596
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 15:35:04= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --HuELbuJNyNs=--