Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rLj4Q0M2nzDqjr for ; Fri, 3 Jun 2016 21:47:02 +1000 (AEST) In-Reply-To: <566929FA.2050409@linux.vnet.ibm.com> To: xinhui , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: Andrzej Hajda , Christophe Jaillet , Hari Bathini , Paul Mackerras , tglx@linutronix.de, Nathan Fontenot Subject: Re: powerpc/nvram: Fix an incorrect partition merge Message-Id: <3rLj4P6Swcz9t6B@ozlabs.org> Date: Fri, 3 Jun 2016 21:47:01 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake now. > > Also use memset instead of strncpy to set the partition's name. It's > more readable if we want to fill up with duplicate chars . Does this ever happen in practice? ie. should we backport the fix to stable kernels? Has it always been broken? cheers