From: Fengguang Wu Subject: [PATCH 10/13] writeback: introduce queue_dirty() Date: Tue, 15 Jan 2008 20:36:47 +0800 Message-ID: <400401294.29514@ustc.edu.cn> References: <20080115123637.518924046@mail.ustc.edu.cn> Cc: Michael Rubin , Peter Zijlstra To: Andrew Morton Return-path: Received: from smtp.ustc.edu.cn ([202.38.64.16]:48384 "HELO ustc.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1753121AbYAOMsa (ORCPT ); Tue, 15 Jan 2008 07:48:30 -0500 Message-Id: <20080115124801.800688912@mail.ustc.edu.cn> Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org Content-Disposition: inline; filename=writeback-queue_dirty.patch Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Introduce queue_dirty() to enqueue a newly dirtied inode. It helps remove duplicate code. Cc: Michael Rubin Cc: Peter Zijlstra Signed-off-by: Fengguang Wu --- fs/fs-writeback.c | 21 +++++++++++++-------- 1 files changed, 13 insertions(+), 8 deletions(-) --- linux-mm.orig/fs/fs-writeback.c +++ linux-mm/fs/fs-writeback.c @@ -25,6 +25,15 @@ #include #include "internal.h" +/* + * Enqueue a newly dirtied inode. + */ +static void queue_dirty(struct inode *inode) +{ + inode->dirtied_when = jiffies; + list_move(&inode->i_list, &inode->i_sb->s_dirty); +} + /** * __mark_inode_dirty - internal function * @inode: inode to mark @@ -122,10 +131,8 @@ void __mark_inode_dirty(struct inode *in * If the inode was already on s_dirty/s_io/s_more_io, don't * reposition it (that would break s_dirty time-ordering). */ - if (!was_dirty) { - inode->dirtied_when = jiffies; - list_move(&inode->i_list, &sb->s_dirty); - } + if (!was_dirty) + queue_dirty(inode); } out: spin_unlock(&inode_lock); @@ -445,10 +452,8 @@ int generic_sync_sb_inodes(struct super_ err = __writeback_single_inode(inode, wbc); if (!ret) ret = err; - if (wbc->sync_mode == WB_SYNC_HOLD) { - inode->dirtied_when = jiffies; - list_move(&inode->i_list, &sb->s_dirty); - } + if (wbc->sync_mode == WB_SYNC_HOLD) + queue_dirty(inode); if (current_is_pdflush()) writeback_release(bdi); if (wbc->pages_skipped != pages_skipped) { --