Content-Type: multipart/mixed; boundary="===============4482200098616486431==" MIME-Version: 1.0 From: David Howells To: kbuild-all@lists.01.org Subject: Re: [dhowells-fs:rxrpc-next 2/3] net/rxrpc/conn_client.c:494:1-7: preceding lock on line 471 (fwd) Date: Tue, 29 Sep 2020 22:05:04 +0100 Message-ID: <403541.1601413504@warthog.procyon.org.uk> In-Reply-To: List-Id: --===============4482200098616486431== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Julia Lawall wrote: > Does the spin lock taken on line 471 need to be released in the !usable > case? rxrpc_add_conn_to_bundle() releases the lock. It's marked with __releases = so the checker shouldn't complain. I wanted to put the manipulation of bundle->alloc_conn together - which meant moving out that lock release. > The return on line 494 also looks odd for a void function. At one point they were both int, but it doesn't really matter - gcc is fine with it. It does have the advantage that if one of them changes return typ= e, this will cause a complaint if the other isn't also changed. David --===============4482200098616486431==--