From: Andres Rodriguez Subject: Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence Date: Mon, 13 Aug 2018 10:33:08 -0400 Message-ID: <40bb865b-2eff-7075-43b9-456896b1d043@gmail.com> References: <1533711936-22450-1-git-send-email-ray.huang@amd.com> <91ac6260-1f17-12a9-80e9-50d78756bb87@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <91ac6260-1f17-12a9-80e9-50d78756bb87-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Huang Rui , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Nayan Deshmukh , andresx7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org QW55IHVwZGF0ZXMgb24gdGhpcyBpc3N1ZT8KClJlZ2FyZHMsCkFuZHJlcwoKT24gMjAxOC0wOC0w OCAwMzoxMCBBTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBZZWFoIHRoYXQgaXMgYSBrbm93 biBpc3N1ZSwgYnV0IHRoaXMgc29sdXRpb24gaXMgbm90IGNvcnJlY3QgZWl0aGVyLgo+IAo+IFNl ZSB0aGUgc2NoZWR1bGVyIHdoZXJlIHRoZSBqb2IgaXMgZXhlY3V0ZSBvbiBpcyBzaW1wbHkgbm90 IGRldGVybWluZWQgCj4geWV0IHdoZW4gd2Ugd2FudCB0byB0cmFjZSBpdC4KPiAKPiBTbyB1c2lu ZyB0aGUgc2NoZWR1bGVyIG5hbWUgZnJvbSB0aGUgZW50aXR5IGlzIHdyb25nIGFzIHdlbGwuCj4g Cj4gV2Ugc2hvdWxkIHByb2JhYmx5IG1vdmUgdGhlIHJlc2NoZWR1bGUgZnJvbSBkcm1fc2NoZWRf ZW50aXR5X3B1c2hfam9iKCkgCj4gdG8gZHJtX3NjaGVkX2pvYl9pbml0KCkgdG8gZml4IHRoYXQu Cj4gCj4gSSB3aWxsIHByZXBhcmUgYSBwYXRjaCBmb3IgdGhhdCB0b2RheSwKPiBDaHJpc3RpYW4u Cj4gCj4gQW0gMDguMDguMjAxOCB1bSAwOTowNSBzY2hyaWViIEh1YW5nIFJ1aToKPj4gV2Ugd29u J3QgaW5pdGlhbGl6ZSBmZW5jZSBzY2hlZHVsZXIgaW4gZHJtX3NjaGVkX2ZlbmNlX2NyZWF0ZSgp IAo+PiBhbnltb3JlLCBzbyBpdAo+PiB3aWxsIHJlZmVyIG51bGwgZmVuY2Ugc2NoZWR1bGVyIGlm IG9wZW4gdHJhY2UgZXZlbnQgdG8gZ2V0IHRoZSAKPj4gdGltZWxpbmUgbmFtZS4KPj4gQWN0dWFs bHksIGl0IGlzIHRoZSBzY2hlZHVsZXIgbmFtZSBmcm9tIHRoZSBlbnRpdHksIHNvIGFkZCBhIG1h Y3JvIHRvIAo+PiByZXBsYWNlCj4+IGxlZ2FjeSBnZXR0aW5nIHRpbWVsaW5lIG5hbWUgYnkgam9i Lgo+Pgo+PiBbwqAgMjEyLjg0NDI4MV0gQlVHOiB1bmFibGUgdG8gaGFuZGxlIGtlcm5lbCBOVUxM IHBvaW50ZXIgZGVyZWZlcmVuY2UgCj4+IGF0IDAwMDAwMDAwMDAwMDAwMTgKPj4gW8KgIDIxMi44 NTI0MDFdIFBHRCA4MDAwMDAwNDI3YzEzMDY3IFA0RCA4MDAwMDAwNDI3YzEzMDY3IFBVRCA0MjM1 ZmMwNjcgCj4+IFBNRCAwCj4+IFvCoCAyMTIuODU5NDE5XSBPb3BzOiAwMDAwIFsjMV0gU01QIFBU SQo+PiBbwqAgMjEyLjg2Mjk4MV0gQ1BVOiA0IFBJRDogMTUyMCBDb21tOiBhbWRncHVfdGVzdCBU YWludGVkOiBHICAgICAgICAgICAKPj4gT0XCoMKgwqDCoCA0LjE4LjAtcmMxLWN1c3RvbSAjMQo+ PiBbwqAgMjEyLjg3MjE5NF0gSGFyZHdhcmUgbmFtZTogR2lnYWJ5dGUgVGVjaG5vbG9neSBDby4s IEx0ZC4gCj4+IFoxNzBYUC1TTEkvWjE3MFhQLVNMSS1DRiwgQklPUyBGMjAgMTEvMDQvMjAxNgo+ PiBbwqAgMjEyLjg4MTcwNF0gUklQOiAwMDEwOmRybV9zY2hlZF9mZW5jZV9nZXRfdGltZWxpbmVf bmFtZSsweDJiLzB4MzAgCj4+IFtncHVfc2NoZWRdCj4+IFvCoCAyMTIuODg4OTQ4XSBDb2RlOiAx ZiA0NCAwMCAwMCA0OCA4YiA0NyAwOCA0OCAzZCBjMCBiMSA0ZiBjMCA3NCAxMyAKPj4gNDggODMg ZWYgNjAgNDggM2QgNjAgYjEgNGYgYzAgYjggMDAgMDAgMDAgMDAgNDggMGYgNDUgZjggNDggOGIg ODcgZTAgCj4+IDAwIDAwIDAwIDw0OD4gOGIgNDAgMTggYzMgMGYgMWYgNDQgMDAgMDAgYjggMDEg MDAgMDAgMDAgYzMgMGYgMWYgNDQgMDAgCj4+IDAwIDBmCj4+IFvCoCAyMTIuOTA4MTYyXSBSU1A6 IDAwMTg6ZmZmZmEzZWQ4MWYyN2FmMCBFRkxBR1M6IDAwMDEwMjQ2Cj4+IFvCoCAyMTIuOTEzNDgz XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiAwMDAwMDAwMDAwMDcwMDM0IFJDWDogCj4+IGZm ZmZhM2VkODFmMjdkYTgKPj4gW8KgIDIxMi45MjA3MzVdIFJEWDogZmZmZjhmMjRlYmZiNTQ2MCBS U0k6IGZmZmY4ZjI0ZTQwZDNjMDAgUkRJOiAKPj4gZmZmZjhmMjRlYmZiNTQwMAo+PiBbwqAgMjEy LjkyODAwOF0gUkJQOiBmZmZmOGYyNGU0MGQzYzAwIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6 IAo+PiBmZmZmZmZmZmFlNGRlYWZjCj4+IFvCoCAyMTIuOTM1MjYzXSBSMTA6IGZmZmZmZmZmYWRh MDAwZWQgUjExOiAwMDAwMDAwMDAwMDAwMDAxIFIxMjogCj4+IGZmZmY4ZjI0ZTg5MWY4OTgKPj4g W8KgIDIxMi45NDI1NThdIFIxMzogMDAwMDAwMDAwMDAwMDAwMCBSMTQ6IGZmZmY4ZjI0ZWJjNDYw MDAgUjE1OiAKPj4gZmZmZjhmMjRlM2RlOTdhOAo+PiBbwqAgMjEyLjk0OTc5Nl0gRlM6wqAgMDAw MDdmZmZmN2ZkMjcwMCgwMDAwKSBHUzpmZmZmOGYyNGZlZDAwMDAwKDAwMDApIAo+PiBrbmxHUzow MDAwMDAwMDAwMDAwMDAwCj4+IFvCoCAyMTIuOTU4MDQ3XSBDUzrCoCAwMDEwIERTOiAwMDAwIEVT OiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwo+PiBbwqAgMjEyLjk2MzkyMV0gQ1IyOiAwMDAw MDAwMDAwMDAwMDE4IENSMzogMDAwMDAwMDQyMzQyMjAwMyBDUjQ6IAo+PiAwMDAwMDAwMDAwMzYw NmUwCj4+IFvCoCAyMTIuOTcxMjAxXSBEUjA6IDAwMDAwMDAwMDAwMDAwMDAgRFIxOiAwMDAwMDAw MDAwMDAwMDAwIERSMjogCj4+IDAwMDAwMDAwMDAwMDAwMDAKPj4gW8KgIDIxMi45Nzg0ODJdIERS MzogMDAwMDAwMDAwMDAwMDAwMCBEUjY6IDAwMDAwMDAwZmZmZTBmZjAgRFI3OiAKPj4gMDAwMDAw MDAwMDAwMDQwMAo+PiBbwqAgMjEyLjk4NTcyMF0gQ2FsbCBUcmFjZToKPj4gW8KgIDIxMi45ODgy MzZdwqAgdHJhY2VfZXZlbnRfcmF3X2V2ZW50X2FtZGdwdV9jc19pb2N0bCsweDRjLzB4MTcwIFth bWRncHVdCj4+IFvCoCAyMTIuOTk0OTA0XcKgID8gYW1kZ3B1X2N0eF9hZGRfZmVuY2UrMHhhOS8w eDExMCBbYW1kZ3B1XQo+PiBbwqAgMjEzLjAwMDI0Nl3CoCA/IGFtZGdwdV9qb2JfZnJlZV9yZXNv dXJjZXMrMHg0Yi8weDcwIFthbWRncHVdCj4+IFvCoCAyMTMuMDA1OTQ0XcKgIGFtZGdwdV9jc19p b2N0bCsweDE2ZDEvMHgxYjUwIFthbWRncHVdCj4+IFvCoCAyMTMuMDEwOTIwXcKgID8gYW1kZ3B1 X2NzX2ZpbmRfbWFwcGluZysweGYwLzB4ZjAgW2FtZGdwdV0KPj4gW8KgIDIxMy4wMTYzNTRdwqAg ZHJtX2lvY3RsX2tlcm5lbCsweDhhLzB4ZDAgW2RybV0KPj4gW8KgIDIxMy4wMjA3OTRdwqAgPyBy ZWNhbGNfc2lncGVuZGluZysweDE3LzB4NTAKPj4gW8KgIDIxMy4wMjQ5NjVdwqAgZHJtX2lvY3Rs KzB4MmQ3LzB4MzkwIFtkcm1dCj4+IFvCoCAyMTMuMDI4OTc5XcKgID8gYW1kZ3B1X2NzX2ZpbmRf bWFwcGluZysweGYwLzB4ZjAgW2FtZGdwdV0KPj4gW8KgIDIxMy4wMzQzNjZdwqAgPyBkb19zaWdu YWwrMHgzNi8weDcwMAo+PiBbwqAgMjEzLjAzNzkyOF3CoCA/IHNpZ25hbF93YWtlX3VwX3N0YXRl KzB4MTUvMHgzMAo+PiBbwqAgMjEzLjA0MjM3NV3CoCBhbWRncHVfZHJtX2lvY3RsKzB4NDYvMHg4 MCBbYW1kZ3B1XQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBIdWFuZyBSdWkgPHJheS5odWFuZ0BhbWQu Y29tPgo+PiAtLS0KPj4gwqAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmPC oMKgwqAgfMKgIDIgKy0KPj4gwqAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Ry YWNlLmggfCAxMCArKysrKystLS0tCj4+IMKgIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspLCA1IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2NzLmMgCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2NzLmMKPj4gaW5kZXggZTEyODcxZC4uYmUwMWUxYiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2NzLmMKPj4gQEAgLTEyNDcsNyArMTI0Nyw3IEBAIHN0YXRpYyBp bnQgYW1kZ3B1X2NzX3N1Ym1pdChzdHJ1Y3QgCj4+IGFtZGdwdV9jc19wYXJzZXIgKnAsCj4+IMKg wqDCoMKgwqAgYW1kZ3B1X2pvYl9mcmVlX3Jlc291cmNlcyhqb2IpOwo+PiAtwqDCoMKgIHRyYWNl X2FtZGdwdV9jc19pb2N0bChqb2IpOwo+PiArwqDCoMKgIHRyYWNlX2FtZGdwdV9jc19pb2N0bChq b2IsIGVudGl0eSk7Cj4+IMKgwqDCoMKgwqAgYW1kZ3B1X3ZtX2JvX3RyYWNlX2NzKCZmcHJpdi0+ dm0sICZwLT50aWNrZXQpOwo+PiDCoMKgwqDCoMKgIHByaW9yaXR5ID0gam9iLT5iYXNlLnNfcHJp b3JpdHk7Cj4+IMKgwqDCoMKgwqAgZHJtX3NjaGVkX2VudGl0eV9wdXNoX2pvYigmam9iLT5iYXNl LCBlbnRpdHkpOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3RyYWNlLmggCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3RyYWNl LmgKPj4gaW5kZXggOGMyZGFiMi4uMjVjZGNiNyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3RyYWNlLmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3RyYWNlLmgKPj4gQEAgLTM2LDYgKzM2LDggQEAKPj4gwqAgI2RlZmlu ZSBBTURHUFVfSk9CX0dFVF9USU1FTElORV9OQU1FKGpvYikgXAo+PiAgICAgICAgCj4+IGpvYi0+ YmFzZS5zX2ZlbmNlLT5maW5pc2hlZC5vcHMtPmdldF90aW1lbGluZV9uYW1lKCZqb2ItPmJhc2Uu c19mZW5jZS0+ZmluaXNoZWQpIAo+Pgo+PiArI2RlZmluZSBBTURHUFVfR0VUX1NDSEVEX05BTUUo ZW50aXR5KSBcCj4+ICvCoMKgwqDCoCAoZW50aXR5LT5ycS0+c2NoZWQtPm5hbWUpCj4+IMKgIFRS QUNFX0VWRU5UKGFtZGdwdV9tbV9ycmVnLAo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgVFBfUFJPVE8o dW5zaWduZWQgZGlkLCB1aW50MzJfdCByZWcsIHVpbnQzMl90IHZhbHVlKSwKPj4gQEAgLTE2MSwx MSArMTYzLDExIEBAIFRSQUNFX0VWRU5UKGFtZGdwdV9jcywKPj4gwqAgKTsKPj4gwqAgVFJBQ0Vf RVZFTlQoYW1kZ3B1X2NzX2lvY3RsLAo+PiAtwqDCoMKgwqDCoMKgwqAgVFBfUFJPVE8oc3RydWN0 IGFtZGdwdV9qb2IgKmpvYiksCj4+IC3CoMKgwqDCoMKgwqDCoCBUUF9BUkdTKGpvYiksCj4+ICvC oMKgwqDCoMKgwqDCoCBUUF9QUk9UTyhzdHJ1Y3QgYW1kZ3B1X2pvYiAqam9iLCBzdHJ1Y3QgZHJt X3NjaGVkX2VudGl0eSAKPj4gKmVudGl0eSksCj4+ICvCoMKgwqDCoMKgwqDCoCBUUF9BUkdTKGpv YiwgZW50aXR5KSwKPj4gwqDCoMKgwqDCoMKgwqDCoMKgIFRQX1NUUlVDVF9fZW50cnkoCj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX2ZpZWxkKHVpbnQ2NF90LCBzY2hl ZF9qb2JfaWQpCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX3N0cmluZyh0 aW1lbGluZSwgQU1ER1BVX0pPQl9HRVRfVElNRUxJTkVfTkFNRShqb2IpKQo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19zdHJpbmcodGltZWxpbmUsIEFNREdQVV9HRVRfU0NI RURfTkFNRShlbnRpdHkpKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg X19maWVsZCh1bnNpZ25lZCBpbnQsIGNvbnRleHQpCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBfX2ZpZWxkKHVuc2lnbmVkIGludCwgc2Vxbm8pCj4+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX2ZpZWxkKHN0cnVjdCBkbWFfZmVuY2UgKiwgZmVu Y2UpCj4+IEBAIC0xNzUsNyArMTc3LDcgQEAgVFJBQ0VfRVZFTlQoYW1kZ3B1X2NzX2lvY3RsLAo+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgVFBfZmFzdF9hc3NpZ24oCj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIF9fZW50cnktPnNjaGVkX2pvYl9pZCA9IGpvYi0+YmFzZS5pZDsKPj4g LcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19hc3NpZ25fc3RyKHRpbWVsaW5lLCBBTURH UFVfSk9CX0dFVF9USU1FTElORV9OQU1FKGpvYikpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIF9fYXNzaWduX3N0cih0aW1lbGluZSwgQU1ER1BVX0dFVF9TQ0hFRF9OQU1FKGVudGl0 eSkpCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9fZW50cnktPmNvbnRleHQg PSBqb2ItPmJhc2Uuc19mZW5jZS0+ZmluaXNoZWQuY29udGV4dDsKPj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgX19lbnRyeS0+c2Vxbm8gPSBqb2ItPmJhc2Uuc19mZW5jZS0+Zmlu aXNoZWQuc2Vxbm87Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9fZW50cnkt PnJpbmdfbmFtZSA9IAo+PiB0b19hbWRncHVfcmluZyhqb2ItPmJhc2Uuc2NoZWQpLT5uYW1lOwo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1k LWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK