From: "plaisthos (Code Review)" Date: Wed, 21 Jan 2026 13:04:01 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., steffan@...1856..., max@...2606... Message-ID: <40c664ed5069a73a6c1601798c2ff0bcc6e7ace8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="j8UaAF4UHk4="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: flichtenheld , syzzer , openvpn-devel --j8UaAF4UHk4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, syzzer. plaisthos has posted comments on this change by MaxF. ( http://gerrit.openv= pn.net/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 5: (1 comment) File src/openvpn/ssl_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/46ea0c7e_a2445a5e?usp=3D= email : PS5, Line 610: { /Users/arne/oss/openvpn-git/src/openvpn/ssl_mbedtls.c:609:1: error: unused = function 'external_pkcs1_sign' [-Werror,-Wunused-function] 609 | external_pkcs1_sign(void *ctx_voidptr, int (*f_rng)(void *, unsigne= d char *, size_t), void *p_rng, And I do not see this function being used anywhere. Please double check t= his with Werror. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 5 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: MaxF Gerrit-Comment-Date: Wed, 21 Jan 2026 13:04:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --j8UaAF4UHk4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, syzzer.

View = Change

1 comment:

    =
  • File src/openvpn/ssl_mbedtls.c:

    =
    • Patch Set= #5, Line 610: {=

      /Users/arne/oss/openvpn-git/src/openvpn/ssl_mbedtls.c:609=
      :1: error: unused function 'external_pkcs1_sign' [-Werror,-Wunused-=
      function]
      609 | external_pkcs1_sign(void *ctx_voidptr, int (*f_rng)(vo= id *, unsigned char *, size_t), void *p_rng,

      And I do not see th= is function being used anywhere. Please double check this with Werror.

To view, visit change 1441. To unsubscribe, or for help= writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 5
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Wed, 21 Jan 2026 13:04:01= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --j8UaAF4UHk4=--