Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC7ABC02194 for ; Tue, 4 Feb 2025 14:24:52 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.881604.1291753 (Exim 4.92) (envelope-from ) id 1tfJqy-0003y7-8G; Tue, 04 Feb 2025 14:24:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 881604.1291753; Tue, 04 Feb 2025 14:24:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tfJqy-0003y0-5d; Tue, 04 Feb 2025 14:24:40 +0000 Received: by outflank-mailman (input) for mailman id 881604; Tue, 04 Feb 2025 14:24:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tfJqw-0003xu-TU for xen-devel@lists.xenproject.org; Tue, 04 Feb 2025 14:24:38 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3846d98-e303-11ef-a0e7-8be0dac302b0; Tue, 04 Feb 2025 15:24:37 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab74ecfdae4so85990466b.2 for ; Tue, 04 Feb 2025 06:24:37 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e49ff3e4sm929136166b.110.2025.02.04.06.24.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 06:24:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3846d98-e303-11ef-a0e7-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738679077; x=1739283877; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kGOH/+gidU4S4CZb1/BQ1WRQYhcTL6AdF2t2ovH+mC8=; b=XJcTn69g7Ue+WUWjryRbapb1AMsQJPbXzAD1SETzmVFLmCzc3Kzs8CoYXBE+AnsJAc 5oFOWK3RKsAOBgFfSm/YHTJCnAAL4J0Twnscl2D96ZP9VSC19ahHsYRmmNH119sMq8yr NgsVc22WvvlGAe6SVS13u29EpngI/+dAzXu9RXX37pzjoegwrZCImITJycQiq1TcuBW4 8ArVqInV7aeFwPOYZdbuWshqW+8PEqJYefTQwhwr0xXRi6p2ay318pzTBiOuq4Tk6fbS 0bk+uIjUyK3RiHYwWM4z8hoCyaYQYXiNFc96ZyN6Xoep6nKwNfeX3crPA9xivlgEyeeP ZGYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738679077; x=1739283877; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kGOH/+gidU4S4CZb1/BQ1WRQYhcTL6AdF2t2ovH+mC8=; b=QpdLZlWdv1ByNCt4Bklbp2KHj90WC21kcU+7cKhbE/0Nzepa8lgdc41QFZRvzIGWBu Jyt6R1Ot06XYv4VJhXiaQmJnhCt+z1AJiSSvb2cUGa9iDove5XwcFk9ymXwRcaCaisH2 27lWiMYNnR5Q70eDtHrfY1vay3VshsQi2p4H85inPsW+J4rQtWQzeY2rJHEgctajSjA8 TCdzd8YC1jVWU/Orqk4X3PoCTsg7dwSaQKB12DIgg5fnSgnT/UC6ZR+YM4Rs/3DRDhI3 RmHc/zbVwwE3iIT20JLurIL3bo6J551R42Q0cZxMAk3u2CNeUKkBGcGoEdUwBz03ixfm XxPw== X-Forwarded-Encrypted: i=1; AJvYcCV7XUD4sQ4m9bKjcEOmujoeq4vKW6cK6hXUIFhYGAWT6Ma//JBCEcZvOTw16Zs5ox4tTBsvtZoVDF8=@lists.xenproject.org X-Gm-Message-State: AOJu0YzcTccfmHI86fya6NQvTx33+VMnUyp4RLEObhaMtPxiS8DFh+qi Oc2zA1zEmyGy3loh9kcEi69Ah0CeluNFYGhPO6bJew4BXgNTHPAgnoxXwDRsXA== X-Gm-Gg: ASbGncux/Ot9rYL/i2INd0HDGr4OefM36nGRop5JWYxSb99/PmlSmhFiAwuU0r3yFNq syUlvyIzYuB8IZZJ8Z0VTwQPXFfxohUaNfwEM7W52nKODBDnrh2bLYSVaFDnC7lKfsJzOtiSj1L SN5krR0zn9BIgRK2wAXJSUaQYXXNey9uZtVToFxFGEMgF0ZP6DOI07sFtRjji+u9auRReFW/2ka CfNxkAXU0kIN2x4tG0MCX+cLIMRCP04CAc4/SFp7gOUnIAMN17EjXtl0ZxBUnVlcc5/arIajauv uZkGQsUPHZgg1qdPlHMaxAaXgNQJXoFr56psBhlNosQ9SmssnkWlt+/pr2xv3jvl2+kaBVgq8s5 g X-Google-Smtp-Source: AGHT+IFtrQCP27E/lLbkg/IvxK+aQE5rcSFcjt2Hpjqk0M6+4qUv6JmclnG+eMKq3X3sEpvVAFOZzg== X-Received: by 2002:a17:907:3f11:b0:ab2:d721:ed92 with SMTP id a640c23a62f3a-ab6cfdbe5a4mr2755558166b.45.1738679077071; Tue, 04 Feb 2025 06:24:37 -0800 (PST) Message-ID: <41070eff-4db7-4e4f-a953-1bb2d3a88523@suse.com> Date: Tue, 4 Feb 2025 15:24:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/8] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API To: Mykyta Poturai Cc: Stewart Hildebrand , Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , "xen-devel@lists.xenproject.org" References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04.02.2025 14:54, Mykyta Poturai wrote: > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include Please insert where the other xen/ #include-s are. (Those aren't sorted yet, so there is more than one place where you could reasonably put it. I'd recommend ahead of xen/errno.h.) > @@ -241,8 +244,31 @@ int iommu_remove_dt_device(struct dt_device_node *np); > /* Error code for reporting no IOMMU is present */ > #define NO_IOMMU 1 > > +#else /* !HAS_DEVICE_TREE */ > +static inline int iommu_add_dt_pci_sideband_ids(struct pci_dev *pdev) > +{ > + return -ENOSYS; No abuse of ENOSYS please. EOPNOTSUPP if nothing better can be found. > +} > + > #endif /* HAS_DEVICE_TREE */ > > +#ifdef CONFIG_HAS_PCI > +static inline int iommu_add_pci_sideband_ids(struct pci_dev *pdev) From its name it's unclear whether the function actually means to alter the passed in pdev (my initial guess was that it wouldn't, but the call tree from iommu_add_dt_pci_sideband_ids() is getting deep-ish). If not, the parameter should be pointer-to-const. > +{ > + int ret = -ENOSYS; > + > + if ( acpi_disabled ) > + ret = iommu_add_dt_pci_sideband_ids(pdev); > + > + return ret; > +} > +#else /* !HAS_PCI */ > +static inline int iommu_add_pci_sideband_ids(struct pci_dev *pdev) > +{ > + return -ENOSYS; > +} > +#endif Why the redundancy? static inline int iommu_add_pci_sideband_ids(struct pci_dev *pdev) { int ret = -EOPNOTSUPP; #ifdef CONFIG_HAS_PCI if ( acpi_disabled ) ret = iommu_add_dt_pci_sideband_ids(pdev); #endif return ret; } Jan