Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049FF1AF0AE for ; Fri, 25 Apr 2025 06:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745562790; cv=none; b=gLMAYlfhEke22G/ytyL5skYpQVqrEhkNXuXC6rp10fKXbhorm8y65P1QeLXZJUKEgDtw+NiWtvcMaCT9ZnnAS0mzCIC8HIvJYXtNUsi4dilEOFH9Tm+3W/HKhZHNrYf9GcAyeUu7g8zzqsKJT06rgss4nMD1wKEolmefi/hFp+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745562790; c=relaxed/simple; bh=m/x3yczNtLY9RWR3J8jv8FFFFejj3xXitfHmQtI10wE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J7aqURsc18HgtJiNcorzzQLpqzs/6xZqIan7/1r1pgQfw7r++JzcBIKHz3NmVAulnumxsMiMrvVPsF6kOPQzl0CUTVNkicwxm0vCcqmhLzsGHGnqcS/Enp1Ykgrt4/Vw7KiZD9giePNZauImnjCmYpsV8GTbtdICQP1RDecfGyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RNJ8oQrF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=k6dhj0Fe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=RNJ8oQrF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=k6dhj0Fe; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RNJ8oQrF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="k6dhj0Fe"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RNJ8oQrF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="k6dhj0Fe" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 293471F38C; Fri, 25 Apr 2025 06:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745562787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUaO8+GyTClsNNWkUQStpc4gPOE4WOgM7XeKdan5AYk=; b=RNJ8oQrFTQh1sVTkJSnKhA98M44KtqYbL2UocZUDCQlQUqpInTnXpOb7l8hdS6urOXBrge LrCMBkqLL5uNViCg+cDl5ClVI7FBRt65apGfe8Z2w8dwfoBlmBfIrd40jQL4iE3TcAbRg0 1ZIvdxBNeLbRrIW+pve7AZjRpCfCH0I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745562787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUaO8+GyTClsNNWkUQStpc4gPOE4WOgM7XeKdan5AYk=; b=k6dhj0Fe7N9xzXm0hnR3u3GXo5Dl98C2k6s5UPuiKsQXypkx64MsY4NbNcfrPGlWZyKbvn 98J1kmem39/zF8BQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RNJ8oQrF; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k6dhj0Fe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745562787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUaO8+GyTClsNNWkUQStpc4gPOE4WOgM7XeKdan5AYk=; b=RNJ8oQrFTQh1sVTkJSnKhA98M44KtqYbL2UocZUDCQlQUqpInTnXpOb7l8hdS6urOXBrge LrCMBkqLL5uNViCg+cDl5ClVI7FBRt65apGfe8Z2w8dwfoBlmBfIrd40jQL4iE3TcAbRg0 1ZIvdxBNeLbRrIW+pve7AZjRpCfCH0I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745562787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUaO8+GyTClsNNWkUQStpc4gPOE4WOgM7XeKdan5AYk=; b=k6dhj0Fe7N9xzXm0hnR3u3GXo5Dl98C2k6s5UPuiKsQXypkx64MsY4NbNcfrPGlWZyKbvn 98J1kmem39/zF8BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D49D213A80; Fri, 25 Apr 2025 06:33:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vbAyMqIsC2hIYAAAD6G6ig (envelope-from ); Fri, 25 Apr 2025 06:33:06 +0000 Message-ID: <4138efdc-0b06-4465-89df-31ff8ba81230@suse.de> Date: Fri, 25 Apr 2025 08:33:06 +0200 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 07/20] block: prevent adding/deleting disk during updating nr_hw_queues To: Ming Lei , Jens Axboe , linux-block@vger.kernel.org Cc: Nilay Shroff , Shinichiro Kawasaki , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Christoph Hellwig References: <20250424152148.1066220-1-ming.lei@redhat.com> <20250424152148.1066220-8-ming.lei@redhat.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250424152148.1066220-8-ming.lei@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 293471F38C X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Level: On 4/24/25 17:21, Ming Lei wrote: > Both adding/deleting disk code are reader of `nr_hw_queues`, so we can't > allow them in-progress when updating nr_hw_queues, kernel panic and > kasan has been reported in [1]. > > Prevent adding/deleting disk during updating nr_hw_queues by adding > rw_semaphore to tagset, write lock is grabbed in blk_mq_update_nr_hw_queues(), > and read lock is acquired when adding/deleting disk. > > Also mark GFP_NOIO allocation scope for adding/deleting disk because > blk_mq_update_nr_hw_queues() is part of some driver's error handler. > > This way avoids lot of trouble. > > Suggested-by: Nilay Shroff > Reported-by: Nilay Shroff > Closes: https://lore.kernel.org/linux-block/a5896cdb-a59a-4a37-9f99-20522f5d2987@linux.ibm.com/ > Signed-off-by: Ming Lei > --- > block/blk-mq.c | 4 ++ > block/genhd.c | 94 +++++++++++++++++++++++++++++++----------- > include/linux/blk-mq.h | 3 ++ > 3 files changed, 78 insertions(+), 23 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich