From: Boris Derzhavets Subject: Re: [PATCH] fs-backend: fix compile problems Date: Wed, 18 Mar 2009 07:53:45 -0700 (PDT) Message-ID: <413918.19320.qm@web56108.mail.re3.yahoo.com> References: <54599.39242.qm@web56101.mail.re3.yahoo.com> Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0012059586==" Return-path: In-Reply-To: <54599.39242.qm@web56101.mail.re3.yahoo.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org --===============0012059586== Content-Type: multipart/alternative; boundary="0-916289210-1237388025=:19320" --0-916289210-1237388025=:19320 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Now "make install-xen" fails :- make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mche= ck' gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-st= rict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wde= claration-after-statement=C2=A0 -nostdinc -fno-builtin -fno-common -iwithpr= efix include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xe= n/include=C2=A0 -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic= -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -= fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchrono= us-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno= -omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_i= ntel.c -o mce_intel.o mce_intel.c:17: error: static declaration of =E2=80=98firstbank=E2=80=99 fo= llows non-static declaration x86_mca.h:95: error: previous declaration of =E2=80=98firstbank=E2=80=99 wa= s here make[6]: *** [mce_intel.o] Error 1 make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mchec= k' make[5]: *** [mcheck/built_in.o] Error 2 make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu' make[4]: *** [cpu/built_in.o] Error 2 make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2 make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2 make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen' make[1]: *** [install] Error 2 make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen' make: *** [install-xen] Error 2 --- On Wed, 3/18/09, Boris Derzhavets wrote: From: Boris Derzhavets Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "Stefano Stabellini" Cc: "xen-devel" Date: Wednesday, March 18, 2009, 10:48 AM Thank you. It's done Boris --- On Wed, 3/18/09, Stefano Stabellini = wrote: From: Stefano Stabellini Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "bderzhavets@yahoo.com" Cc: "xen-devel" Date: Wednesday, March 18, 2009, 10:19 AM Boris Derzhavets wrote: > Removed unresolved reference in > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference > to `pci_emulation_add' >=20 > /* for (i =3D 0; i < nb_pci_emulation; i++) { > if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { > fprintf(stderr, "Warning: could not add PCI device %s\n", > pci_emulation_config_text[i]); > } > } > */ >=20 > "make tools" completed OK. > Is it acceptable ? >=20 I think we are missing an ifdef CONFIG_PASSTHROUGH diff --git a/vl.c b/vl.c index 9b9f7d5..6c0ffb3 100644 --- a/vl.c +++ b/vl.c @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) } } =20 +#ifdef CONFIG_PASSTHROUGH for (i =3D 0; i < nb_pci_emulation; i++) { if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { fprintf(stderr, "Warning: could not add PCI device %s\n", pci_emulation_config_text[i]); } } +#endif =20 if (strlen(direct_pci_str) > 0) direct_pci =3D direct_pci_str; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel =0A=0A=0A --0-916289210-1237388025=:19320 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Now "make install-xen" fails :-

make[6= ]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck'gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-s= trict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wd= eclaration-after-statement  -nostdinc -fno-builtin -fno-common -iwithp= refix include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/x= en/include  -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generi= c -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float = -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchron= ous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fn= o-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_= intel.c -o mce_intel.o
mce_intel.c:17: error: static declaration of =E2=80=98firstbank=E2=80=99 follows non-static declaration
x86_mca.h:95= : error: previous declaration of =E2=80=98firstbank=E2=80=99 was here
ma= ke[6]: *** [mce_intel.o] Error 1
make[6]: Leaving directory `/usr/src/xe= n-unstable.hg/xen/arch/x86/cpu/mcheck'
make[5]: *** [mcheck/built_in.o] = Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x8= 6/cpu'
make[4]: *** [cpu/built_in.o] Error 2
make[4]: Leaving directo= ry `/usr/src/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/usr/src/xen-un= stable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/= usr/src/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/usr/src/xen-unstabl= e.hg/xen/xen] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.= hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/u= sr/src/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


-= -- On Wed, 3/18/09, Boris Derzhavets <bderzhavets@yahoo.com> wrote:
From: Boris Derzhavets <bderzhavets@= yahoo.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile p= roblems
To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>= ;
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Wednesd= ay, March 18, 2009, 10:48 AM

Thank you. It's= done
Boris

--- On Wed, 3/18/09, Stefano Stabellini <ste= fano.stabellini@eu.citrix.com> wrote:
Cc: "xen-devel" <xen-devel@l= ists.xensource.com>
Date: Wednesday, March 18, 2009, 10:19 AM

=
Boris Derzhavets wrote:

> Removed unresolved reference in> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined referen= ce
> to `pci_emulation_add'
>
> /* for (i =3D 0; i &l= t; nb_pci_emulation; i++) {
> if(pci_emulation_add(pci_emulat= ion_config_text[i]) < 0)
{
> fprintf(stderr, "Warn= ing: could not add PCI device
%s\n",
> pci_emu= lation_config_text[i]);
> }
> }
> */
> =
> "make tools" completed OK.
> Is it acceptable ?
>
=


I think we are missing an ifdef CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6= c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int ma= in(int argc, char **argv, char **envp)
}
}

+#if= def CONFIG_PASSTHROUGH
for (i =3D 0; i < nb_pci_emulation; i++) = {
if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {<= br> fprintf(stderr, "Warning: could not add PCI device
%s\n"= ,
pci_emulation_config_text[i]);
}
= }
+#endif

if (strlen(direct_pci_str) > 0)
= direct_pci =3D
direct_pci_str;

_______________________________= ________________
Xen-devel mailing list
Xen-devel@lists.xensource.com=
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-dev= el mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.= com/xen-devel

=0A=0A=0A=0A = --0-916289210-1237388025=:19320-- --===============0012059586== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0012059586==--