Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E10A7A for ; Wed, 29 Jun 2022 11:57:57 +0000 (UTC) Received: from fraeml739-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LY0Lr1xbbz67yhs; Wed, 29 Jun 2022 19:57:08 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml739-chm.china.huawei.com (10.206.15.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 13:57:53 +0200 Received: from [10.195.245.77] (10.195.245.77) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 12:57:52 +0100 Message-ID: <416ebe33-28ed-eef0-0001-83efd83a9d0f@huawei.com> Date: Wed, 29 Jun 2022 12:57:54 +0100 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 1/5] dma-mapping: Add dma_opt_mapping_size() To: Robin Murphy CC: , , , , , , , , , , , , , References: <1656343521-62897-1-git-send-email-john.garry@huawei.com> <1656343521-62897-2-git-send-email-john.garry@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.195.245.77] X-ClientProxiedBy: lhreml751-chm.china.huawei.com (10.201.108.201) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Message-ID: <20220629115754.DnfCpPqC3bthqnYc7sMrN2McG2kjGE4N7bKcsS1Dn6k@z> On 28/06/2022 12:27, John Garry via iommu wrote: > On 28/06/2022 12:23, Robin Murphy wrote: >>> + >>> +    size_t >>> +    dma_opt_mapping_size(struct device *dev); >>> + >>> +Returns the maximum optimal size of a mapping for the device. >>> Mapping large >>> +buffers may take longer so device drivers are advised to limit total >>> DMA >>> +streaming mappings length to the returned value. >> >> Nit: I'm not sure "advised" is necessarily the right thing to say in >> general - that's only really true for a caller who cares about >> throughput of churning through short-lived mappings more than anything >> else, and doesn't take a significant hit overall from splitting up >> larger requests. I do think it's good to clarify the exact context of >> "optimal" here, but I'd prefer to be objectively clear that it's for >> workloads where the up-front mapping overhead dominates. > I'm going to go with something like this: size_t dma_opt_mapping_size(struct device *dev); Returns the maximum optimal size of a mapping for the device. Mapping larger buffers may take much longer in certain scenarios. In addition, for high-rate short-lived streaming mappings the upfront time spent on the mapping may account for an appreciable part of the total request lifetime. As such, if splitting larger requests incurs no significant performance penalty, then device drivers are advised to limit total DMA streaming mappings length to the returned value. Let me know if you would like it further amended. Cheers, John