From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: only enable swiotlb alloc when need Date: Wed, 7 Feb 2018 13:21:44 +0100 Message-ID: <4185de64-4035-ce60-9ef4-45872ba7cd90@gmail.com> References: <20180207110445.14077-1-david1.zhou@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180207110445.14077-1-david1.zhou-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Chunming Zhou , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org QW0gMDcuMDIuMjAxOCB1bSAxMjowNCBzY2hyaWViIENodW5taW5nIFpob3U6Cj4gZ2V0IHRoZSBt YXggaW8gbWFwcGluZyBhZGRyZXNzIG9mIHN5c3RlbSBtZW1vcnkgdG8gc2VlIGlmIGl0IGlzIG92 ZXIKPiBvdXIgY2FyZCBhY2Nlc3NpbmcgcmFuZ2UuCj4KPiBDaGFuZ2UtSWQ6IEliYzM4ZGJkMzRh MjBhZjViNGE0YjFlZDE1NGMxNGUxYzU4YWE0YzU1Cj4gU2lnbmVkLW9mZi1ieTogQ2h1bm1pbmcg WmhvdSA8ZGF2aWQxLnpob3VAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdS5oICAgICAgICB8ICAzICsrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2RldmljZS5jIHwgMTQgKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyAgICB8ICA2ICsrKy0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y2XzAuYyAgICAgIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvZ21jX3Y3XzAuYyAgICAgIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvZ21jX3Y4XzAuYyAgICAgIHwgIDEgKwo+ICAgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvZ21jX3Y5XzAuYyAgICAgIHwgIDEgKwo+ICAgNyBmaWxlcyBjaGFuZ2VkLCAyNCBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1LmgKPiBpbmRleCAyNTc0MjRkZDhhNTIuLjM0YTY4MTRlOTRmOSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gQEAgLTE0MzcsNiArMTQzNyw3IEBAIHN0cnVjdCBhbWRn cHVfZGV2aWNlIHsKPiAgIAljb25zdCBzdHJ1Y3QgYW1kZ3B1X2FzaWNfZnVuY3MJKmFzaWNfZnVu Y3M7Cj4gICAJYm9vbAkJCQlzaHV0ZG93bjsKPiAgIAlib29sCQkJCW5lZWRfZG1hMzI7Cj4gKwli b29sCQkJCW5lZWRfc3dpb3RsYjsKPiAgIAlib29sCQkJCWFjY2VsX3dvcmtpbmc7Cj4gICAJc3Ry dWN0IHdvcmtfc3RydWN0CQlyZXNldF93b3JrOwo+ICAgCXN0cnVjdCBub3RpZmllcl9ibG9jawkJ YWNwaV9uYjsKPiBAQCAtMTYyOSw2ICsxNjMwLDggQEAgc3RydWN0IGFtZGdwdV9kZXZpY2Ugewo+ ICAgCXVuc2lnbmVkIGxvbmcgbGFzdF9tbV9pbmRleDsKPiAgIAlib29sICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGluX2dwdV9yZXNldDsKPiAgIAlzdHJ1Y3QgbXV0ZXggIGxvY2tfcmVzZXQ7 Cj4gKwo+ICsJdTY0CQkJCXN5c21lbV9tYXhfaW87Cj4gICB9Owo+ICAgCj4gICBzdGF0aWMgaW5s aW5lIHN0cnVjdCBhbWRncHVfZGV2aWNlICphbWRncHVfdHRtX2FkZXYoc3RydWN0IHR0bV9ib19k ZXZpY2UgKmJkZXYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2Uu Ywo+IGluZGV4IDg1MDQ1M2U4OTdmOS4uYzRiY2E2MmVlZmYxIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IEBAIC0xNzQyLDYgKzE3NDIsMTkgQEAg Ym9vbCBhbWRncHVfZGV2aWNlX2hhc19kY19zdXBwb3J0KHN0cnVjdCBhbWRncHVfZGV2aWNlICph ZGV2KQo+ICAgCXJldHVybiBhbWRncHVfZGV2aWNlX2FzaWNfaGFzX2RjX3N1cHBvcnQoYWRldi0+ YXNpY190eXBlKTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgdm9pZCBhbWRncHVfZGV2aWNlX2dldF9t YXhfaW9fb2Zfc3lzbWVtKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICt7Cj4gKwlzdHJ1 Y3QgcmVzb3VyY2UgKnRtcDsKPiArCj4gKwlmb3IgKHRtcCA9IGlvbWVtX3Jlc291cmNlLmNoaWxk OyB0bXA7IHRtcCA9IHRtcC0+c2libGluZykgewo+ICsJCWlmICh0bXAtPmZsYWdzID09IChJT1JF U09VUkNFX1NZU1RFTV9SQU0gfCBJT1JFU09VUkNFX0JVU1kpKQo+ICsJCQlhZGV2LT5zeXNtZW1f bWF4X2lvID0gbWF4KGFkZXYtPnN5c21lbV9tYXhfaW8sCj4gKwkJCQkJCSAgdG1wLT5lbmQpOwoK TmlmdHkgaWRlYS4gSSB3YXMgdGhpbmtpbmcgYWJvdXQgdXNpbmcgbWF4X3BmbiwgYnV0IHRha2lu ZyBhIGxvb2sgYXQgCmlvbWVtX3Jlc291cmNlIGlzIGluZGVlZCBtdWNoIGJldHRlci4KCkJ1dCBw bGVhc2UgZHJvcCB0aGUgdG1wLT5mbGFncyBjaGVjaywgd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhh dCB3ZSAKaGFuZGxlIGhvdCBwbHVnZ2VkIG1lbW9yeSBhbmQgbWF5YmUgb3RoZXIgSU8gcmVzb3Vy Y2VzIGluIHRoZSBmdXR1cmUgYXMgCndlbGwuCgpNaWdodCBiZSBhIGdvb2QgaWRlYSB0byBtYWtl IHRoYXQgYSBnZW5lcmFsIGRybSBmdW5jdGlvbiBhbmQgZml4IHJhZGVvbiAKYXMgd2VsbCwgc2Vl IGRybV9hcmNoX2Nhbl93Y19tZW1vcnkoKSBhcyB3ZWxsLiBBdCBtaW5pbXVtIEkgd291bGQgc2Vu ZCAKaXQgdG8gZHJpLWRldmVsIGZvciByZXZpZXcgYXMgd2VsbC4KClJlZ2FyZHMsCkNocmlzdGlh bi4KCj4gKwl9Cj4gKwlEUk1fSU5GTygiU3lzdGVtIFJhbSBtYXggaW8gYWRkcmVzcyBpcyAweCVs bHhcbiIsIGFkZXYtPnN5c21lbV9tYXhfaW8pOwo+ICt9Cj4gKwo+ICsKPiAgIC8qKgo+ICAgICog YW1kZ3B1X2RldmljZV9pbml0IC0gaW5pdGlhbGl6ZSB0aGUgZHJpdmVyCj4gICAgKgo+IEBAIC0x Nzk1LDYgKzE4MDgsNyBAQCBpbnQgYW1kZ3B1X2RldmljZV9pbml0KHN0cnVjdCBhbWRncHVfZGV2 aWNlICphZGV2LAo+ICAgCWFkZXYtPmdjX2NhY193cmVnID0gJmFtZGdwdV9pbnZhbGlkX3dyZWc7 Cj4gICAJYWRldi0+YXVkaW9fZW5kcHRfcnJlZyA9ICZhbWRncHVfYmxvY2tfaW52YWxpZF9ycmVn Owo+ICAgCWFkZXYtPmF1ZGlvX2VuZHB0X3dyZWcgPSAmYW1kZ3B1X2Jsb2NrX2ludmFsaWRfd3Jl ZzsKPiArCWFtZGdwdV9kZXZpY2VfZ2V0X21heF9pb19vZl9zeXNtZW0oYWRldik7Cj4gICAKPiAg IAlEUk1fSU5GTygiaW5pdGlhbGl6aW5nIGtlcm5lbCBtb2Rlc2V0dGluZyAoJXMgMHglMDRYOjB4 JTA0WCAweCUwNFg6MHglMDRYIDB4JTAyWCkuXG4iLAo+ICAgCQkgYW1kZ3B1X2FzaWNfbmFtZVth ZGV2LT5hc2ljX3R5cGVdLCBwZGV2LT52ZW5kb3IsIHBkZXYtPmRldmljZSwKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gaW5kZXggOTVmOTkwMTQwZjJhLi5hMDIxZGU5 NjI5YWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gQEAg LTEwMTgsNyArMTAxOCw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3R0bV90dF9wb3B1bGF0ZShzdHJ1 Y3QgdHRtX3R0ICp0dG0sCj4gICAJfQo+ICAgCj4gICAjaWZkZWYgQ09ORklHX1NXSU9UTEIKPiAt CWlmIChzd2lvdGxiX25yX3RibCgpKSB7Cj4gKwlpZiAoYWRldi0+bmVlZF9zd2lvdGxiICYmIHN3 aW90bGJfbnJfdGJsKCkpIHsKPiAgIAkJcmV0dXJuIHR0bV9kbWFfcG9wdWxhdGUoJmd0dC0+dHRt LCBhZGV2LT5kZXYsIGN0eCk7Cj4gICAJfQo+ICAgI2VuZGlmCj4gQEAgLTEwNDUsNyArMTA0NSw3 IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV90dG1fdHRfdW5wb3B1bGF0ZShzdHJ1Y3QgdHRtX3R0ICp0 dG0pCj4gICAJYWRldiA9IGFtZGdwdV90dG1fYWRldih0dG0tPmJkZXYpOwo+ICAgCj4gICAjaWZk ZWYgQ09ORklHX1NXSU9UTEIKPiAtCWlmIChzd2lvdGxiX25yX3RibCgpKSB7Cj4gKwlpZiAoYWRl di0+bmVlZF9zd2lvdGxiICYmIHN3aW90bGJfbnJfdGJsKCkpIHsKPiAgIAkJdHRtX2RtYV91bnBv cHVsYXRlKCZndHQtPnR0bSwgYWRldi0+ZGV2KTsKPiAgIAkJcmV0dXJuOwo+ICAgCX0KPiBAQCAt MjAwNyw3ICsyMDA3LDcgQEAgc3RhdGljIGludCBhbWRncHVfdHRtX2RlYnVnZnNfaW5pdChzdHJ1 Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAljb3VudCA9IEFSUkFZX1NJWkUoYW1kZ3B1X3R0 bV9kZWJ1Z2ZzX2xpc3QpOwo+ICAgCj4gICAjaWZkZWYgQ09ORklHX1NXSU9UTEIKPiAtCWlmICgh c3dpb3RsYl9ucl90YmwoKSkKPiArCWlmICghKGFkZXYtPm5lZWRfc3dpb3RsYiAmJiBzd2lvdGxi X25yX3RibCgpKSkKPiAgIAkJLS1jb3VudDsKPiAgICNlbmRpZgo+ICAgCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192Nl8wLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9nbWNfdjZfMC5jCj4gaW5kZXggNWVhY2MwODE5YjY2Li41ODhjOTAwMDc1ZGEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y2XzAuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192Nl8wLmMKPiBAQCAtODU1LDYgKzg1 NSw3IEBAIHN0YXRpYyBpbnQgZ21jX3Y2XzBfc3dfaW5pdCh2b2lkICpoYW5kbGUpCj4gICAKPiAg IAlhZGV2LT5uZWVkX2RtYTMyID0gZmFsc2U7Cj4gICAJZG1hX2JpdHMgPSBhZGV2LT5uZWVkX2Rt YTMyID8gMzIgOiA0MDsKPiArCWFkZXYtPm5lZWRfc3dpb3RsYiA9IGFkZXYtPnN5c21lbV9tYXhf aW8gPiAoMSA8PCBkbWFfYml0cyk7Cj4gICAJciA9IHBjaV9zZXRfZG1hX21hc2soYWRldi0+cGRl diwgRE1BX0JJVF9NQVNLKGRtYV9iaXRzKSk7Cj4gICAJaWYgKHIpIHsKPiAgIAkJYWRldi0+bmVl ZF9kbWEzMiA9IHRydWU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2dtY192N18wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjdfMC5jCj4gaW5k ZXggY2U3ZjQ4NGY4NmY5Li4xNzIzZDIxNTFmMGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvZ21jX3Y3XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2dtY192N18wLmMKPiBAQCAtMTAwMyw2ICsxMDAzLDcgQEAgc3RhdGljIGludCBnbWNfdjdf MF9zd19pbml0KHZvaWQgKmhhbmRsZSkKPiAgIAkgKi8KPiAgIAlhZGV2LT5uZWVkX2RtYTMyID0g ZmFsc2U7Cj4gICAJZG1hX2JpdHMgPSBhZGV2LT5uZWVkX2RtYTMyID8gMzIgOiA0MDsKPiArCWFk ZXYtPm5lZWRfc3dpb3RsYiA9IGFkZXYtPnN5c21lbV9tYXhfaW8gPiAoMSA8PCBkbWFfYml0cyk7 Cj4gICAJciA9IHBjaV9zZXRfZG1hX21hc2soYWRldi0+cGRldiwgRE1BX0JJVF9NQVNLKGRtYV9i aXRzKSk7Cj4gICAJaWYgKHIpIHsKPiAgIAkJYWRldi0+bmVlZF9kbWEzMiA9IHRydWU7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OF8wLmMgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjhfMC5jCj4gaW5kZXggZjUzZjM5MzZmZDRmLi4xZjIw OWY5MmEyZmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y4 XzAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dtY192OF8wLmMKPiBAQCAt MTEwMSw2ICsxMTAxLDcgQEAgc3RhdGljIGludCBnbWNfdjhfMF9zd19pbml0KHZvaWQgKmhhbmRs ZSkKPiAgIAkgKi8KPiAgIAlhZGV2LT5uZWVkX2RtYTMyID0gZmFsc2U7Cj4gICAJZG1hX2JpdHMg PSBhZGV2LT5uZWVkX2RtYTMyID8gMzIgOiA0MDsKPiArCWFkZXYtPm5lZWRfc3dpb3RsYiA9IGFk ZXYtPnN5c21lbV9tYXhfaW8gPiAoKHU2NCkxIDw8IGRtYV9iaXRzKTsKPiAgIAlyID0gcGNpX3Nl dF9kbWFfbWFzayhhZGV2LT5wZGV2LCBETUFfQklUX01BU0soZG1hX2JpdHMpKTsKPiAgIAlpZiAo cikgewo+ICAgCQlhZGV2LT5uZWVkX2RtYTMyID0gdHJ1ZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2dtY192OV8wLmMKPiBpbmRleCAyYzYwOTgxZDJlZWMuLmRhN2FiNDZjNGNiYiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nbWNfdjlfMC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ21jX3Y5XzAuYwo+IEBAIC04NzksNiArODc5LDcgQEAg c3RhdGljIGludCBnbWNfdjlfMF9zd19pbml0KHZvaWQgKmhhbmRsZSkKPiAgIAkgKi8KPiAgIAlh ZGV2LT5uZWVkX2RtYTMyID0gZmFsc2U7Cj4gICAJZG1hX2JpdHMgPSBhZGV2LT5uZWVkX2RtYTMy ID8gMzIgOiA0NDsKPiArCWFkZXYtPm5lZWRfc3dpb3RsYiA9IGFkZXYtPnN5c21lbV9tYXhfaW8g PiAoMSA8PCBkbWFfYml0cyk7Cj4gICAJciA9IHBjaV9zZXRfZG1hX21hc2soYWRldi0+cGRldiwg RE1BX0JJVF9NQVNLKGRtYV9iaXRzKSk7Cj4gICAJaWYgKHIpIHsKPiAgIAkJYWRldi0+bmVlZF9k bWEzMiA9IHRydWU7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK