Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Co9ku-0003Ll-J1 for qemu-devel@nongnu.org; Mon, 10 Jan 2005 19:19:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Co9ki-0003FI-IG for qemu-devel@nongnu.org; Mon, 10 Jan 2005 19:19:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Co9kh-0003BF-Ba for qemu-devel@nongnu.org; Mon, 10 Jan 2005 19:19:15 -0500 Received: from [195.250.128.83] (helo=smtp3.vol.cz) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1Co9OI-0000fx-Je for qemu-devel@nongnu.org; Mon, 10 Jan 2005 18:56:06 -0500 Received: from [10.0.0.2] (prg-v-6-220.static.adsl.vol.cz [62.177.70.220]) by smtp3.vol.cz (8.12.9p2/8.12.9) with ESMTP id j0ANu3IV084158 for ; Tue, 11 Jan 2005 00:56:03 +0100 (CET) (envelope-from xnavara@volny.cz) Message-ID: <41E31614.7040702@volny.cz> Date: Tue, 11 Jan 2005 00:56:04 +0100 From: Filip Navara MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Win32 build References: <41E09627.1020802@volny.cz> <41E308AF.908@bellard.org> In-Reply-To: <41E308AF.908@bellard.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Fabrice Bellard wrote: > Filip Navara wrote: > >> Index: target-i386/ops_template.h >> =================================================================== >> RCS file: /cvsroot/qemu/qemu/target-i386/ops_template.h,v >> retrieving revision 1.8 >> diff -u -r1.8 ops_template.h >> --- target-i386/ops_template.h 3 Jan 2005 23:50:08 -0000 1.8 >> +++ target-i386/ops_template.h 9 Jan 2005 02:18:37 -0000 >> @@ -46,7 +46,7 @@ >> #define SUFFIX q >> #define DATA_TYPE uint64_t >> #define DATA_STYPE int64_t >> -#define DATA_MASK 0xffffffffffffffff >> +#define DATA_MASK 0xffffffffffffffffULL >> #else >> #error unhandled operand size >> #endif > > > Is this really needed to compile ? GCC reports lots of warnings like these otherwise: qemu/target-i386/ops_template.h: In function `compute_all_incq': qemu/target-i386/ops_template.h:182: warning: integer constant is too large for "long" type In file included from e:/DIFFs/qemu/target-i386/op.c:733: qemu/target-i386/ops_template.h: In function `compute_all_decq': qemu/target-i386/ops_template.h:204: warning: integer constant is too large for "long" type In file included from e:/DIFFs/qemu/target-i386/op.c:733: qemu/target-i386/ops_template.h: In function `op_shrq_T0_T1': qemu/target-i386/ops_template.h:436: warning: integer constant is too large for "long" type - Filip