From: "flichtenheld (Code Review)"
Date: Fri, 1 Aug 2025 09:18:28 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, ralf@...2726..., antonio@...2726...
Message-ID: <41d4baf0e50458d638e62e1c67a99490fa415ed6-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Y26Nt087g+4="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[release/2.6]: dco linux:
avoid redefining ovpn enums (2.6)
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: ralf_lici , plaisthos , openvpn-devel
--Y26Nt087g+4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos, ralf_lici.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1122?usp=3Demail )
Change subject: dco linux: avoid redefining ovpn enums (2.6)
......................................................................
Patch Set 2:
(1 comment)
File src/openvpn/dco_linux.h:
http://gerrit.openvpn.net/c/openvpn/+/1122/comment/3ccd01a6_50ffc7c4 :
PS1, Line 32: #include "ovpn_dco_linux.h"
> should we add a comment here that instructs to keep this include always l=
ast? (and maybe explain why [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1122?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I41c5dfc7489352a9534ff6b1585a5a81e0623ab1
Gerrit-Change-Number: 1122
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: ordex
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: ralf_lici
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: ordex
Gerrit-Attention: ralf_lici
Gerrit-Comment-Date: Fri, 01 Aug 2025 09:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--Y26Nt087g+4=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: ordex, plaisthos, ralf_lici.
View =
Change
1 comment:
=
Done
To view, visit change 1122. To unsubscribe, or f=
or help writing mail filters, visit settings.
=
div>
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I41c5dfc7489352a9534ff6b1585=
a5a81e0623ab1
Gerrit-Change-Number: 1122
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: ordex <antonio@...2726...&=
gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: ralf_lici <ralf@...2726...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Attention: ralf_lici <ralf@...2804...=
.>
Gerrit-Comment-Date: Fri, 01 Aug 2025 09:18:28=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--Y26Nt087g+4=--