From: "ordex (Code Review)" Date: Mon, 28 Jul 2025 08:38:18 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <41de5c857ba228265ed493abbc2bed89bbbb34ef-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ijgqAGSnUyU="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mudp.c, multi.c, multi_io.c: get rid of "all three DCO platforms" #if... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --ijgqAGSnUyU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1117?usp=3Demail ) Change subject: mudp.c, multi.c, multi_io.c: get rid of "all three DCO plat= forms" #ifdefs ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: it makes sense! thanks for cleaning this up. I started at the code and compiled tested it. Now this opens up more clean up options....i.e. moving the ugly defined(ENA= BLE_DCO) checks somewhere else. but that's for another day. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1117?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6977d23b5289eba5db436608e0500216e0e689ec Gerrit-Change-Number: 1117 Gerrit-PatchSet: 3 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 28 Jul 2025 08:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --ijgqAGSnUyU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

Patch set 3:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #3:

      it makes sense! thanks for cleaning this up.=
      I started at the code and compiled tested it.

      Now this opens up more clean up option= s....i.e. moving the ugly defined(ENABLE_DCO) checks somewhere else. but th= at's for another day.

To view, visit change 1117= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6977d23b5289eba5db436608e05= 00216e0e689ec
Gerrit-Change-Number: 1117
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 28 Jul 2025 08:38:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--ijgqAGSnUyU=--