Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC484C71155 for ; Mon, 16 Jun 2025 13:41:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8639D10E39C; Mon, 16 Jun 2025 13:41:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dNf6onWR"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 592B710E39C for ; Mon, 16 Jun 2025 13:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750081296; x=1781617296; h=message-id:date:subject:to:references:from:in-reply-to: mime-version; bh=c3UvxFJlvgzAY6OmtRs3szD3FgjqVmGvvZUK/R71EPM=; b=dNf6onWRtJo8+sdah1M7FzO8uAnbangVSaXnm50DNi6dM4KtGaLl2KQL jG2GDbmafkvGK5Pw8t9e8Wtuq9QGApSvQjVLGMNRS44kGP8sMTfvj4RAK 4MfxEETr8ZvBUVEWZD+Z5SxY8i2JX3DZtxqS7oidX/172PxpdCni0C1su u/wKFeDJ68w4dfB0YEdVBzJgywjJANmBRkBTGUHFJOxR4b/Df1Bi6HnPc ZpuF0ybO3XrJPTedqGlEahYsQY4xdMK7aASm9+F4SnHd/wQDCdrbfttf1 ARhveYmCGIL58baTlEtcd5D0publoWN1uxNahfBLjUJZe7U02W4/fnzHj Q==; X-CSE-ConnectionGUID: 2TVcOiz7RVu2gn62wPCPOw== X-CSE-MsgGUID: GEw4jurOTXOWfiqaL9X7fA== X-IronPort-AV: E=McAfee;i="6800,10657,11465"; a="63574470" X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208,217";a="63574470" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 06:41:35 -0700 X-CSE-ConnectionGUID: iratYH/GTiqUxIkXyCIqtg== X-CSE-MsgGUID: xX6sAYPOSkW5r1eaEsEKyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208,217";a="185736176" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 06:41:35 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Mon, 16 Jun 2025 06:41:34 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Mon, 16 Jun 2025 06:41:34 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (40.107.243.78) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Mon, 16 Jun 2025 06:41:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xn8u19BEFa4rFTezZ2SBcObPViSxRtpD0GPXuF4TeO1Ef2S+xbBFfTm5+UctN5WKHsZUeSR0wE8PgfS2Pn0iPU9BlCuT1ImO/9+/dVIo35B641Zpp0jFU0Yq3vDz7mApk9xoqZDS2MA5hONBKbZhk6N0b7q6i/HNh1fqTYPh/wvnVyVWVH9DddHbA7c01U+TvwHMvNt3imtt7i0MAokiz/GxJYC3EwtHwkskrqOnsNQcZV88IrCjQ6VeQoVkkcczKAUH0ti6JHLiS6ue1LTkUKkPP6o8fdXuWwZa5O8gjSTU5Cv7ZhJyA+v1oUi2eROStjmtjlTqkH481oWhJOlcsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/QhrfyBvwu6J/z4a3RCP8v7c+y4iCgk7gOqohFF93gM=; b=mzBrniVeIK88NhMF5UZ0v0s6l22dR7h57oL/7OztdxZsMpedVm6siqkOrF5fJnD1GoSHbDLjzfE1vCrByrYwJ1nET9kQYSHIgf50oB07jHwbJnigLX+etXylUjb8G15x6vWhyY/37ynv/fjN1PZYU9nJNtC6V1xjZHv8nLN7qY7QiHTeTQ0aRiqqq1c/+NWDfa6zQdoRWLiZH12idSMikV+XpnD8HEDmrAU7EeY7svmFKhQYHND1yi7adhtyhDz8MDYl/f1C5/W29bqROXsnd8+/eIjxm/hSvZMv/CCTuzjiCwhs3LAQued7j9FIkcwfUqVKCpG32WQACr8O1Rft9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM3PPFEF920636F.namprd11.prod.outlook.com (2603:10b6:f:fc00::f5d) by DS0PR11MB8164.namprd11.prod.outlook.com (2603:10b6:8:167::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 13:41:33 +0000 Received: from DM3PPFEF920636F.namprd11.prod.outlook.com ([fe80::84c:a02c:91a8:f5e]) by DM3PPFEF920636F.namprd11.prod.outlook.com ([fe80::84c:a02c:91a8:f5e%4]) with mapi id 15.20.8769.025; Mon, 16 Jun 2025 13:41:33 +0000 Content-Type: multipart/alternative; boundary="------------PJnd51YXAgyAjVzTagHE69dN" Message-ID: <41e76b54-93b6-4b07-ba95-230dfa44eca5@intel.com> Date: Mon, 16 Jun 2025 19:11:27 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] tests/kms_vrr/cmrr: Skip display config when commit already failed To: References: <20250616052920.3418160-1-mitulkumar.ajitkumar.golani@intel.com> Content-Language: en-US From: "Naladala, Ramanaidu" In-Reply-To: <20250616052920.3418160-1-mitulkumar.ajitkumar.golani@intel.com> X-ClientProxiedBy: PS2PR02CA0007.apcprd02.prod.outlook.com (2603:1096:300:41::19) To DM3PPFEF920636F.namprd11.prod.outlook.com (2603:10b6:f:fc00::f5d) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PPFEF920636F:EE_|DS0PR11MB8164:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fd6c089-0718-4931-4c47-08ddacdb8175 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cjBEcGpxU3dOcGJENFZCT2NYSnNJRld2aEw4YVRDeXVncXVJYTlxVHhQeUR5?= =?utf-8?B?a0FWcGhPVlAxbXczWmJYZnFTQ0VPbnhhaG5VcS83VjY3R3FxWUV3cGR4VXRq?= =?utf-8?B?bXdUWHdIaklOcFluZ1FQTHI2bDRublF6dHhFUTVpTGJVa3RQVFJjRHNZeVJ4?= =?utf-8?B?VXpxMk5qVzN2OUdJTlZoUWZsVEVLaTdqM0NrODJhOWd4cEFrQVo3Z3FZZjB1?= =?utf-8?B?WWtBUksrNE5DQXdkTVg2KzROQ2pudDVISFRmM2dYOFUwWXF1aG9sN0dnWkcx?= =?utf-8?B?MWlsdmZPZFNRU1BHVnBVTGFNbDJSeHpxRDNpM2YvZi9JSDNYanEzampCNkZk?= =?utf-8?B?UHNDdng2VE5zT08rSlNOU3NReG9QVEJYb1p0RkYvOFFpQjRRYURDMzZhanpR?= =?utf-8?B?bUZEUjE5TGphNlhhZVhidWZYZWlMd3V0a1o2QTF2WmtNa1Npa2JMNy9UQjNl?= =?utf-8?B?WVlPRUcvd3dKKy84QzRGdTZ6VHdwZEFWZWh0dE4rVmNYTzFvbEs2OG5TSTk3?= =?utf-8?B?bkhBYUx2WTYweHVxbnI1b3dQUldlK3NKNStBVDFxTXBqQ1QxeGoyYWdVam56?= =?utf-8?B?ZURzZ3B3YmRHMXAvc1V4bmFIa1Y2bHFpMzBiaXpKQjM5Q0FoeDJhcld3NjFD?= =?utf-8?B?SXRBbDBuYUJWYkZjWUI4VkJqc0Q2M2gzdHlFN2ZITk5RbzVUUFlWMk5aVzNn?= =?utf-8?B?cjBOWURPWjdQc3ZsbmI3bloyU1daakR0WktvbHdsK1FINFkreWpUd2tyRWJ4?= =?utf-8?B?SUNTMU9YYXNaK0Z2MkFHcHoxSXAvbDFoK052UG9rQnBQSUE1VnRzeUdWbkJm?= =?utf-8?B?ekp3eEt1TlVhTVJNT2x0VjJDUEZRaW1rSjZ2S3NKRmM3SnlVV1ZZUnUwc1ls?= =?utf-8?B?TmtvbFZkWit3VmI3MENHdVR2Z21FQkMwR1BGK00xM0NidEowYWRPUDF4K0NQ?= =?utf-8?B?c1Q3cTZKZWVQSWo5aGljOFdINGZxU3VHQW93Q0F2QmZ2MTN1bWdqMXdzdksz?= =?utf-8?B?NUlIM29LWlJ5RmlYeVBHc2FQSGFpWTBrVG1YY3BaTUhCQlk1YllaeXR5MkFs?= =?utf-8?B?aERVbDdQZHFoTjVpRWJKZHZNTFQxajBhdkNra2d5aVRJUEZwc3dJRG9QcjZu?= =?utf-8?B?V3hFblRoaFV3a2c4cVlteUFYWTQwcUl2c2hmNmwvTGJCSndVNHFDelNYdVVY?= =?utf-8?B?Wm5GQTVmMlIvbWdOeUY4YXd2QkoxVVMrNnVOd3lHbGkvcmFsb2FWeXd0OTZx?= =?utf-8?B?SDFoaHdKcUpoc29pcGJFSmdiTnBHZDgzd2JxVld1U1VTRVlhaXlvdW16Mjdh?= =?utf-8?B?dHhjYzNMa085ejNQeldEdGVNM0ZHN2dPbENsNVFnbFB5ekpXWFV3VTVlZUFk?= =?utf-8?B?RFI3U0FtQkpzUVc5cnU5bDZDOFdncmRsYkxyNWRibWIyd0JSK09zYkZiNEpK?= =?utf-8?B?ZmlIWUl3d3lBWFhCd25qM2ozcGRQdWU0R09SRXFHRk5manRFVjZpYzZaUEU1?= =?utf-8?B?OWVIajB2bndmaGNIcTZDOFVPVkJ1REo4K01sbnNTT2hIeU00N3pqOGJJSVJ2?= =?utf-8?B?d29FdEtLNVc4OTRGeUpxaWhOTys1V1k5blhHWVY1Z2ZaMlM3OGEvNkFKdWJD?= =?utf-8?B?NFJQOEdtK3p2SDBVbGtLdGpmTGtXMU4zdnRPMitJT28rUitjeGplRHdSNHJQ?= =?utf-8?B?c0t0OXdVdjNmR00vMS95cUlZVVdtd083a25JSG5NZ0h0K3R6T3o4c2ZRVDNu?= =?utf-8?B?Z3FBdVlVQnJkU1A5OEVuOHRqWmVzR0hENXBxcWtPWU5RUHROb04vNHlqN3FJ?= =?utf-8?B?dkVvd2MzV25PcXNxdWdsbWw4aWFGckJoMmJqWGNGV0VuRHhqNkhiSVZpREwx?= =?utf-8?B?U3d5RDRBYkpUMVRUV21LRjRWdDU1R2FSQmtFN014UFpoYzRaS01XWkxHbUdO?= =?utf-8?Q?EVDGGieTEAQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM3PPFEF920636F.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3QvOWlnQzA4VUZFTGRic3Y5ZCt3YjFML3RHRE50emhRQTFhRVJnaG1SWGp4?= =?utf-8?B?ZmorRXJGVzBPV2k5WFVKYmFmUW93S04wc25CUXg2WWlLTnkxc1pqZStOdmZs?= =?utf-8?B?YUVlVjRqRjFFNHV0OEREeTJ5eUxKYmx0NEtEdzBRVXQ2akl2NFdLQTJidU1Z?= =?utf-8?B?RmRwaEtNTkNQMkQ5eHBaWWNQUVNPb3lwcGpKKzV6cGZQSUNDM3cvQmIzRmIv?= =?utf-8?B?U0N2clpIa2o2ZkpKb2gyWkVVcnB4TE8vdDZZT3RBd1NOV0ZVSU1HaW81S3FV?= =?utf-8?B?cENmRHNGdS9MT3NwbXhSM05QMDV1YlFpZWZjMXh3eXFyUERVbXlmdUZzMFhl?= =?utf-8?B?OVBTODJmdUFINWxCb0w3dUIweW5vT1FxaldCVXJQaGZyTXJwYzF1Z3BlUG5Q?= =?utf-8?B?cGZEUVhTNlc0RWl6TmppTjhLMUkrUjlVcTllS0VSWTJjNXdaOElnUDB6WUNV?= =?utf-8?B?KzVGWU5HNHY3VGh5eTlTc0FoRXUvL2FLQVdGcWwyUXpBanp3Y1B1RnJWelhJ?= =?utf-8?B?NUdFUzl5aVZ4aVF5a2JLSlRXWm1CeWI3UVhWaTQ3ZytTRElSanRCckFzMUtS?= =?utf-8?B?WVd6U2F5T1JxYk01Q0VlQlUwU00rMmlMeXl4TE9PRDV3ZVZSODRjamg4d1Jp?= =?utf-8?B?emZvd2tFekJYMTFWbEIvQzFFOWw1VGhrVnFsQ1V4ZEVGeXZsa2ZZd2ZUcmVn?= =?utf-8?B?d1dWTHkwMnBtYmhHSmgzZjBUZTl0eFlySk1WVW1mL001V1dLUnFSRGljRFhC?= =?utf-8?B?R3lIVHR2NDBnVDNpbE5RMWVvUW5JaWJ1UGs5QWpXTWErTVJLaXRMRDJCUEdD?= =?utf-8?B?Um5iVTl5V1hFWnAyUEozSXMwZFlpQVA2SE5UVEtxeWtVTFJPbzVuUytwd21X?= =?utf-8?B?Wk10YkhYOC9Ld2hHSDZMazM5SmdNQ2M4SmF0dE9wWlBFVzh0d2RVeVh5c2Mv?= =?utf-8?B?NlJIbFJicHkxNWhrNFVRaHdHODRNZWw4U3FYUlhNdzdOV1B1L0RxWTNEZWJx?= =?utf-8?B?RVFqdFJvTVE1K1pNNklDQUZvK0JKM2lwemxQdVpCREErQXBPbXo0KzFMbksx?= =?utf-8?B?dFQ0RXJlQzcrUjN0cSt0T3JQcXIyUE1zdmdnUCtCYy9Fbng3anFldThtWmR2?= =?utf-8?B?THZNUjY4a3hnczVGSGRqeGo1SmtVMThGdERSZk4wam5tQ1pDOFZDZWRFRHV0?= =?utf-8?B?ZzNkWk81SEF5RldjOU80ZFBlaHN4MkFaWHVuak5WTnBnTmU1VWpSR08vMG1G?= =?utf-8?B?VTFEZUhKanlYQThwMEt6cG1ZaE9QUzkxdjBlY1duMWMvRWVQbEo5ajErUVM3?= =?utf-8?B?TUtIUy9OSE5ZRHFVY3hEK3VaV3VYVUNiTXNXMThwSTRtZ29lM2ZKL0IzajBl?= =?utf-8?B?NUVIS1BhWEFqczZlQWYvWjdjUVZjc25aQmlQQ3lTdzR0OTZ0RGFoRWowVnBU?= =?utf-8?B?UDlpeGE5Sitocjh4L1BFMXJlanVqVVIrZnQ2QUxnK0dOd1ltMnkwZUcxdDQx?= =?utf-8?B?Vkdma29LSXFZb01Ec2pVZmVsNnFTbFNKREovd1c2KzZKUWdOWXVhNWYxVVc4?= =?utf-8?B?REZ3N3hZN2hGdHQ0bngyRTZ6ZW9CVUJWdXpCNGc1T0MwWE10SWVuWThhU2Fl?= =?utf-8?B?RGx1RWtQMkxmakpHUG82c1oxeUtqUkZrTmZDSk55dlArSFVXbXJTc2Z5MU1R?= =?utf-8?B?dlBqZkdtZHpvY29MbTJralY5dXliRm4vKy8wUy9SNG9tc1YzSDNzNTVhdXU3?= =?utf-8?B?bmcwczlwRlNrSTl6a0FzeUduaDhxM042Vmo0SFhUVitTdUhDQ0EyV3NEOUhV?= =?utf-8?B?cUkvTUE2T2lSc2dEWmM5alM3T0JYdUg2NmkwZXBXY1pOZmNxRnIydU15R1dx?= =?utf-8?B?QXZWMlh1WC9odGNBTGp4a01ZTXFFa01pYzVhSWwrcXY4bjczSVAzT0pjQTBC?= =?utf-8?B?M3ZsL0VPZGxmblpqcFRtYnhIL25IWXNZcDVRUGNNQ1prS09SNkFZREM4RldI?= =?utf-8?B?eGU3TklYdThSN1JtdTNCdzBaUU9NZ3Vyelhydmp1TlFsTEhRY3Nid0R3bjNy?= =?utf-8?B?RlRySTc0ZWZ2OHI2akhScCtqL1duaFJmRjNPUktjZW5uYTd3NkVTUlpCaTNH?= =?utf-8?B?REFuUldGNWlySEZHanQ4dysxbk4vc1U2RS9rYU5HNzh2NGQrZzVhUy9WRExH?= =?utf-8?B?U3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0fd6c089-0718-4931-4c47-08ddacdb8175 X-MS-Exchange-CrossTenant-AuthSource: DM3PPFEF920636F.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 13:41:33.0112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Scm+XOgDuJ+q+b0+Sztl1JE2GDQFKOvmN/f4FWbYmVcCm1IbWhepmoW+Lb3rSkEmHzBQ8eW+QYbsV1YzinhoU1nEW2Qs+Zff2uQrvJ8++hU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8164 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------PJnd51YXAgyAjVzTagHE69dN Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 6/16/2025 10:59 AM, Mitul Golani wrote: > Don't prepare display pipe when commit already failed for tweaked > display mode. In this case display commit may already been rejected, > and still test tries to set display params on the same. If corresponding > CMRR mode is not found and tweaked mode is already failed to commit then > better further operation should be skipped. > > Signed-off-by: Mitul Golani > --- > tests/kms_vrr.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c > index d371d9d7f..01e5f73c0 100644 > --- a/tests/kms_vrr.c > +++ b/tests/kms_vrr.c > @@ -920,13 +920,15 @@ test_cmrr(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags) > } > > igt_output_override_mode(output, &mode); > - igt_display_commit2(&data->display, COMMIT_ATOMIC); > > - prepare_test(data, output, pipe); > - result = flip_and_measure_cmrr(data, output, pipe, TEST_DURATION_NS * 2); > - igt_assert_f(result > 75, > - "Refresh rate (%u Hz) %"PRIu64"ns: Target CMRR on threshold not reached, result was %u%%\n", > - mode.vrefresh, igt_kms_frame_time_from_vrefresh(mode.vrefresh), result); > + if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) { > + prepare_test(data, output, pipe); > + result = flip_and_measure_cmrr(data, output, pipe, TEST_DURATION_NS * 2); > + igt_assert_f(result > 75, > + "Refresh rate (%u Hz) %"PRIu64"ns: Target CMRR on threshold not reached, result was %u%%\n", > + mode.vrefresh, igt_kms_frame_time_from_vrefresh(mode.vrefresh), > + result); > + } > } > LGTM, > Reviewed-by: Naladala Ramanaidu > > > static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output) --------------PJnd51YXAgyAjVzTagHE69dN Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 6/16/2025 10:59 AM, Mitul Golani wrote:
Don't prepare display pipe when commit already failed for tweaked
display mode. In this case display commit may already been rejected,
and still test tries to set display params on the same. If corresponding
CMRR mode is not found and tweaked mode is already failed to commit then
better further operation should be skipped.

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 tests/kms_vrr.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index d371d9d7f..01e5f73c0 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -920,13 +920,15 @@ test_cmrr(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 	}
 
 	igt_output_override_mode(output, &mode);
-	igt_display_commit2(&data->display, COMMIT_ATOMIC);
 
-	prepare_test(data, output, pipe);
-	result = flip_and_measure_cmrr(data, output, pipe, TEST_DURATION_NS * 2);
-	igt_assert_f(result > 75,
-		     "Refresh rate (%u Hz) %"PRIu64"ns: Target CMRR on threshold not reached, result was %u%%\n",
-		     mode.vrefresh, igt_kms_frame_time_from_vrefresh(mode.vrefresh), result);
+	if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) {
+		prepare_test(data, output, pipe);
+		result = flip_and_measure_cmrr(data, output, pipe, TEST_DURATION_NS * 2);
+		igt_assert_f(result > 75,
+			     "Refresh rate (%u Hz) %"PRIu64"ns: Target CMRR on threshold not reached, result was %u%%\n",
+			     mode.vrefresh, igt_kms_frame_time_from_vrefresh(mode.vrefresh),
+			     result);
+	}
 }
LGTM,
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
 
 static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output)
--------------PJnd51YXAgyAjVzTagHE69dN--