From: Michael Ellerman Date: Mon, 13 Aug 2018 11:22:54 +0000 Subject: Re: [16/19] powerpc/powermac: Add missing include of header pmac.h Message-Id: <41ptct30gwz9ryt@ozlabs.org> List-Id: In-Reply-To: <20180322202007.23088-17-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Mathieu Malaterre Cc: Mathieu Malaterre , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org On Thu, 2018-03-22 at 20:20:02 UTC, Mathieu Malaterre wrote: > The header `pmac.h` was not included, leading to the following warnings, > treated as error with W=1: > > arch/powerpc/platforms/powermac/time.c:69:13: error: no previous prototype for ‘pmac_time_init’ [-Werror=missing-prototypes] > arch/powerpc/platforms/powermac/time.c:207:15: error: no previous prototype for ‘pmac_get_boot_time’ [-Werror=missing-prototypes] > arch/powerpc/platforms/powermac/time.c:222:6: error: no previous prototype for ‘pmac_get_rtc_time’ [-Werror=missing-prototypes] > arch/powerpc/platforms/powermac/time.c:240:5: error: no previous prototype for ‘pmac_set_rtc_time’ [-Werror=missing-prototypes] > arch/powerpc/platforms/powermac/time.c:259:12: error: no previous prototype for ‘via_calibrate_decr’ [-Werror=missing-prototypes] > arch/powerpc/platforms/powermac/time.c:311:13: error: no previous prototype for ‘pmac_calibrate_decr’ [-Werror=missing-prototypes] > > The function `via_calibrate_decr` was made static to silence a warning. > > Signed-off-by: Mathieu Malaterre Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/2fff0f07b8441a481eb5fc0bfcd0e4 cheers