From: "plaisthos (Code Review)" Date: Wed, 1 Apr 2026 11:34:25 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <42093d5c4f12ba87524bf22928b14f9645b3a073-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9YTv1Rq/iu4="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: OpenSSL 4.0: Use X509_check_certificate_times instead of X509_cmp_time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , openvpn-devel --9YTv1Rq/iu4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.= openvpn.net/c/openvpn/+/1595?usp=3Demail ) Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X5= 09_cmp_time ...................................................................... Patch Set 2: (2 comments) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1595/comment/9936038d_d6f94305?usp=3D= email : PS2, Line 691: msg(D_TLS_DEBUG_MED, "Failed to initialise certifica= te verification parameters."); > Shouldn't we return from the function here? yeah. Good catch http://gerrit.openvpn.net/c/openvpn/+/1595/comment/2d685abe_e195c5f2?usp=3D= email : PS2, Line 708: if (ret =3D=3D X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD) > error, not ret Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1595?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25ded81f0f5ddd5 Gerrit-Change-Number: 1595 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 01 Apr 2026 11:34:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld --9YTv1Rq/iu4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld.

View = Change

2 comments:

  • File src/openvpn/ssl_openssl.c:

    • Patch Se= t #2, Line 691: = msg(D_TLS_DEBUG_MED, "Failed to initialise certificate verification p= arameters.");

      Shouldn't we return from the f= unction here?

      yeah. Good catch

    • Patch Set #2, Line 708: if (ret =3D=3D X509_V_ERR_ERROR_IN_CERT_NOT_AFTER_FIELD)

      =

      error, not ret

      Acknowledged

  • =

To view, visit change 1595. To unsubscribe, or for help writing mail fi= lters, visit set= tings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25= ded81f0f5ddd5
Gerrit-Change-Number: 1595
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 11:34:25= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
= --9YTv1Rq/iu4=--