From: "ssbssa (Code Review)" Date: Tue, 28 May 2024 17:43:34 +0000 In-Reply-To: References: Reply-To: ssbssa@...360..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <421eaeac5309f614b8a6dd19e2df6a0f1512bba0-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sHTul4PtsCo="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement Windows CA template match for Crypto-API selector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --sHTul4PtsCo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ssbssa has posted comments on this change. ( http://gerrit.openvpn.net/c/op= envpn/+/621?usp=3Demail ) Change subject: Implement Windows CA template match for Crypto-API selector ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This was originally sent by Heigo Wundram [1], and I'm reposting it (with some small changes) because I also need this. Changes since v2: - Added man page docu for cryptoapicert "TMPL:" - Removed the if() of the first CryptFindOIDInfo call as was suggested. - Removed the "V1 extension (Windows 2K and below)" part, or does openvpn still support Win2K? - Call find_oid only if Objid doesn't match the template name. - The code in find_certificate_in_store was a bit reordered, it should be easier to understand now. [1] https://patchwork.openvpn.net/project/openvpn2/patch/20210525092510.275= 17-1-heiko.wundram@...2614.../ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/621?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351 Gerrit-Change-Number: 621 Gerrit-PatchSet: 1 Gerrit-Owner: ssbssa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 28 May 2024 17:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --sHTul4PtsCo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #1:

      This was originally sent by Heigo Wundram [1], and= I'm reposting it (with
      some small changes) because I also need this= .

      [1] https://pa=
      tchwork.openvpn.net/project/openvpn2/patch/20210525092510.27517-1-heiko.wun=
      dram@...2614.../

To view, visit change 621. To unsubsc= ribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b48= 9dbe811de5351
Gerrit-Change-Number: 621
Gerrit-PatchSet: 1
Gerrit-Owner: ssbssa <ssbssa@...360...> =
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 28 May 2024 17:43:34= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--sHTul4PtsCo=--