Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3945815AC3 for ; Fri, 16 Jun 2023 09:59:38 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89886194 for ; Fri, 16 Jun 2023 02:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686909571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wfjaC6MUnoKN+p3hX3zNRvhT+UuQZxURXW0656kBJ/E=; b=Yw4syrsIoS8C1t4Vr97STHeF19JKA8H1ZZb18agmpVeue+ZuGVM3GjJRC64sm4DCCz8Sb7 U4cu6NvONGxlorappkZR5iAYW6tmsUBIVGk5soTHPrWHwqULW8R7WQnEFDdHEJZyxb04tk IAMMD13gerMDQCmim43szeUobzq9lRM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-487-XEibdNdxP4CBxR5I7g7f6A-1; Fri, 16 Jun 2023 05:59:27 -0400 X-MC-Unique: XEibdNdxP4CBxR5I7g7f6A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A05231C0758D; Fri, 16 Jun 2023 09:59:26 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E0DE2166B25; Fri, 16 Jun 2023 09:59:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1410156.1686729856@warthog.procyon.org.uk> <20230615222327.15e85c55@kernel.org> To: Willem de Bruijn Cc: dhowells@redhat.com, Jakub Kicinski , netdev@vger.kernel.org, syzbot+d8486855ef44506fd675@syzkaller.appspotmail.com, David Ahern , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jens Axboe , Matthew Wilcox , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] ip, ip6: Fix splice to raw and ping sockets Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <424201.1686909563.1@warthog.procyon.org.uk> Date: Fri, 16 Jun 2023 10:59:23 +0100 Message-ID: <424202.1686909563@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Willem de Bruijn wrote: > Disabling splicing if not ip_generic_getfrag sounds great to me. I have a patch in the works that passes msghdr through getfrag that allows this to work if we definitely want to splice into raw and icmp sockets. David