From: "flichtenheld (Code Review)" Date: Tue, 12 Dec 2023 13:58:18 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <425cb9c4392d76b12853964b26bcdd4ad5ff3aa1-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="gugMHOjkwpM="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --gugMHOjkwpM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/468?usp=3Demail ) Change subject: test_user_pass: new UT for get_user_pass ...................................................................... Patch Set 4: (1 comment) File tests/unit_tests/openvpn/test_user_pass.c: http://gerrit.openvpn.net/c/openvpn/+/468/comment/4030de4e_a0b3b845 : PS3, Line 86: } > I think we should be consistent here. Either do the (void) var; in all mo= cked functions or none. [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Gerrit-Change-Number: 468 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 12 Dec 2023 13:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos Gerrit-MessageType: comment --gugMHOjkwpM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File tests/unit_tests/openvpn/test_u= ser_pass.c:

    • Patch S= et #3, Line 86: }

      I think we should be consistent here. Either do the (void)= var; in all mocked functions or none. [=E2=80=A6]

      Done

    <= /ul>

    To view, visit change 468. To unsubscribe, or for help writing mail filte= rs, visit settings.

    <= div itemscope itemtype=3D"http://schema.org/EmailMessage">
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I193aef06912f01426dd4ac298aa= dfab97dd75a35
    Gerrit-Change-Number: 468
    Gerrit-PatchSet: 4
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Tue, 12 Dec 2023 13:58:18= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
    Gerrit-MessageType: comment
    --gugMHOjkwpM=--