Received-SPF: neutral (google.com: 212.227.126.130 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.130;
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Shivani Bhardwaj <shivanib134@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: lustre: lpoc_osc:  Change the variable to be checked
Date: Fri, 16 Oct 2015 10:41:05 +0200
Message-ID: <4275207.TTHHeQE8pW@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20151016083218.GA2815@ubuntu>
References: <20151016083218.GA2815@ubuntu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Friday 16 October 2015 14:02:18 Shivani Bhardwaj wrote:
> index 053d508..cdc7f88 100644
> --- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
> +++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
> @@ -61,9 +61,7 @@ static ssize_t active_store(struct kobject *kobj, struct attribute *attr,
>         unsigned long val;
>  
>         rc = kstrtoul(buffer, 10, &val);
> -       if (rc)
> -               return rc;
> -       if (val < 0 || val > 1)
> +       if (rc < 0)
>                 return -ERANGE;
>  
>         /* opposite senses */
> -- 
> 

I believe the intention of the code is to return -ERANGE if anything other
than 0 or 1 is stored here, which no longer works after your patch. The
range check in kstrtoul only ensures that there is a number that fits within
an 'unsigned long'.

	Arnd