From: Carsten Otte Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support Date: Wed, 11 May 2005 17:33:59 +0200 Message-ID: <428225E7.4070605@freenet.de> References: <428216F7.30303@de.ibm.com> <20050511150924.GA29976@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org Return-path: Received: from mtagate2.de.ibm.com ([195.212.29.151]:11730 "EHLO mtagate2.de.ibm.com") by vger.kernel.org with ESMTP id S261169AbVEKPeC (ORCPT ); Wed, 11 May 2005 11:34:02 -0400 To: Christoph Hellwig In-Reply-To: <20050511150924.GA29976@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > This is a lot of code for a very special case. > >Could you try to put all the xip code into a separate file, e.g. mm/xip.c >that's only built when CONFIG_XIP is set? It would probably require >duplicating a little more code if you want clean interfaces, e.g. probably >a separate set of generic operations. > > > Indeed that seems reasonable. There is no exact reason to have this built into a kernel on a platform that does not have a bdev for this. On the other hand, I believe the code should stay in filemap.c, because it fits there conceptually. And I personally dislike #ifdef in the middle of a file.